Sign upLogin

chrislit/abydos

View on GitHub
Star
abydos/util/_ncr.py

Summary

Maintainability
A
25 mins
Test Coverage

Function _ncr has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def _ncr(n: float, r: float) -> float:
    r"""Return n Choose r.

    Cf. https://en.wikipedia.org/wiki/Combination
Severity: Minor
Found in abydos/util/_ncr.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Argument name n doesn't conform to snake_case naming style
Open

def _ncr(n: float, r: float) -> float:
Severity: Info
Found in abydos/util/_ncr.py by pylint

Used when the name doesn't conform to naming rules associated to its type (constant, variable, class...).

Argument name r doesn't conform to snake_case naming style
Open

def _ncr(n: float, r: float) -> float:
Severity: Info
Found in abydos/util/_ncr.py by pylint

Used when the name doesn't conform to naming rules associated to its type (constant, variable, class...).

There are no issues that match your filters.

Category
Status