Sign upLogin

chrismou/php-eol-csv

View on GitHub
Star

Showing 3 of 3 total issues

Function exports has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function(grunt) {

    grunt.initConfig({
        phpunit: {
            unit: {
Severity: Minor
Found in Gruntfile.js - About 1 hr to fix

    Method open has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            $fileName,
        $savePath = '',
        $eol = "\n",
        $fileExtension = 'csv',
        $delimiter = ",",
    Severity: Minor
    Found in src/Csv.php - About 45 mins to fix

      The method open uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

              } else {
            $this->fileHandler = fopen('php://output', 'w');
            $this->setStreamHeaders();
        }
      Severity: Minor
      Found in src/Csv.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      Severity
      Category
      Status
      Source
      Language