Sign upLogin

christophehurpeau/esnext-class

View on GitHub
Star

Showing 9 of 9 total issues

Function newClass has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

exports.newClass = function newClass(description) {
    var hasConstructor = description.hasOwnProperty('constructor');
    var hasName = description.hasOwnProperty('name');
    var hasParent = description.hasOwnProperty('extends');
    var parent = description.extends;
Severity: Minor
Found in src/index.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function newClass has 80 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.newClass = function newClass(description) {
    var hasConstructor = description.hasOwnProperty('constructor');
    var hasName = description.hasOwnProperty('name');
    var hasParent = description.hasOwnProperty('extends');
    var parent = description.extends;
Severity: Major
Found in src/index.js - About 3 hrs to fix

    Function copyProperties has 61 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    var copyProperties = function copyProperties(source, target, allowInit) {
    var sourceIsFunction = typeof source === 'function';
    Object.getOwnPropertyNames(source).forEach((key) => {
        if (sourceIsFunction && ['name', 'displayName', 'arguments', 'caller', 'length'].indexOf(key) !== -1) {
            return;
    Severity: Major
    Found in src/index.js - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                          if (key.startsWith('lazyProperty_')) {
                        console.log('deprecated prefix "lazyProperty_", prefer exports.lazy');
                        targetKey = key.substr('lazyProperty_'.length);
                    } else {
                        value = value.value;
      Severity: Major
      Found in src/index.js and 1 other location - About 1 hr to fix
      src/index.js on lines 35..40

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 60.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                          if (key.startsWith('const_')) {
                        console.log('deprecated prefix "const", prefer exports.const');
                        targetKey = key.substr('const_'.length);
                    } else {
                        value = value.value;
      Severity: Major
      Found in src/index.js and 1 other location - About 1 hr to fix
      src/index.js on lines 43..48

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 60.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Consider simplifying this complex logical expression.
      Open

                  if (target.hasOwnProperty(key)) {
                warn('duplicated: ' + key);
            } else {
                var descriptor = Object.getOwnPropertyDescriptor(source, key);
                var isConst = key.startsWith('const_')
      Severity: Major
      Found in src/index.js - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                            if (key.startsWith('lazyProperty_')) {
                        console.log('deprecated prefix "lazyProperty_", prefer exports.lazy');
                        targetKey = key.substr('lazyProperty_'.length);
                    } else {
                        value = value.value;
        Severity: Major
        Found in src/index.js - About 45 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          var isLazy = key.startsWith('lazyProperty_')
                        || (typeof descriptor.value === 'object'
                            && descriptor.value.lazyProperty === exports.lazy);
          Severity: Minor
          Found in src/index.js and 1 other location - About 40 mins to fix
          src/index.js on lines 25..27

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          var isConst = key.startsWith('const_')
                    || (typeof descriptor.value === 'object'
                        && descriptor.value.constProperty === exports.const);
          Severity: Minor
          Found in src/index.js and 1 other location - About 40 mins to fix
          src/index.js on lines 28..30

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Severity
          Category
          Status
          Source
          Language