Sign upLogin

christophehurpeau/esnext-class

View on GitHub
Star

Showing 5 of 9 total issues

Function newClass has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

exports.newClass = function newClass(description) {
    var hasConstructor = description.hasOwnProperty('constructor');
    var hasName = description.hasOwnProperty('name');
    var hasParent = description.hasOwnProperty('extends');
    var parent = description.extends;
Severity: Minor
Found in src/index.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function newClass has 80 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.newClass = function newClass(description) {
    var hasConstructor = description.hasOwnProperty('constructor');
    var hasName = description.hasOwnProperty('name');
    var hasParent = description.hasOwnProperty('extends');
    var parent = description.extends;
Severity: Major
Found in src/index.js - About 3 hrs to fix

    Function copyProperties has 61 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    var copyProperties = function copyProperties(source, target, allowInit) {
    var sourceIsFunction = typeof source === 'function';
    Object.getOwnPropertyNames(source).forEach((key) => {
        if (sourceIsFunction && ['name', 'displayName', 'arguments', 'caller', 'length'].indexOf(key) !== -1) {
            return;
    Severity: Major
    Found in src/index.js - About 2 hrs to fix

      Consider simplifying this complex logical expression.
      Open

                  if (target.hasOwnProperty(key)) {
                warn('duplicated: ' + key);
            } else {
                var descriptor = Object.getOwnPropertyDescriptor(source, key);
                var isConst = key.startsWith('const_')
      Severity: Major
      Found in src/index.js - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                            if (key.startsWith('lazyProperty_')) {
                        console.log('deprecated prefix "lazyProperty_", prefer exports.lazy');
                        targetKey = key.substr('lazyProperty_'.length);
                    } else {
                        value = value.value;
        Severity: Major
        Found in src/index.js - About 45 mins to fix
          Severity
          Category
          Status
          Source
          Language