ci-reporter/ci_reporter_rspec

View on GitHub

Showing 5 of 5 total issues

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  describe "the passing test" do
    subject(:result) { Accessor.new(load_xml_result(passing_report_path)) }

    it { should have(0).errors }
    it { should have(0).failures }
Severity: Major
Found in acceptance/verification_spec.rb and 4 other locations - About 35 mins to fix
acceptance/verification_spec.rb on lines 55..64
acceptance/verification_spec.rb on lines 84..93
acceptance/verification_spec.rb on lines 96..105
acceptance/verification_spec.rb on lines 108..117

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  describe "the test that fails in a before block" do
    subject(:result) { Accessor.new(load_xml_result(failure_in_before_report_path)) }

    it { should have(0).errors }
    it { should have(1).failures }
Severity: Major
Found in acceptance/verification_spec.rb and 4 other locations - About 35 mins to fix
acceptance/verification_spec.rb on lines 24..33
acceptance/verification_spec.rb on lines 55..64
acceptance/verification_spec.rb on lines 96..105
acceptance/verification_spec.rb on lines 108..117

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  describe "the errored test" do
    subject(:result) { Accessor.new(load_xml_result(errored_report_path)) }

    it { should have(1).errors }
    it { should have(0).failures }
Severity: Major
Found in acceptance/verification_spec.rb and 4 other locations - About 35 mins to fix
acceptance/verification_spec.rb on lines 24..33
acceptance/verification_spec.rb on lines 84..93
acceptance/verification_spec.rb on lines 96..105
acceptance/verification_spec.rb on lines 108..117

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  describe "the inner context" do
    subject(:result) { Accessor.new(load_xml_result(nested_inner_report_path)) }

    it { should have(0).errors }
    it { should have(0).failures }
Severity: Major
Found in acceptance/verification_spec.rb and 4 other locations - About 35 mins to fix
acceptance/verification_spec.rb on lines 24..33
acceptance/verification_spec.rb on lines 55..64
acceptance/verification_spec.rb on lines 84..93
acceptance/verification_spec.rb on lines 96..105

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  describe "the outer context" do
    subject(:result) { Accessor.new(load_xml_result(nested_outer_report_path)) }

    it { should have(0).errors }
    it { should have(0).failures }
Severity: Major
Found in acceptance/verification_spec.rb and 4 other locations - About 35 mins to fix
acceptance/verification_spec.rb on lines 24..33
acceptance/verification_spec.rb on lines 55..64
acceptance/verification_spec.rb on lines 84..93
acceptance/verification_spec.rb on lines 108..117

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language