Sign upLogin

ciricihq/CiriciJWTClientBundle

View on GitHub
Star

Showing 8 of 8 total issues

Method createToken has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function createToken(Request $request, $username, $password, $providerKey)
    {
        if (null === $username || null === $password) {
            throw new AuthenticationException('Username and password must be defined');
        }
Severity: Minor
Found in Security/ExternalTokenAuthenticator.php - About 1 hr to fix

    Method loginAction has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function loginAction(Request $request)
    {
        /** @var $session \Symfony\Component\HttpFoundation\Session\Session */
        $session = $request->getSession();
    Severity: Minor
    Found in Controller/SecurityController.php - About 1 hr to fix

      Method getConfigTreeBuilder has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getConfigTreeBuilder()
    {
        $treeBuilder = new TreeBuilder();
        $rootNode = $treeBuilder->root('cirici_jwt_client');
      Severity: Minor
      Found in DependencyInjection/Configuration.php - About 1 hr to fix

        Function loginAction has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public function loginAction(Request $request)
    {
        /** @var $session \Symfony\Component\HttpFoundation\Session\Session */
        $session = $request->getSession();
        Severity: Minor
        Found in Controller/SecurityController.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function createToken has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public function createToken(Request $request, $username, $password, $providerKey)
    {
        if (null === $username || null === $password) {
            throw new AuthenticationException('Username and password must be defined');
        }
        Severity: Minor
        Found in Security/ExternalTokenAuthenticator.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method initializeUser has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function initializeUser($username, $password, $salt, $token, array $payload);
        Severity: Minor
        Found in Security/ApiUserInterface.php - About 35 mins to fix

          Method initializeUser has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function initializeUser($username, $password, $salt, $token, array $payload)
          Severity: Minor
          Found in Security/ApiUser.php - About 35 mins to fix

            Avoid too many return statements within this method.
            Open

                    return true;
            Severity: Major
            Found in Security/ApiUser.php - About 30 mins to fix
              Severity
              Category
              Status
              Source
              Language