Sign upLogin

citrusbyte/ripple

View on GitHub
Star

Showing 25 of 25 total issues

Class Association has 25 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Association
    include Ripple::Translation
    attr_reader :type, :name, :options

    # association options :using, :class_name, :class, :extend, :foreign_key, :inverse
Severity: Minor
Found in lib/ripple/associations.rb - About 2 hrs to fix

    File associations.rb has 255 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'active_support/concern'
require 'active_support/dependencies'
require 'riak/walk_spec'
require 'ripple/translation'
require 'ripple/associations/proxy'
    Severity: Minor
    Found in lib/ripple/associations.rb - About 2 hrs to fix

      Method serializable_add_includes has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          def serializable_add_includes(options={})
      return unless include_associations = options.delete(:include)
    
      base_only_or_except = {
        :except => options[:except],
      Severity: Minor
      Found in lib/ripple/serialization.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method indexes_for_persistence has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          def indexes_for_persistence(prefix = '')
      Hash.new {|h,k| h[k] = Set.new }.tap do |indexes|
        # Add embedded associations' indexes
        self.class.embedded_associations.each do |association|
          documents = instance_variable_get(association.ivar)
      Severity: Minor
      Found in lib/ripple/indexes.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method attribute? has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

            def attribute?(attr_name)
        unless value = attribute(attr_name)
          false
        else
          prop = self.class.properties[attr_name]
      Severity: Minor
      Found in lib/ripple/attribute_methods/query.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method validate! has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          def validate!(owner)
      # TODO: Refactor this into an association subclass. See also GH #284
      if @options[:using] == :stored_key || @options.has_key?(:foreign_key)
        @options[:using] = :stored_key # Ensure Proxy class
        unless prop_name = @options[:foreign_key]
      Severity: Minor
      Found in lib/ripple/associations.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method assign_attributes has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          def assign_attributes(attrs, options={})
      raise ArgumentError, t('attribute_hash') unless(Hash === attrs)

      unless options[:without_protection]
        if method(:sanitize_for_mass_assignment).arity == 1 # ActiveModel 3.0
      Severity: Minor
      Found in lib/ripple/attribute_methods.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method list has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

              def list
          if block_given?
            bucket.keys do |keys|
              keys.each do |key|
                obj = find_one(key)
      Severity: Minor
      Found in lib/ripple/document/finders.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method propagate_callbacks_to_embedded_associations has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def propagate_callbacks_to_embedded_associations(name, kind)
      self.class.embedded_associations.each do |association|
        documents = instance_variable_get(association.ivar)
        # We must explicitly check #nil? (rather than just saying `if documents`)
        # because documents can be an association proxy that is proxying nil.
      Severity: Minor
      Found in lib/ripple/associations.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method serializable_hash has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def serializable_hash(options=nil)
      options = options.try(:clone) || {}
    
      unless options.has_key?(:include)
        options[:include] = self.class.embedded_associations.map(&:name)
      Severity: Minor
      Found in lib/ripple/serialization.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method define_callbacks_on has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def define_callbacks_on(klass)
      _association = self

      klass.before_save do
        if _association.linked? && !@_in_save_loaded_documents_callback
      Severity: Minor
      Found in lib/ripple/associations.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method raw_attributes= has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def raw_attributes=(attrs)
      raise ArgumentError, t('attribute_hash') unless Hash === attrs
      attrs.each do |k,v|
        next if k.to_sym == :key
        if respond_to?("#{k}=")
      Severity: Minor
      Found in lib/ripple/attribute_methods.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method initialize has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def initialize(options=Ripple.config.dup)
      options[:env] ||= {}
      options[:env][:riak_kv] ||= {}
      options[:env][:riak_kv][:js_source_dir] ||= Ripple.config.delete(:js_source_dir)
      options[:env][:riak_kv][:map_cache_size] ||= 0
      Severity: Minor
      Found in lib/ripple/test_server.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method error_message_for has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

              def error_message_for(attribute, associated_records)
          if associated_records.respond_to?(:each_with_index)
            record_errors = associated_records.enum_for(:each_with_index).collect do |record, index|
              next unless record.errors.any?
      Severity: Minor
      Found in lib/ripple/validations/associated_validator.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method create_conflict has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def create_conflict(main_record, *modifiers)
        # We have to disable all on conflict resolvers while we create conflict
        # so that they don't auto-resolve it.
        orig_hooks = Riak::RObject.on_conflict_hooks.dup
        Riak::RObject.on_conflict_hooks.clear
      Severity: Minor
      Found in lib/ripple/conflict/test_helper.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method attributes_for_persistence has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def attributes_for_persistence
      self.class.embedded_associations.inject(super) do |attrs, association|
        documents = instance_variable_get(association.ivar)
        # We must explicitly check #nil? (rather than just saying `if documents`)
        # because documents can be an association proxy that is proxying nil.
      Severity: Minor
      Found in lib/ripple/associations.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method accepts_nested_attributes_for has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def accepts_nested_attributes_for(*attr_names)
        options = { :allow_destroy => false }
        options.update(attr_names.extract_options!)

        attr_names.each do |association_name|
      Severity: Minor
      Found in lib/ripple/nested_attributes.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method find has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

              def find(*args)
          if args.first.is_a?(Array)
            args.flatten.map {|key| find_one(key) }
          else
            args.flatten!
      Severity: Minor
      Found in lib/ripple/document/finders.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      class DateTime
  def as_json(options={})
    self.utc.to_s(Ripple.date_format)
  end
      Severity: Minor
      Found in lib/ripple/core_ext/casting.rb and 1 other location - About 25 mins to fix
      lib/ripple/core_ext/casting.rb on lines 96..104

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 31.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      class Time
  def as_json(options={})
    self.utc.send(Ripple.date_format)
  end
      Severity: Minor
      Found in lib/ripple/core_ext/casting.rb and 1 other location - About 25 mins to fix
      lib/ripple/core_ext/casting.rb on lines 120..128

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 31.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language