Sign upLogin

ciudadanointeligente/partidopublico

View on GitHub
Star

Showing 182 of 182 total issues

Function personasController has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

function personasController($scope,$http,$location,$aside,$attrs){
Severity: Minor
Found in app/assets/javascripts/angular/angular_app.js - About 35 mins to fix

    Function actividad_publicasController has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function actividad_publicasController($scope,$http,$location,$aside,$attrs){
    Severity: Minor
    Found in app/assets/javascripts/angular/angular_app.js - About 35 mins to fix

      Function finanzas3Controller has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      function finanzas3Controller($scope,$http,$location,$aside,$attrs){
      Severity: Minor
      Found in app/assets/javascripts/angular/angular_app.js - About 35 mins to fix

        Function finanzas7Controller has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function finanzas7Controller($scope,$http,$location,$aside,$attrs){
        Severity: Minor
        Found in app/assets/javascripts/angular/angular_app.js - About 35 mins to fix

          Function sedesController has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          function sedesController($scope,$http,$location,$aside,$attrs){
          Severity: Minor
          Found in app/assets/javascripts/angular/angular_app.js - About 35 mins to fix

            Function finanzas6Controller has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            function finanzas6Controller($scope,$http,$location,$aside,$attrs){
            Severity: Minor
            Found in app/assets/javascripts/angular/angular_app.js - About 35 mins to fix

              Function cargosController has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              function cargosController($scope,$http,$location,$aside,$attrs){
              Severity: Minor
              Found in app/assets/javascripts/angular/angular_app.js - About 35 mins to fix

                Function tipoCargosController has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                function tipoCargosController($scope,$http,$location,$aside,$attrs){
                Severity: Minor
                Found in app/assets/javascripts/angular/angular_app.js - About 35 mins to fix

                  Function finanzas2Controller has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  function finanzas2Controller($scope,$http,$location,$aside,$attrs){
                  Severity: Minor
                  Found in app/assets/javascripts/angular/angular_app.js - About 35 mins to fix

                    Function finanzas1Controller has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    function finanzas1Controller($scope,$http,$location,$aside,$attrs){
                    Severity: Minor
                    Found in app/assets/javascripts/angular/angular_app.js - About 35 mins to fix

                      Function afiliacionsController has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                      function afiliacionsController($scope,$http,$location,$aside,$attrs){
                      Severity: Minor
                      Found in app/assets/javascripts/angular/angular_app.js - About 35 mins to fix

                        Function finanzas5Controller has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                        function finanzas5Controller($scope,$http,$location,$aside,$attrs){
                        Severity: Minor
                        Found in app/assets/javascripts/angular/angular_app.js - About 35 mins to fix

                          Similar blocks of code found in 6 locations. Consider refactoring.
                          Open

                            def eliminar
    array_fecha = params[:fecha_datos].split(' - ')
    datos_partido = IngresoCampana.where partido: @partido
    datos_de_fecha = datos_partido.where fecha_datos: Date.new(array_fecha[0].to_i, array_fecha[1].to_i, 01)
    datos_de_fecha.delete_all
                          Severity: Major
                          Found in app/controllers/ingreso_campanas_controller.rb and 5 other locations - About 35 mins to fix
                          app/controllers/afiliacions_controller.rb on lines 81..87
                          app/controllers/balance_anuals_controller.rb on lines 81..87
                          app/controllers/contratacions_controller.rb on lines 79..85
                          app/controllers/egreso_campanas_controller.rb on lines 80..86
                          app/controllers/transferencias_controller.rb on lines 80..86

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 36.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 6 locations. Consider refactoring.
                          Open

                            def eliminar
    array_fecha = params[:fecha_datos].split(' - ')
    datos_partido = EgresoCampana.where partido: @partido
    datos_de_fecha = datos_partido.where fecha_datos: Date.new(array_fecha[0].to_i, array_fecha[1].to_i, 01)
    datos_de_fecha.delete_all
                          Severity: Major
                          Found in app/controllers/egreso_campanas_controller.rb and 5 other locations - About 35 mins to fix
                          app/controllers/afiliacions_controller.rb on lines 81..87
                          app/controllers/balance_anuals_controller.rb on lines 81..87
                          app/controllers/contratacions_controller.rb on lines 79..85
                          app/controllers/ingreso_campanas_controller.rb on lines 80..86
                          app/controllers/transferencias_controller.rb on lines 80..86

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 36.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 6 locations. Consider refactoring.
                          Open

                            def eliminar
    array_fecha = params[:fecha_datos].split(' - ')
    afiliaciones_partido = Afiliacion.where partido: @partido
    afiliaciones_por_fecha = afiliaciones_partido.where fecha_datos: Date.new(array_fecha[0].to_i, array_fecha[1].to_i, 01)
    afiliaciones_por_fecha.delete_all
                          Severity: Major
                          Found in app/controllers/afiliacions_controller.rb and 5 other locations - About 35 mins to fix
                          app/controllers/balance_anuals_controller.rb on lines 81..87
                          app/controllers/contratacions_controller.rb on lines 79..85
                          app/controllers/egreso_campanas_controller.rb on lines 80..86
                          app/controllers/ingreso_campanas_controller.rb on lines 80..86
                          app/controllers/transferencias_controller.rb on lines 80..86

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 36.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 6 locations. Consider refactoring.
                          Open

                            def eliminar
    array_fecha = params[:fecha_datos].split(' - ')
    datos_partido = Transferencia.where partido: @partido
    datos_de_fecha = datos_partido.where fecha_datos: Date.new(array_fecha[0].to_i, array_fecha[1].to_i, 01)
    datos_de_fecha.delete_all
                          Severity: Major
                          Found in app/controllers/transferencias_controller.rb and 5 other locations - About 35 mins to fix
                          app/controllers/afiliacions_controller.rb on lines 81..87
                          app/controllers/balance_anuals_controller.rb on lines 81..87
                          app/controllers/contratacions_controller.rb on lines 79..85
                          app/controllers/egreso_campanas_controller.rb on lines 80..86
                          app/controllers/ingreso_campanas_controller.rb on lines 80..86

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 36.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 6 locations. Consider refactoring.
                          Open

                            def eliminar
    array_fecha = params[:fecha_datos].split(' - ')
    datos_partido = BalanceAnual.where partido: @partido
    datos_de_fecha = datos_partido.where fecha_datos: Date.new(array_fecha[0].to_i, array_fecha[1].to_i, 01)
    datos_de_fecha.delete_all
                          Severity: Major
                          Found in app/controllers/balance_anuals_controller.rb and 5 other locations - About 35 mins to fix
                          app/controllers/afiliacions_controller.rb on lines 81..87
                          app/controllers/contratacions_controller.rb on lines 79..85
                          app/controllers/egreso_campanas_controller.rb on lines 80..86
                          app/controllers/ingreso_campanas_controller.rb on lines 80..86
                          app/controllers/transferencias_controller.rb on lines 80..86

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 36.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 6 locations. Consider refactoring.
                          Open

                            def eliminar
    array_fecha = params[:fecha_datos].split(' - ')
    datos_partido = Contratacion.where partido: @partido
    datos_de_fecha = datos_partido.where fecha_datos: Date.new(array_fecha[0].to_i, array_fecha[1].to_i, 01)
    datos_de_fecha.delete_all
                          Severity: Major
                          Found in app/controllers/contratacions_controller.rb and 5 other locations - About 35 mins to fix
                          app/controllers/afiliacions_controller.rb on lines 81..87
                          app/controllers/balance_anuals_controller.rb on lines 81..87
                          app/controllers/egreso_campanas_controller.rb on lines 80..86
                          app/controllers/ingreso_campanas_controller.rb on lines 80..86
                          app/controllers/transferencias_controller.rb on lines 80..86

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 36.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Method representantes has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                          Open

                            def representantes
    @representantes = []
    t_cargos = @partido.tipo_cargos.where(representante: true)
    by_gender = []
    t_cargos.each do |tc|
                          Severity: Minor
                          Found in app/controllers/partidos_controller.rb - About 35 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Method publicacion_candidatos has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                          Open

                            def publicacion_candidatos
    @publicacion_candidatos = []
    tc_candidatos = @partido.tipo_cargos.where(candidato:true)
    tc_candidatos.each do |tc|
      filter_by = @partido.cargos.where(tipo_cargo_id:tc)
                          Severity: Minor
                          Found in app/controllers/partidos_controller.rb - About 35 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Severity
                          Category
                          Status
                          Source
                          Language