Sign upLogin

civio/quienmanda.es

View on GitHub
Star
app/models/csv_importer.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method create_entity has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

  def create_entity(attributes)
    name = attributes[:name].strip
    if name.blank?
      warn(nil, "Skipping entity with blank name...")
      return nil
Severity: Minor
Found in app/models/csv_importer.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create_entity has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def create_entity(attributes)
    name = attributes[:name].strip
    if name.blank?
      warn(nil, "Skipping entity with blank name...")
      return nil
Severity: Minor
Found in app/models/csv_importer.rb - About 1 hr to fix

    Method create_relation has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def create_relation(fact, match_result)
    # Do nothing if we're missing one of the basic elements of a relation
    if match_result[:relation_type].nil?
      warn(fact, "Skipping fact, unknown relation type '#{fact.properties[role_field]}'...")
      return
    Severity: Minor
    Found in app/models/csv_importer.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status