Sign upLogin

cj/opal-webpack

View on GitHub
Star
lib/compiler_patches/file.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method basename has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def basename(name, suffix=nil)
        %x{
          var p, q, e, f = 0, n = -1, tmp, pointerMath, origName;

          if (name === nil) {
Severity: Minor
Found in lib/compiler_patches/file.rb - About 2 hrs to fix

    Method extname has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

          def extname(path)
        raise TypeError, 'no implicit conversion of nil into String' if path.nil?
        path = path.to_path if path.respond_to?(:to_path)
        raise TypeError, "no implicit conversion of #{path.class} into String" unless path.is_a?(String)
        filename = basename(path)
    Severity: Minor
    Found in lib/compiler_patches/file.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method dirname has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def dirname(path)
        %x{
          if (path === nil) {
            #{raise TypeError, 'no implicit conversion of nil into String'}
          }
    Severity: Minor
    Found in lib/compiler_patches/file.rb - About 1 hr to fix

      Method expand_path has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def expand_path(path, basedir = nil)
        path = [basedir, path].compact.join(SEPARATOR)
        parts = path.split(SEPARATOR)
        new_parts = []
        parts[0] = Dir.home if parts.first == '~'
      Severity: Minor
      Found in lib/compiler_patches/file.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status