Sign upLogin

ckeditor/ckeditor5-engine

View on GitHub
Star
src/conversion/mapper.js

Summary

Maintainability
C
7 hrs
Test Coverage

Mapper has 21 functions (exceeds 20 allowed). Consider refactoring.
Open

export default class Mapper {
    /**
     * Creates an instance of the mapper.
     */
    constructor() {
Severity: Minor
Found in src/conversion/mapper.js - About 2 hrs to fix

    Function markerNameToElements has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        markerNameToElements( name ) {
        const boundElements = this._markerNameToElements.get( name );

        if ( !boundElements ) {
            return null;
    Severity: Minor
    Found in src/conversion/mapper.js - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getModelLength has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        getModelLength( viewNode ) {
        if ( this._viewToModelLengthCallbacks.get( viewNode.name ) ) {
            const callback = this._viewToModelLengthCallbacks.get( viewNode.name );

            return callback( viewNode );
    Severity: Minor
    Found in src/conversion/mapper.js - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

                return len;
    Severity: Major
    Found in src/conversion/mapper.js - About 30 mins to fix

      Function unbindElementFromMarkerName has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          unbindElementFromMarkerName( element, name ) {
        const nameToElements = this._markerNameToElements.get( name );

        if ( nameToElements ) {
            nameToElements.delete( element );
      Severity: Minor
      Found in src/conversion/mapper.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if ( nameToElements ) {
            nameToElements.delete( element );

            if ( nameToElements.size == 0 ) {
                this._markerNameToElements.delete( name );
      Severity: Minor
      Found in src/conversion/mapper.js and 1 other location - About 40 mins to fix
      src/conversion/mapper.js on lines 223..229

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if ( elementToNames ) {
            elementToNames.delete( name );

            if ( elementToNames.size == 0 ) {
                this._elementToMarkerNames.delete( element );
      Severity: Minor
      Found in src/conversion/mapper.js and 1 other location - About 40 mins to fix
      src/conversion/mapper.js on lines 213..219

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          bindElements( modelElement, viewElement ) {
        this._modelToViewMapping.set( modelElement, viewElement );
        this._viewToModelMapping.set( viewElement, modelElement );
    }
      Severity: Minor
      Found in src/conversion/mapper.js and 2 other locations - About 35 mins to fix
      src/view/domconverter.js on lines 154..157
      src/view/domconverter.js on lines 186..189

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          toViewRange( modelRange ) {
        return new ViewRange( this.toViewPosition( modelRange.start ), this.toViewPosition( modelRange.end ) );
    }
      Severity: Minor
      Found in src/conversion/mapper.js and 1 other location - About 30 mins to fix
      src/conversion/mapper.js on lines 285..287

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          toModelRange( viewRange ) {
        return new ModelRange( this.toModelPosition( viewRange.start ), this.toModelPosition( viewRange.end ) );
    }
      Severity: Minor
      Found in src/conversion/mapper.js and 1 other location - About 30 mins to fix
      src/conversion/mapper.js on lines 295..297

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status