Sign upLogin

ckeditor/ckeditor5-engine

View on GitHub
Star
src/view/matcher.js

Summary

Maintainability
D
1 day
Test Coverage

Function matchClasses has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

function matchClasses( patterns, element ) {
    const match = [];

    for ( const pattern of patterns ) {
        if ( pattern instanceof RegExp ) {
Severity: Minor
Found in src/view/matcher.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function matchAttributes has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

function matchAttributes( patterns, element ) {
    const match = [];

    for ( const name in patterns ) {
        const pattern = patterns[ name ];
Severity: Minor
Found in src/view/matcher.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function matchStyles has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

function matchStyles( patterns, element ) {
    const match = [];

    for ( const name in patterns ) {
        const pattern = patterns[ name ];
Severity: Minor
Found in src/view/matcher.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function isElementMatching has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

function isElementMatching( element, pattern ) {
    // If pattern is provided as function - return result of that function;
    if ( typeof pattern == 'function' ) {
        return pattern( element );
    }
Severity: Minor
Found in src/view/matcher.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function isElementMatching has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function isElementMatching( element, pattern ) {
    // If pattern is provided as function - return result of that function;
    if ( typeof pattern == 'function' ) {
        return pattern( element );
    }
Severity: Minor
Found in src/view/matcher.js - About 1 hr to fix

    Function add has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        add( ...pattern ) {
        for ( let item of pattern ) {
            // String or RegExp pattern is used as element's name.
            if ( typeof item == 'string' || item instanceof RegExp ) {
                item = { name: item };
    Severity: Minor
    Found in src/view/matcher.js - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function matchAll has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        matchAll( ...element ) {
        const results = [];

        for ( const singleElement of element ) {
            for ( const pattern of this._patterns ) {
    Severity: Minor
    Found in src/view/matcher.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

                return false;
    Severity: Major
    Found in src/view/matcher.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return match;
      Severity: Major
      Found in src/view/matcher.js - About 30 mins to fix

        Function match has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            match( ...element ) {
        for ( const singleElement of element ) {
            for ( const pattern of this._patterns ) {
                const match = isElementMatching( singleElement, pattern );
        Severity: Minor
        Found in src/view/matcher.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    if ( pattern instanceof RegExp ) {
                if ( pattern.test( style ) ) {
                    match.push( name );
                } else {
                    return null;
        Severity: Major
        Found in src/view/matcher.js and 1 other location - About 1 hr to fix
        src/view/matcher.js on lines 262..272

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 74.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    } else if ( pattern instanceof RegExp ) {
                if ( pattern.test( attribute ) ) {
                    match.push( name );
                } else {
                    return null;
        Severity: Major
        Found in src/view/matcher.js and 1 other location - About 1 hr to fix
        src/view/matcher.js on lines 327..337

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 74.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status