ckeditor/ckeditor5-utils

View on GitHub
src/dom/position.js

Summary

Maintainability
A
3 hrs
Test Coverage

Function processPositionsToAreas has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

function processPositionsToAreas( positions, { targetRect, elementRect, limiterRect, viewportRect } ) {
    const processedPositions = [];

    // This is when element is fully visible.
    const elementRectArea = elementRect.getArea();
Severity: Minor
Found in src/dom/position.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getOptimalPosition has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

export function getOptimalPosition( { element, target, positions, limiter, fitInViewport } ) {
    // If the {@link module:utils/dom/position~Options#target} is a function, use what it returns.
    // https://github.com/ckeditor/ckeditor5-utils/issues/157
    if ( isFunction( target ) ) {
        target = target();
Severity: Minor
Found in src/dom/position.js - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getBestOfProcessedPositions has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

function getBestOfProcessedPositions( processedPositions, elementRectArea ) {
    let maxFitFactor = 0;
    let bestPositionRect;
    let bestPositionName;

Severity: Minor
Found in src/dom/position.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status