Sign upLogin

ckeditor/ckeditor5-utils

View on GitHub
Star

Showing 49 of 49 total issues

Function _setUpBindToBinding has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

    _setUpBindToBinding( factory ) {
        const externalCollection = this._bindToCollection;

        // Adds the item to the collection once a change has been done to the external collection.
        //
Severity: Minor
Found in src/collection.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function diff has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

export default function diff( a, b, cmp ) {
    // Set the comparator function.
    cmp = cmp || function( a, b ) {
        return a === b;
    };
Severity: Minor
Found in src/diff.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function stopListening has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    stopListening( emitter, event, callback ) {
        const emitters = this[ _listeningTo ];
        let emitterId = emitter && _getEmitterId( emitter );
        const emitterInfo = emitters && emitterId && emitters[ emitterId ];
        const eventCallbacks = emitterInfo && event && emitterInfo.callbacks[ event ];
Severity: Minor
Found in src/emittermixin.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File emittermixin.js has 266 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * @license Copyright (c) 2003-2020, CKSource - Frederico Knabben. All rights reserved.
 * For licensing, see LICENSE.md or https://ckeditor.com/legal/ckeditor-oss-license
 */
Severity: Minor
Found in src/emittermixin.js - About 2 hrs to fix

    File observablemixin.js has 266 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
 * @license Copyright (c) 2003-2020, CKSource - Frederico Knabben. All rights reserved.
 * For licensing, see LICENSE.md or https://ckeditor.com/legal/ckeditor-oss-license
 */
    Severity: Minor
    Found in src/observablemixin.js - About 2 hrs to fix

      Function diff has 57 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export default function diff( a, b, cmp ) {
    // Set the comparator function.
    cmp = cmp || function( a, b ) {
        return a === b;
    };
      Severity: Major
      Found in src/diff.js - About 2 hrs to fix

        Function _setUpBindToBinding has 53 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            _setUpBindToBinding( factory ) {
        const externalCollection = this._bindToCollection;

        // Adds the item to the collection once a change has been done to the external collection.
        //
        Severity: Major
        Found in src/collection.js - About 2 hrs to fix

          Function fire has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
          Open

              fire( eventOrInfo, ...args ) {
        try {
            const eventInfo = eventOrInfo instanceof EventInfo ? eventOrInfo : new EventInfo( this, eventOrInfo );
            const event = eventInfo.name;
            let callbacks = getCallbacksForEvent( this, event );
          Severity: Minor
          Found in src/emittermixin.js - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function processPositionsToAreas has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
          Open

          function processPositionsToAreas( positions, { targetRect, elementRect, limiterRect, viewportRect } ) {
    const processedPositions = [];

    // This is when element is fully visible.
    const elementRectArea = elementRect.getArea();
          Severity: Minor
          Found in src/dom/position.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      if ( isAbove( targetRect, parentRect ) ) {
                parent.scrollTop -= parentRect.top - targetRect.top;
            } else if ( isBelow( targetRect, parentRect ) ) {
                parent.scrollTop += targetRect.bottom - parentRect.bottom;
            }
          Severity: Major
          Found in src/dom/scroll.js and 1 other location - About 1 hr to fix
          src/dom/scroll.js on lines 195..199

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 71.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      if ( isLeftOf( targetRect, parentRect ) ) {
                parent.scrollLeft -= parentRect.left - targetRect.left;
            } else if ( isRightOf( targetRect, parentRect ) ) {
                parent.scrollLeft += targetRect.right - parentRect.right;
            }
          Severity: Major
          Found in src/dom/scroll.js and 1 other location - About 1 hr to fix
          src/dom/scroll.js on lines 189..193

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 71.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function _createObserver has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

              static _createObserver() {
        let ObserverConstructor;

        // TODO: One day, the `ResizeObserver` API will be supported in all modern web browsers.
        // When it happens, this module will no longer make sense and should be removed and
          Severity: Minor
          Found in src/dom/resizeobserver.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function diffToChanges has 42 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          export default function diffToChanges( diff, output ) {
    const changes = [];
    let index = 0;
    let lastOperation;
          Severity: Minor
          Found in src/difftochanges.js - About 1 hr to fix

            Function listenTo has 39 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                listenTo( emitter, event, callback, options = {} ) {
        let emitterInfo, eventCallbacks;

        // _listeningTo contains a list of emitters that this object is listening to.
        // This list has the following format:
            Severity: Minor
            Found in src/emittermixin.js - About 1 hr to fix

              Function unbind has 38 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  unbind( ...unbindProperties ) {
        // Nothing to do here if not inited yet.
        if ( !( this[ observablePropertiesSymbol ] ) ) {
            return;
        }
              Severity: Minor
              Found in src/observablemixin.js - About 1 hr to fix

                Function listenTo has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                Open

                    listenTo( emitter, event, callback, options = {} ) {
        let emitterInfo, eventCallbacks;

        // _listeningTo contains a list of emitters that this object is listening to.
        // This list has the following format:
                Severity: Minor
                Found in src/emittermixin.js - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function getVisible has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                Open

                    getVisible() {
        const source = this._source;
        let visibleRect = this.clone();

        // There's no ancestor to crop <body> with the overflow.
                Severity: Minor
                Found in src/dom/rect.js - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function fire has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    fire( eventOrInfo, ...args ) {
        try {
            const eventInfo = eventOrInfo instanceof EventInfo ? eventOrInfo : new EventInfo( this, eventOrInfo );
            const event = eventInfo.name;
            let callbacks = getCallbacksForEvent( this, event );
                Severity: Minor
                Found in src/emittermixin.js - About 1 hr to fix

                  Function remove has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      remove( subject ) {
        let index, id, item;
        let itemDoesNotExist = false;
        const idProperty = this._idProperty;
                  Severity: Minor
                  Found in src/collection.js - About 1 hr to fix

                    Function bindTo has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    function bindTo( ...args ) {
    const parsedArgs = parseBindToArgs( ...args );
    const bindingsKeys = Array.from( this._bindings.keys() );
    const numberOfBindings = bindingsKeys.length;
                    Severity: Minor
                    Found in src/observablemixin.js - About 1 hr to fix
                      Severity
                      Category
                      Status
                      Source
                      Language