ckeditor/ckeditor5-utils

View on GitHub
src/observablemixin.js

Summary

Maintainability
C
1 day
Test Coverage

File observablemixin.js has 266 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * @license Copyright (c) 2003-2020, CKSource - Frederico Knabben. All rights reserved.
 * For licensing, see LICENSE.md or https://ckeditor.com/legal/ckeditor-oss-license
 */

Severity: Minor
Found in src/observablemixin.js - About 2 hrs to fix

    Function unbind has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        unbind( ...unbindProperties ) {
            // Nothing to do here if not inited yet.
            if ( !( this[ observablePropertiesSymbol ] ) ) {
                return;
            }
    Severity: Minor
    Found in src/observablemixin.js - About 1 hr to fix

      Function bindTo has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function bindTo( ...args ) {
          const parsedArgs = parseBindToArgs( ...args );
          const bindingsKeys = Array.from( this._bindings.keys() );
          const numberOfBindings = bindingsKeys.length;
      
      
      Severity: Minor
      Found in src/observablemixin.js - About 1 hr to fix

        Function set has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            set( name, value ) {
                // If the first parameter is an Object, iterate over its properties.
                if ( isObject( name ) ) {
                    Object.keys( name ).forEach( property => {
                        this.set( property, name[ property ] );
        Severity: Minor
        Found in src/observablemixin.js - About 1 hr to fix

          Function bind has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              bind( ...bindProperties ) {
                  if ( !bindProperties.length || !isStringArray( bindProperties ) ) {
                      /**
                       * All properties must be strings.
                       *
          Severity: Minor
          Found in src/observablemixin.js - About 1 hr to fix

            Function set has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                set( name, value ) {
                    // If the first parameter is an Object, iterate over its properties.
                    if ( isObject( name ) ) {
                        Object.keys( name ).forEach( property => {
                            this.set( property, name[ property ] );
            Severity: Minor
            Found in src/observablemixin.js - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status