Sign upLogin

claranet/wallix_bastion_exporter

View on GitHub
Star

Showing 14 of 14 total issues

Method Exporter.gatherMetricsLicense has 95 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (e *Exporter) gatherMetricsLicense(
    gatherGroup *sync.WaitGroup, metricsChannel chan<- prometheus.Metric, client *http.Client,
) {
    licenseInfo, err := wallix.GetLicense(client, e.Config.ScrapeURI)
    if err != nil {
Severity: Major
Found in exporter/gatherer.go - About 2 hrs to fix

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

    func (e *Exporter) gatherMetricsTargetsPasswordRetrievalAccounts(
    gatherGroup *sync.WaitGroup, metricsChannel chan<- prometheus.Metric, client *http.Client,
) {
    targetType := "password_retrieval_accounts"
    targetsPasswordRetrievalAccounts, err := wallix.GetTargets(client, e.Config.ScrapeURI, targetType)
    Severity: Major
    Found in exporter/gatherer.go and 4 other locations - About 1 hr to fix
    exporter/gatherer.go on lines 57..71
    exporter/gatherer.go on lines 73..87
    exporter/gatherer.go on lines 89..103
    exporter/gatherer.go on lines 105..119

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 145.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

    func (e *Exporter) gatherMetricsTargetsSessionAccounts(
    gatherGroup *sync.WaitGroup, metricsChannel chan<- prometheus.Metric, client *http.Client,
) {
    targetType := "session_accounts"
    targetsSessionAccounts, err := wallix.GetTargets(client, e.Config.ScrapeURI, targetType)
    Severity: Major
    Found in exporter/gatherer.go and 4 other locations - About 1 hr to fix
    exporter/gatherer.go on lines 73..87
    exporter/gatherer.go on lines 89..103
    exporter/gatherer.go on lines 105..119
    exporter/gatherer.go on lines 121..135

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 145.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

    func (e *Exporter) gatherMetricsTargetsSessionScenarioAccounts(
    gatherGroup *sync.WaitGroup, metricsChannel chan<- prometheus.Metric, client *http.Client,
) {
    targetType := "session_scenario_accounts"
    targetsSessionsScenarioAccounts, err := wallix.GetTargets(client, e.Config.ScrapeURI, targetType)
    Severity: Major
    Found in exporter/gatherer.go and 4 other locations - About 1 hr to fix
    exporter/gatherer.go on lines 57..71
    exporter/gatherer.go on lines 73..87
    exporter/gatherer.go on lines 89..103
    exporter/gatherer.go on lines 121..135

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 145.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

    func (e *Exporter) gatherMetricsTargetsSessionAccountMappings(
    gatherGroup *sync.WaitGroup, metricsChannel chan<- prometheus.Metric, client *http.Client,
) {
    targetType := "session_account_mappings"
    targetsSessionAccountMappings, err := wallix.GetTargets(client, e.Config.ScrapeURI, targetType)
    Severity: Major
    Found in exporter/gatherer.go and 4 other locations - About 1 hr to fix
    exporter/gatherer.go on lines 57..71
    exporter/gatherer.go on lines 89..103
    exporter/gatherer.go on lines 105..119
    exporter/gatherer.go on lines 121..135

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 145.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

    func (e *Exporter) gatherMetricsTargetsSessionInteractiveLogins(
    gatherGroup *sync.WaitGroup, metricsChannel chan<- prometheus.Metric, client *http.Client,
) {
    targetType := "session_interactive_logins"
    targetsSessionInteractiveLogins, err := wallix.GetTargets(client, e.Config.ScrapeURI, targetType)
    Severity: Major
    Found in exporter/gatherer.go and 4 other locations - About 1 hr to fix
    exporter/gatherer.go on lines 57..71
    exporter/gatherer.go on lines 73..87
    exporter/gatherer.go on lines 105..119
    exporter/gatherer.go on lines 121..135

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 145.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    func (e *Exporter) gatherMetricsDevices(
    gatherGroup *sync.WaitGroup, metricsChannel chan<- prometheus.Metric, client *http.Client,
) {
    devices, err := wallix.GetDevices(client, e.Config.ScrapeURI)
    if err != nil {
    Severity: Major
    Found in exporter/gatherer.go and 2 other locations - About 1 hr to fix
    exporter/gatherer.go on lines 12..25
    exporter/gatherer.go on lines 27..40

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 138.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    func (e *Exporter) gatherMetricsUsers(
    gatherGroup *sync.WaitGroup, metricsChannel chan<- prometheus.Metric, client *http.Client,
) {
    users, err := wallix.GetUsers(client, e.Config.ScrapeURI)
    if err != nil {
    Severity: Major
    Found in exporter/gatherer.go and 2 other locations - About 1 hr to fix
    exporter/gatherer.go on lines 27..40
    exporter/gatherer.go on lines 42..55

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 138.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    func (e *Exporter) gatherMetricsGroups(
    gatherGroup *sync.WaitGroup, metricsChannel chan<- prometheus.Metric, client *http.Client,
) {
    groups, err := wallix.GetGroups(client, e.Config.ScrapeURI)
    if err != nil {
    Severity: Major
    Found in exporter/gatherer.go and 2 other locations - About 1 hr to fix
    exporter/gatherer.go on lines 12..25
    exporter/gatherer.go on lines 42..55

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 138.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function doRequest has 6 return statements (exceeds 4 allowed).
    Open

    func doRequest(
    client *http.Client, method string, url string, params map[string]string, basicAuth *BasicAuth,
) (body []byte, err error) {
    req, err := http.NewRequestWithContext(context.Background(), method, url, nil)
    if err != nil {
    Severity: Major
    Found in wallix/wallix.go - About 40 mins to fix

      Function doRequest has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          client *http.Client, method string, url string, params map[string]string, basicAuth *BasicAuth,
      Severity: Minor
      Found in wallix/wallix.go - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func QuerySchemes(
    client *http.Client, url string, params map[string]string,
) (results []map[string]interface{}, err error) {
    body, err := doRequest(
        client,
        Severity: Minor
        Found in wallix/wallix.go and 1 other location - About 35 mins to fix
        wallix/wallix.go on lines 100..120

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 103.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func QueryScheme(
    client *http.Client, url string, params map[string]string,
) (result map[string]interface{}, err error) {
    body, err := doRequest(
        client,
        Severity: Minor
        Found in wallix/wallix.go and 1 other location - About 35 mins to fix
        wallix/wallix.go on lines 78..98

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 103.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method Exporter.gatherMetricsLicense has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
        Open

        func (e *Exporter) gatherMetricsLicense(
    gatherGroup *sync.WaitGroup, metricsChannel chan<- prometheus.Metric, client *http.Client,
) {
    licenseInfo, err := wallix.GetLicense(client, e.Config.ScrapeURI)
    if err != nil {
        Severity: Minor
        Found in exporter/gatherer.go - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language