Sign upLogin

clean/repository

View on GitHub
Star

Showing 4 of 4 total issues

Function collectCriteria has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    protected function collectCriteria(AbstractRepository $repository)
    {
        $result = array();
        foreach ($repository->criteria as $criteria) {
            if ($criteria instanceof AbstractRepository) {
Severity: Minor
Found in src/AbstractRepository.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Missing class import via use statement (line '85', column '23').
Open

            throw new \RuntimeException('Method call failed');
Severity: Minor
Found in src/CacheProxy.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '81', column '23').
Open

            throw new \RuntimeException(sprintf("Method %s doesn't exists in %s", $name, get_class($this->repository)));
Severity: Minor
Found in src/CacheProxy.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method collectCriteria uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $result[] = $criteria;
            }
Severity: Minor
Found in src/AbstractRepository.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Severity
Category
Status
Source
Language