Sign upLogin

clearsightstudio/ProMotion-map

View on GitHub
Star

Showing 4 of 4 total issues

File map_screen_module.rb has 310 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module ProMotion
  module MapScreenModule

    PIN_COLORS = {
      red: MKPinAnnotationColorRed,
Severity: Minor
Found in lib/ProMotion/map/map_screen_module.rb - About 3 hrs to fix

    Method annotation_view has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        def annotation_view(map_view, annotation)
      return if annotation.is_a? MKUserLocation

      params = annotation.params
    Severity: Minor
    Found in lib/ProMotion/map/map_screen_module.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method annotation_view has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def annotation_view(map_view, annotation)
      return if annotation.is_a? MKUserLocation

      params = annotation.params
    Severity: Minor
    Found in lib/ProMotion/map/map_screen_module.rb - About 1 hr to fix

      Method region has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def region(params)
      return nil unless params.is_a? Hash

      params[:coordinate] = CLLocationCoordinate2D.new(params[:coordinate][:latitude], params[:coordinate][:longitude]) if params[:coordinate].is_a? Hash
      params[:span] = MKCoordinateSpanMake(params[:span][0], params[:span][1]) if params[:span].is_a? Array
      Severity: Minor
      Found in lib/ProMotion/map/map_screen_module.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language