clearsightstudio/ProMotion

View on GitHub
lib/ProMotion/table/cell/table_view_cell_module.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method set_remote_image has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

    def set_remote_image
      return unless data_cell[:remote_image] && (sd_web_image? || jm_image_cache?)

      self.imageView.image = remote_placeholder

Severity: Minor
Found in lib/ProMotion/table/cell/table_view_cell_module.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method set_remote_image has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def set_remote_image
      return unless data_cell[:remote_image] && (sd_web_image? || jm_image_cache?)

      self.imageView.image = remote_placeholder

Severity: Minor
Found in lib/ProMotion/table/cell/table_view_cell_module.rb - About 1 hr to fix

    Method set_image has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def set_image
          return unless data_cell[:image]
          cell_image = data_cell[:image].is_a?(Hash) ? data_cell[:image][:image] : data_cell[:image]
          cell_image = UIImage.imageNamed(cell_image) if cell_image.is_a?(String)
          self.imageView.layer.masksToBounds = true
    Severity: Minor
    Found in lib/ProMotion/table/cell/table_view_cell_module.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method set_accessory_view has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def set_accessory_view
          return self.accessoryView = nil unless data_cell[:accessory] && data_cell[:accessory][:view]
          if data_cell[:accessory][:view] == :switch
            self.accessoryView = switch_view
          else
    Severity: Minor
    Found in lib/ProMotion/table/cell/table_view_cell_module.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method layoutSubviews has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def layoutSubviews
          super
          return unless data_cell
    
          # Support changing sizes of the image view
    Severity: Minor
    Found in lib/ProMotion/table/cell/table_view_cell_module.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status