Showing 6 of 6 total issues
ValueParserState
has 31 functions (exceeds 20 allowed). Consider refactoring. Open
class ValueParserState
{
public const STEP_START = 'STEP_START';
public const STEP_MIDDLE = 'STEP_MIDDLE';
public const STEP_END = 'STEP_END';
Function parseChar
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
public function parseChar(ValueParserState $state): void
{
$currentChar = $state->getCurrentChar();
// Steps order is important :
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
load accesses the super-global variable $_SERVER. Open
public function load(array $data): void
{
foreach ($data as $key => $value) {
if (!array_key_exists($key, $_ENV)) {
$this->writeInEnv($key, $value);
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
writeInServer accesses the super-global variable $_SERVER. Open
private function writeInServer(string $key, string $value): void
{
$_SERVER[$key] = $value;
}
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
writeInEnv accesses the super-global variable $_ENV. Open
private function writeInEnv(string $key, string $value): void
{
$_ENV[$key] = $value;
}
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
load accesses the super-global variable $_ENV. Open
public function load(array $data): void
{
foreach ($data as $key => $value) {
if (!array_key_exists($key, $_ENV)) {
$this->writeInEnv($key, $value);
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}