Sign upLogin

cloudamatic/mu

View on GitHub
Star
bin/mu-adopt

Summary

Maintainability
Test Coverage

Use tr instead of gsub.
Open

  t_name = t.gsub(/-/, "_")
Severity: Minor
Found in bin/mu-adopt by rubocop

This cop identifies places where gsub can be replaced by tr or delete.

Example:

# bad
'abc'.gsub('b', 'd')
'abc'.gsub('a', '')
'abc'.gsub(/a/, 'd')
'abc'.gsub!('a', 'd')

# good
'abc'.gsub(/.*/, 'a')
'abc'.gsub(/a+/, 'd')
'abc'.tr('b', 'd')
'a b c'.delete(' ')

Use =~ in places where the MatchData returned by #match will not be used.
Open

    if cloud.match(/^[^a-z0-9]*?#{Regexp.quote(known_cloud)}[^a-z0-9]*?$/i)
Severity: Minor
Found in bin/mu-adopt by rubocop

This cop identifies the use of Regexp#match or String#match, which returns #<MatchData>/nil. The return value of =~ is an integral index/nil and is more performant.

Example:

# bad
do_something if str.match(/regex/)
while regex.match('str')
  do_something
end

# good
method(str =~ /regex/)
return value unless regex =~ 'str'

Unused block argument - type. If it's necessary, use _ or _type as an argument name to indicate that it won't be used.
Open

  MU::Cloud.resource_types.each_pair { |type, cfg|
Severity: Minor
Found in bin/mu-adopt by rubocop

This cop checks for unused block arguments.

Example:

# bad

do_something do |used, unused|
  puts used
end

do_something do |bar|
  puts :foo
end

define_method(:foo) do |bar|
  puts :baz
end

Example:

#good

do_something do |used, _unused|
  puts used
end

do_something do
  puts :foo
end

define_method(:foo) do |_bar|
  puts :baz
end

Redundant use of Object#to_s in interpolation.
Open

  MU.log "--appname must match pattern #{app_pattern.to_s}", MU::ERR
Severity: Minor
Found in bin/mu-adopt by rubocop

This cop checks for string conversion in string interpolation, which is redundant.

Example:

# bad

"result is #{something.to_s}"

Example:

# good

"result is #{something}"

Use meaningful heredoc delimiters.
Open

  EOS
Severity: Minor
Found in bin/mu-adopt by rubocop

This cop checks that your heredocs are using meaningful delimiters. By default it disallows END and EO*, and can be configured through blacklisting additional delimiters.

Example:

# good
<<-SQL
  SELECT * FROM foo
SQL

# bad
<<-END
  SELECT * FROM foo
END

# bad
<<-EOS
  SELECT * FROM foo
EOS

Useless assignment to variable - name. Use _ or _name as a variable name to indicate that it won't be used.
Open

  shortclass, name, plural, classname = MU::Cloud.getResourceNames(t_name)
Severity: Minor
Found in bin/mu-adopt by rubocop

This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

assigned but unused variable - foo

Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

Example:

# bad

def some_method
  some_var = 1
  do_something
end

Example:

# good

def some_method
  some_var = 1
  do_something(some_var)
end

Useless assignment to variable - grouping_options.
Open

grouping_options = {
Severity: Minor
Found in bin/mu-adopt by rubocop

This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

assigned but unused variable - foo

Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

Example:

# bad

def some_method
  some_var = 1
  do_something
end

Example:

# good

def some_method
  some_var = 1
  do_something(some_var)
end

Redundant use of Object#to_s in interpolation.
Open

      MU.log "#{bok[cfg[:cfg_plural]].size.to_s} #{cfg[:cfg_plural]}", MU::NOTICE
Severity: Minor
Found in bin/mu-adopt by rubocop

This cop checks for string conversion in string interpolation, which is redundant.

Example:

# bad

"result is #{something.to_s}"

Example:

# good

"result is #{something}"

Useless assignment to variable - plural. Use _ or _plural as a variable name to indicate that it won't be used.
Open

  shortclass, name, plural, classname = MU::Cloud.getResourceNames(t_name)
Severity: Minor
Found in bin/mu-adopt by rubocop

This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

assigned but unused variable - foo

Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

Example:

# bad

def some_method
  some_var = 1
  do_something
end

Example:

# good

def some_method
  some_var = 1
  do_something(some_var)
end

There are no issues that match your filters.

Category
Status