Sign upLogin

cloudamatic/mu

View on GitHub
Star
bin/mu-load-config.rb

Summary

Maintainability
A
0 mins
Test Coverage

Assignment Branch Condition size for loadMuConfig is too high. [91.53/75]
Open

def loadMuConfig(default_cfg_overrides = nil)

  # Start with sane defaults
  default_cfg = {
    "installdir" => "/opt/mu",
Severity: Minor
Found in bin/mu-load-config.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Assignment Branch Condition size for loadMuConfig is too high. [91.53/75]
Open

def loadMuConfig(default_cfg_overrides = nil)

  # Start with sane defaults
  default_cfg = {
    "installdir" => "/opt/mu",
Severity: Minor
Found in bin/mu-load-config.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Use each_value instead of values.each.
Open

        cfg[cloud].values.each { |acct|
Severity: Minor
Found in bin/mu-load-config.rb by rubocop

This cop checks for uses of each_key and each_value Hash methods.

Note: If you have an array of two-element arrays, you can put parentheses around the block arguments to indicate that you're not working with a hash, and suppress RuboCop offenses.

Example:

# bad
hash.keys.each { |k| p k }
hash.values.each { |v| p v }
hash.each { |k, _v| p k }
hash.each { |_k, v| p v }

# good
hash.each_key { |k| p k }
hash.each_value { |v| p v }

Use each_value instead of values.each.
Open

        cfg[cloud].values.each { |acct|
Severity: Minor
Found in bin/mu-load-config.rb by rubocop

This cop checks for uses of each_key and each_value Hash methods.

Note: If you have an array of two-element arrays, you can put parentheses around the block arguments to indicate that you're not working with a hash, and suppress RuboCop offenses.

Example:

# bad
hash.keys.each { |k| p k }
hash.values.each { |v| p v }
hash.each { |k, _v| p k }
hash.each { |_k, v| p v }

# good
hash.each_key { |k| p k }
hash.each_value { |v| p v }

Prefer using YAML.safe_load over YAML.load.
Open

    localfile = YAML.load(File.read("#{home}/.mu.yaml"))
Severity: Minor
Found in bin/mu-load-config.rb by rubocop

This cop checks for the use of YAML class methods which have potential security issues leading to remote code execution when loading from an untrusted source.

Example:

# bad
YAML.load("--- foo")

# good
YAML.safe_load("--- foo")
YAML.dump("foo")

Prefer using YAML.safe_load over YAML.load.
Open

      default_cfg.merge!(YAML.load(File.read("/opt/mu/etc/mu.yaml")))
Severity: Minor
Found in bin/mu-load-config.rb by rubocop

This cop checks for the use of YAML class methods which have potential security issues leading to remote code execution when loading from an untrusted source.

Example:

# bad
YAML.load("--- foo")

# good
YAML.safe_load("--- foo")
YAML.dump("foo")

Prefer using YAML.safe_load over YAML.load.
Open

    global_cfg = YAML.load(File.read(cfgPath))
Severity: Minor
Found in bin/mu-load-config.rb by rubocop

This cop checks for the use of YAML class methods which have potential security issues leading to remote code execution when loading from an untrusted source.

Example:

# bad
YAML.load("--- foo")

# good
YAML.safe_load("--- foo")
YAML.dump("foo")

Prefer using YAML.safe_load over YAML.load.
Open

    global_cfg = YAML.load(File.read(cfgPath))
Severity: Minor
Found in bin/mu-load-config.rb by rubocop

This cop checks for the use of YAML class methods which have potential security issues leading to remote code execution when loading from an untrusted source.

Example:

# bad
YAML.load("--- foo")

# good
YAML.safe_load("--- foo")
YAML.dump("foo")

Prefer using YAML.safe_load over YAML.load.
Open

    localfile = YAML.load(File.read("#{home}/.mu.yaml"))
Severity: Minor
Found in bin/mu-load-config.rb by rubocop

This cop checks for the use of YAML class methods which have potential security issues leading to remote code execution when loading from an untrusted source.

Example:

# bad
YAML.load("--- foo")

# good
YAML.safe_load("--- foo")
YAML.dump("foo")

Prefer using YAML.safe_load over YAML.load.
Open

      default_cfg.merge!(YAML.load(File.read("/opt/mu/etc/mu.yaml")))
Severity: Minor
Found in bin/mu-load-config.rb by rubocop

This cop checks for the use of YAML class methods which have potential security issues leading to remote code execution when loading from an untrusted source.

Example:

# bad
YAML.load("--- foo")

# good
YAML.safe_load("--- foo")
YAML.dump("foo")

There are no issues that match your filters.

Category
Status