Sign upLogin

cloudamatic/mu

View on GitHub
Star
cookbooks/mu-tools/recipes/rsyslog.rb

Summary

Maintainability
A
45 mins
Test Coverage

Avoid deeply nested control flow statements.
Open

        semanage_pkg = if node['platform_version'].to_i < 6
          "policycoreutils"
        elsif node['platform_version'].to_i < 8
          "policycoreutils-python"
        else
Severity: Major
Found in cookbooks/mu-tools/recipes/rsyslog.rb - About 45 mins to fix

    Avoid more than 4 levels of block nesting.
    Open

            semanage_pkg = if node['platform_version'].to_i < 6
          "policycoreutils"
        elsif node['platform_version'].to_i < 8
          "policycoreutils-python"
        else
    Severity: Minor
    Found in cookbooks/mu-tools/recipes/rsyslog.rb by rubocop

    This cop checks for excessive nesting of conditional and looping constructs.

    You can configure if blocks are considered using the CountBlocks option. When set to false (the default) blocks are not counted towards the nesting level. Set to true to count blocks as well.

    The maximum level of nesting allowed is configurable.

    end at 42, 8 is not aligned with if at 36, 23.
    Open

            end
    Severity: Minor
    Found in cookbooks/mu-tools/recipes/rsyslog.rb by rubocop

    This cop checks whether the end keywords are aligned properly.

    Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

    If it's set to keyword (which is the default), the end shall be aligned with the start of the keyword (if, class, etc.).

    If it's set to variable the end shall be aligned with the left-hand-side of the variable assignment, if there is one.

    If it's set to start_of_line, the end shall be aligned with the start of the line where the matching keyword appears.

    Example: EnforcedStyleAlignWith: keyword (default)

    # bad

variable = if true
    end

# good

variable = if true
           end

    Example: EnforcedStyleAlignWith: variable

    # bad

variable = if true
    end

# good

variable = if true
end

    Example: EnforcedStyleAlignWith: startofline

    # bad

variable = if true
    end

# good

puts(if true
end)

    There are no issues that match your filters.

    Category
    Status