Sign upLogin

cloudamatic/mu

View on GitHub
Star

Showing 2,704 of 2,705 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      def self.getUser(user)
        begin
          Timeout::timeout(45) {
            response = chefAPI.get("users/#{user}")
            return response
Severity: Minor
Found in modules/mu/master/chef.rb and 1 other location - About 40 mins to fix
modules/mu/master/chef.rb on lines 177..187

Similar blocks of code found in 2 locations. Consider refactoring.
Open

              if (!defined? rule['hosts'] or !rule['hosts'].is_a?(Array)) and
                  (!defined? rule['sgs'] or !rule['sgs'].is_a?(Array)) and
                  (!defined? rule['lbs'] or !rule['lbs'].is_a?(Array))
                raise MuError, "One of 'hosts', 'sgs', or 'lbs' in rules provided to createEc2SG must be an array."
              end
Severity: Minor
Found in modules/mu/providers/cloudformation/firewall_rule.rb and 1 other location - About 40 mins to fix
modules/mu/providers/aws/firewall_rule.rb on lines 882..886

Identical blocks of code found in 2 locations. Consider refactoring.
Open

          if use_cache
            begin
              win_admin_password = @groomer.getSecret(
                vault: @config['windows_auth_vault']['vault'],
                item: @config['windows_auth_vault']['item'],
Severity: Minor
Found in modules/mu/providers/aws/server.rb and 1 other location - About 40 mins to fix
modules/mu/providers/google/server.rb on lines 1028..1037

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      def self.getOrg(org)
        begin
          Timeout::timeout(45) {
            response = chefAPI.get("organizations/#{org}")
            return response
Severity: Minor
Found in modules/mu/master/chef.rb and 1 other location - About 40 mins to fix
modules/mu/master/chef.rb on lines 32..42

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if !args.nil? and args.size == 1
              retval = @cloudobj.method(method).call(args.first)
            elsif !args.nil? and args.size > 0
              retval = @cloudobj.method(method).call(*args)
            else
Severity: Minor
Found in modules/mu/cloud/resource_base.rb and 1 other location - About 40 mins to fix
modules/mu/groomer.rb on lines 132..138

Similar blocks of code found in 2 locations. Consider refactoring.
Open

          MU.log "#{mu_name} is already being groomed, skipping", MU::NOTICE
          MU::MommaCat.unlockAll
          if !MU::MommaCat.locks.nil? and MU::MommaCat.locks.size > 0
            puts "------------------------------"
            puts "Open flock() locks:"
Severity: Minor
Found in modules/mu/mommacat/daemon.rb and 1 other location - About 40 mins to fix
modules/mu/mommacat/daemon.rb on lines 130..139

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      on_unique.each { |e|
        namestr, loc = MU::MommaCat.getChunkName(e)
 
        report ||= {}
        report[namestr] = { :action => :removed, :parents => parents, :value => e.clone }
Severity: Minor
Found in modules/mu.rb and 1 other location - About 40 mins to fix
modules/mu.rb on lines 164..169

Identical blocks of code found in 2 locations. Consider refactoring.
Open

              if rule['proto'] != "icmp"
                if p_start.nil? or p_end.nil?
                  raise MuError, "Got nil ports out of rule #{rule}"
                end
                ec2_rule[:from_port] = p_start.to_i
Severity: Minor
Found in modules/mu/providers/cloudformation/firewall_rule.rb and 1 other location - About 40 mins to fix
modules/mu/providers/aws/firewall_rule.rb on lines 871..880

Identical blocks of code found in 2 locations. Consider refactoring.
Open

              if rule['proto'] != "icmp"
                if p_start.nil? or p_end.nil?
                  raise MuError, "Got nil ports out of rule #{rule}"
                end
                ec2_rule[:from_port] = p_start.to_i
Severity: Minor
Found in modules/mu/providers/aws/firewall_rule.rb and 1 other location - About 40 mins to fix
modules/mu/providers/cloudformation/firewall_rule.rb on lines 209..218

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      with_unique.each { |e|
        namestr, loc = MU::MommaCat.getChunkName(e)
 
        report ||= {}
        report[namestr] = { :action => :added, :parents => parents, :value => e.clone }
Severity: Minor
Found in modules/mu.rb and 1 other location - About 40 mins to fix
modules/mu.rb on lines 155..160

Similar blocks of code found in 2 locations. Consider refactoring.
Open

          if !args.nil? and args.size == 1
            retval = @groomer_obj.method(method).call(args.first)
          elsif !args.nil? and args.size > 0
            retval = @groomer_obj.method(method).call(*args)
          else
Severity: Minor
Found in modules/mu/groomer.rb and 1 other location - About 40 mins to fix
modules/mu/cloud/resource_base.rb on lines 880..886

Similar blocks of code found in 2 locations. Consider refactoring.
Open

          MU.log "#{mu_name} is still in mid-creation, skipping", MU::NOTICE
          MU::MommaCat.unlockAll
          if !MU::MommaCat.locks.nil? and MU::MommaCat.locks.size > 0
            puts "------------------------------"
            puts "Open flock() locks:"
Severity: Minor
Found in modules/mu/mommacat/daemon.rb and 1 other location - About 40 mins to fix
modules/mu/mommacat/daemon.rb on lines 143..152

Method generate_dummy_object has 11 arguments (exceeds 10 allowed). Consider refactoring.
Open

    def self.generate_dummy_object(type, cloud, name, mu_name, cloud_id, desc, region, habitat, tag_value, calling_deploy, credentials)
Severity: Major
Found in modules/mu/mommacat/search.rb - About 35 mins to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                if retries < 10 and retries > 2
                  debuglevel = MU::NOTICE
                  interval = 20 + Random.rand(10) - 3
                # elsif retries >= 10 and retries <= 100
                elsif retries >= 10
    Severity: Minor
    Found in modules/mu/providers/aws.rb and 1 other location - About 35 mins to fix
    modules/mu/providers/google.rb on lines 1551..1560

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      class Config
        # Basket of Kittens config schema and parser logic. See modules/mu/providers/*/msg_queue.rb
        class MsgQueue
     
          # Base configuration schema for a MsgQueue
    Severity: Minor
    Found in modules/mu/config/msg_queue.rb and 1 other location - About 35 mins to fix
    modules/mu/config/log.rb on lines 16..44

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

              if MU::Cloud.resourceClass("Azure", "VPC").haveRouteToInstance?(cloud_desc, credentials: @config['credentials']) or public_ips.size == 0
                @config['canonical_ip'] = private_ips.first
                return private_ips.first
              else
                @config['canonical_ip'] = public_ips.first
    Severity: Minor
    Found in modules/mu/providers/azure/server.rb and 1 other location - About 35 mins to fix
    modules/mu/providers/google/server.rb on lines 995..1001

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                elsif !name.nil? and !subnet.name.nil? and subnet.name.to_s == name.to_s
                  return subnet
                elsif !ip_block.nil? and !subnet.ip_block.nil? and subnet.ip_block.to_s == ip_block.to_s
                  return subnet
                end
    Severity: Minor
    Found in modules/mu/providers/aws/vpc.rb and 1 other location - About 35 mins to fix
    modules/mu/providers/azure/vpc.rb on lines 275..279

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                if !cloud_id.nil? and !subnet.cloud_id.nil? and subnet.cloud_id.to_s == cloud_id.to_s
                  return subnet
                elsif !name.nil? and !subnet.name.nil? and subnet.name.to_s == name.to_s
                  return subnet
                end
    Severity: Minor
    Found in modules/mu/providers/azure/vpc.rb and 1 other location - About 35 mins to fix
    modules/mu/providers/aws/vpc.rb on lines 633..637

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

              if folder['parent'] and folder['parent']['name'] and !folder['parent']['deploy_id'] and configurator.haveLitterMate?(folder['parent']['name'], "folders")
                MU::Config.addDependency(folder, folder['parent']['name'], "folder")
              end
    Severity: Minor
    Found in modules/mu/providers/google/folder.rb and 1 other location - About 35 mins to fix
    modules/mu/providers/google/habitat.rb on lines 378..380

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      class Config
        # Basket of Kittens config schema and parser logic. See modules/mu/providers/*/log.rb
        class Log
     
          # Base configuration schema for a Log
    Severity: Minor
    Found in modules/mu/config/log.rb and 1 other location - About 35 mins to fix
    modules/mu/config/msg_queue.rb on lines 16..42
    Severity
    Category
    Status
    Source
    Language