cloudamatic/mu

View on GitHub
modules/mu/adoption.rb

Summary

Maintainability
F
3 days
Test Coverage

Assignment Branch Condition size for generateBaskets is too high. [221/75]
Open

    def generateBaskets(prefix: "")
      groupings = {
        "" =>  MU::Cloud.resource_types.values.map { |v| v[:cfg_plural] }
      }

Severity: Minor
Found in modules/mu/adoption.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Assignment Branch Condition size for crawlChangeReport is too high. [168.9/75]
Open

    def crawlChangeReport(tier, parent_key = nil, indent: "")
      report = []
      if tier.is_a?(Array)
        tier.each { |a|
          sub_report = crawlChangeReport(a, parent_key)
Severity: Minor
Found in modules/mu/adoption.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Assignment Branch Condition size for resolveReferences is too high. [140.3/75]
Open

    def resolveReferences(cfg, deploy, parent)
      mask_deploy_id = false

      check_deploy_id = Proc.new { |cfgblob|
        (deploy and
Severity: Minor
Found in modules/mu/adoption.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method generateBaskets has a Cognitive Complexity of 124 (exceeds 75 allowed). Consider refactoring.
Open

    def generateBaskets(prefix: "")
      groupings = {
        "" =>  MU::Cloud.resource_types.values.map { |v| v[:cfg_plural] }
      }

Severity: Minor
Found in modules/mu/adoption.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method crawlChangeReport has a Cognitive Complexity of 118 (exceeds 75 allowed). Consider refactoring.
Open

    def crawlChangeReport(tier, parent_key = nil, indent: "")
      report = []
      if tier.is_a?(Array)
        tier.each { |a|
          sub_report = crawlChangeReport(a, parent_key)
Severity: Minor
Found in modules/mu/adoption.rb - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Perceived complexity for resolveReferences is too high. [59/35]
Open

    def resolveReferences(cfg, deploy, parent)
      mask_deploy_id = false

      check_deploy_id = Proc.new { |cfgblob|
        (deploy and
Severity: Minor
Found in modules/mu/adoption.rb by rubocop

This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

Example:

def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

Cyclomatic complexity for resolveReferences is too high. [51/30]
Open

    def resolveReferences(cfg, deploy, parent)
      mask_deploy_id = false

      check_deploy_id = Proc.new { |cfgblob|
        (deploy and
Severity: Minor
Found in modules/mu/adoption.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Perceived complexity for crawlChangeReport is too high. [55/35]
Open

    def crawlChangeReport(tier, parent_key = nil, indent: "")
      report = []
      if tier.is_a?(Array)
        tier.each { |a|
          sub_report = crawlChangeReport(a, parent_key)
Severity: Minor
Found in modules/mu/adoption.rb by rubocop

This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

Example:

def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

Assignment Branch Condition size for vacuum is too high. [94.2/75]
Open

    def vacuum(bok, origin: nil, save: false, deploy: nil, copy_from: nil, keep_missing: false)

      globals = {
        'cloud' => {},
        'credentials' => {},
Severity: Minor
Found in modules/mu/adoption.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Cyclomatic complexity for crawlChangeReport is too high. [48/30]
Open

    def crawlChangeReport(tier, parent_key = nil, indent: "")
      report = []
      if tier.is_a?(Array)
        tier.each { |a|
          sub_report = crawlChangeReport(a, parent_key)
Severity: Minor
Found in modules/mu/adoption.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Block has too many lines. [135/100]
Open

      groupings.each_pair { |appname, types|
        allowed_types = @types.map { |t| MU::Cloud.resource_types[t][:cfg_plural] }
        next if (types & allowed_types).size == 0

        bok = { "appname" => prefix+appname }
Severity: Minor
Found in modules/mu/adoption.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Cyclomatic complexity for generateBaskets is too high. [38/30]
Open

    def generateBaskets(prefix: "")
      groupings = {
        "" =>  MU::Cloud.resource_types.values.map { |v| v[:cfg_plural] }
      }

Severity: Minor
Found in modules/mu/adoption.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Perceived complexity for generateBaskets is too high. [42/35]
Open

    def generateBaskets(prefix: "")
      groupings = {
        "" =>  MU::Cloud.resource_types.values.map { |v| v[:cfg_plural] }
      }

Severity: Minor
Found in modules/mu/adoption.rb by rubocop

This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

Example:

def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

Assignment Branch Condition size for generateStubDeploy is too high. [78.75/75]
Open

    def generateStubDeploy(bok)
#      hashify Ref objects before passing into here... or do we...?

      time = Time.new
      timestamp = time.strftime("%Y%m%d%H").to_s;
Severity: Minor
Found in modules/mu/adoption.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method generateBaskets has 174 lines of code (exceeds 150 allowed). Consider refactoring.
Open

    def generateBaskets(prefix: "")
      groupings = {
        "" =>  MU::Cloud.resource_types.values.map { |v| v[:cfg_plural] }
      }

Severity: Major
Found in modules/mu/adoption.rb - About 1 hr to fix

    Method resolveReferences has a Cognitive Complexity of 83 (exceeds 75 allowed). Consider refactoring.
    Open

        def resolveReferences(cfg, deploy, parent)
          mask_deploy_id = false
    
          check_deploy_id = Proc.new { |cfgblob|
            (deploy and
    Severity: Minor
    Found in modules/mu/adoption.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                hashcfg.delete("id") if hashcfg["name"]
    Severity: Major
    Found in modules/mu/adoption.rb - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                  if tier[:value].is_a?(Hash)
                    if name
                      tier[:value].delete("entity")
                      tier[:value].delete(name.sub(/\[.*/, '')) if name
                    end
      Severity: Major
      Found in modules/mu/adoption.rb - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                    path.pop if path.last == name
        Severity: Major
        Found in modules/mu/adoption.rb - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                    plain = (name ? name : type_of) if name or type_of
          Severity: Major
          Found in modules/mu/adoption.rb - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                      elsif cfg.id
                        littermate = deploy.findLitterMate(type: cfg.type, cloud_id: cfg.id, habitat: cfg.habitat)
                        if littermate and littermate.config['name']
                          hashcfg['name'] = littermate.config['name']
                          hashcfg.delete("id") if hashcfg["name"]
            Severity: Major
            Found in modules/mu/adoption.rb - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                          if ![:removed].include?(tier[:action])
                            myreport["slack"] += ". New #{tier[:field] ? "`"+tier[:field]+"`" : :value}: \*#{tier[:value]}\*"
                          else
                            myreport["slack"] += " (was \*#{tier[:value]}\*)"
                          end
              Severity: Major
              Found in modules/mu/adoption.rb - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                            for c in (0..(path.size-1)) do
                              path_str << ("  " * (c+2)) + (path[c] || "<nil>")
                            end
                Severity: Major
                Found in modules/mu/adoption.rb - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                              slack_path_str += "#{preposition} \*"+path.join(" ⇨ ")+"\*" if path.size > 0
                  Severity: Major
                  Found in modules/mu/adoption.rb - About 45 mins to fix

                    Avoid more than 4 levels of block nesting.
                    Open

                                  if (tier[:value].keys - ["id", "name", "type"]).size > 0
                                    myreport["details"] = tier[:value].clone
                                    append = PP.pp(tier[:value], '').gsub(/(^|\n)/, '\1'+indent)
                                  end
                    Severity: Minor
                    Found in modules/mu/adoption.rb by rubocop

                    This cop checks for excessive nesting of conditional and looping constructs.

                    You can configure if blocks are considered using the CountBlocks option. When set to false (the default) blocks are not counted towards the nesting level. Set to true to count blocks as well.

                    The maximum level of nesting allowed is configurable.

                    Avoid more than 4 levels of block nesting.
                    Open

                                  myreport["slack"] += ". New #{tier[:field] ? "`"+tier[:field]+"`" : :value}: \*#{tier[:value]}\*"
                    Severity: Minor
                    Found in modules/mu/adoption.rb by rubocop

                    This cop checks for excessive nesting of conditional and looping constructs.

                    You can configure if blocks are considered using the CountBlocks option. When set to false (the default) blocks are not counted towards the nesting level. Set to true to count blocks as well.

                    The maximum level of nesting allowed is configurable.

                    Avoid more than 4 levels of block nesting.
                    Open

                                  hashcfg.delete("id") if hashcfg["name"]
                    Severity: Minor
                    Found in modules/mu/adoption.rb by rubocop

                    This cop checks for excessive nesting of conditional and looping constructs.

                    You can configure if blocks are considered using the CountBlocks option. When set to false (the default) blocks are not counted towards the nesting level. Set to true to count blocks as well.

                    The maximum level of nesting allowed is configurable.

                    Avoid more than 4 levels of block nesting.
                    Open

                                  hashcfg.delete("name") if cfg.id and !cfg.deploy_id
                    Severity: Minor
                    Found in modules/mu/adoption.rb by rubocop

                    This cop checks for excessive nesting of conditional and looping constructs.

                    You can configure if blocks are considered using the CountBlocks option. When set to false (the default) blocks are not counted towards the nesting level. Set to true to count blocks as well.

                    The maximum level of nesting allowed is configurable.

                    Avoid more than 4 levels of block nesting.
                    Open

                                  if name
                                    tier[:value].delete("entity")
                                    tier[:value].delete(name.sub(/\[.*/, '')) if name
                                  end
                    Severity: Minor
                    Found in modules/mu/adoption.rb by rubocop

                    This cop checks for excessive nesting of conditional and looping constructs.

                    You can configure if blocks are considered using the CountBlocks option. When set to false (the default) blocks are not counted towards the nesting level. Set to true to count blocks as well.

                    The maximum level of nesting allowed is configurable.

                    Use each_value instead of values.each.
                    Open

                                resources.values.each { |obj_thr|
                    Severity: Minor
                    Found in modules/mu/adoption.rb by rubocop

                    This cop checks for uses of each_key and each_value Hash methods.

                    Note: If you have an array of two-element arrays, you can put parentheses around the block arguments to indicate that you're not working with a hash, and suppress RuboCop offenses.

                    Example:

                    # bad
                    hash.keys.each { |k| p k }
                    hash.values.each { |v| p v }
                    hash.each { |k, _v| p k }
                    hash.each { |_k, v| p v }
                    
                    # good
                    hash.each_key { |k| p k }
                    hash.each_value { |v| p v }

                    Use each_value instead of values.each.
                    Open

                          MU::Cloud.resource_types.values.each { |attrs|
                    Severity: Minor
                    Found in modules/mu/adoption.rb by rubocop

                    This cop checks for uses of each_key and each_value Hash methods.

                    Note: If you have an array of two-element arrays, you can put parentheses around the block arguments to indicate that you're not working with a hash, and suppress RuboCop offenses.

                    Example:

                    # bad
                    hash.keys.each { |k| p k }
                    hash.values.each { |v| p v }
                    hash.each { |k, _v| p k }
                    hash.each { |_k, v| p v }
                    
                    # good
                    hash.each_key { |k| p k }
                    hash.each_value { |v| p v }

                    Use each_value instead of values.each.
                    Open

                            MU::Cloud.resource_types.values.each { |attrs|
                    Severity: Minor
                    Found in modules/mu/adoption.rb by rubocop

                    This cop checks for uses of each_key and each_value Hash methods.

                    Note: If you have an array of two-element arrays, you can put parentheses around the block arguments to indicate that you're not working with a hash, and suppress RuboCop offenses.

                    Example:

                    # bad
                    hash.keys.each { |k| p k }
                    hash.values.each { |v| p v }
                    hash.each { |k, _v| p k }
                    hash.each { |_k, v| p v }
                    
                    # good
                    hash.each_key { |k| p k }
                    hash.each_value { |v| p v }

                    Redundant use of Object#to_s in interpolation.
                    Open

                                  MU.log "Found #{found.size.to_s} raw #{resclass.cfg_plural} in #{cloud}"
                    Severity: Minor
                    Found in modules/mu/adoption.rb by rubocop

                    This cop checks for string conversion in string interpolation, which is redundant.

                    Example:

                    # bad
                    
                    "result is #{something.to_s}"

                    Example:

                    # good
                    
                    "result is #{something}"

                    end at 621, 10 is not aligned with if at 612, 23.
                    Open

                              end
                    Severity: Minor
                    Found in modules/mu/adoption.rb by rubocop

                    This cop checks whether the end keywords are aligned properly.

                    Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

                    If it's set to keyword (which is the default), the end shall be aligned with the start of the keyword (if, class, etc.).

                    If it's set to variable the end shall be aligned with the left-hand-side of the variable assignment, if there is one.

                    If it's set to start_of_line, the end shall be aligned with the start of the line where the matching keyword appears.

                    Example: EnforcedStyleAlignWith: keyword (default)

                    # bad
                    
                    variable = if true
                        end
                    
                    # good
                    
                    variable = if true
                               end

                    Example: EnforcedStyleAlignWith: variable

                    # bad
                    
                    variable = if true
                        end
                    
                    # good
                    
                    variable = if true
                    end

                    Example: EnforcedStyleAlignWith: startofline

                    # bad
                    
                    variable = if true
                        end
                    
                    # good
                    
                    puts(if true
                    end)

                    end at 547, 10 is not aligned with if at 543, 17.
                    Open

                              end
                    Severity: Minor
                    Found in modules/mu/adoption.rb by rubocop

                    This cop checks whether the end keywords are aligned properly.

                    Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

                    If it's set to keyword (which is the default), the end shall be aligned with the start of the keyword (if, class, etc.).

                    If it's set to variable the end shall be aligned with the left-hand-side of the variable assignment, if there is one.

                    If it's set to start_of_line, the end shall be aligned with the start of the line where the matching keyword appears.

                    Example: EnforcedStyleAlignWith: keyword (default)

                    # bad
                    
                    variable = if true
                        end
                    
                    # good
                    
                    variable = if true
                               end

                    Example: EnforcedStyleAlignWith: variable

                    # bad
                    
                    variable = if true
                        end
                    
                    # good
                    
                    variable = if true
                    end

                    Example: EnforcedStyleAlignWith: startofline

                    # bad
                    
                    variable = if true
                        end
                    
                    # good
                    
                    puts(if true
                    end)

                    Useless assignment to variable - slack.
                    Open

                                  slack += " #{tier[:action].to_s}: "+tier[:value].map { |v| MU::MommaCat.getChunkName(v, type_of).reverse.join("/") || v.to_s }.join(", ")
                    Severity: Minor
                    Found in modules/mu/adoption.rb by rubocop

                    This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

                    assigned but unused variable - foo

                    Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

                    Example:

                    # bad
                    
                    def some_method
                      some_var = 1
                      do_something
                    end

                    Example:

                    # good
                    
                    def some_method
                      some_var = 1
                      do_something(some_var)
                    end

                    end at 423, 10 is not aligned with if at 417, 24.
                    Open

                              end
                    Severity: Minor
                    Found in modules/mu/adoption.rb by rubocop

                    This cop checks whether the end keywords are aligned properly.

                    Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

                    If it's set to keyword (which is the default), the end shall be aligned with the start of the keyword (if, class, etc.).

                    If it's set to variable the end shall be aligned with the left-hand-side of the variable assignment, if there is one.

                    If it's set to start_of_line, the end shall be aligned with the start of the line where the matching keyword appears.

                    Example: EnforcedStyleAlignWith: keyword (default)

                    # bad
                    
                    variable = if true
                        end
                    
                    # good
                    
                    variable = if true
                               end

                    Example: EnforcedStyleAlignWith: variable

                    # bad
                    
                    variable = if true
                        end
                    
                    # good
                    
                    variable = if true
                    end

                    Example: EnforcedStyleAlignWith: startofline

                    # bad
                    
                    variable = if true
                        end
                    
                    # good
                    
                    puts(if true
                    end)

                    Do not suppress exceptions.
                    Open

                                  rescue StandardError
                    Severity: Minor
                    Found in modules/mu/adoption.rb by rubocop

                    This cop checks for rescue blocks with no body.

                    Example:

                    # bad
                    
                    def some_method
                      do_something
                    rescue
                      # do nothing
                    end

                    Example:

                    # bad
                    
                    begin
                      do_something
                    rescue
                      # do nothing
                    end

                    Example:

                    # good
                    
                    def some_method
                      do_something
                    rescue
                      handle_exception
                    end

                    Example:

                    # good
                    
                    begin
                      do_something
                    rescue
                      handle_exception
                    end

                    Use normalcase for variable numbers.
                    Open

                              top_5 =  resources.keys.sort { |a, b|
                    Severity: Minor
                    Found in modules/mu/adoption.rb by rubocop

                    This cop makes sure that all numbered variables use the configured style, snakecase, normalcase or noninteger, for their numbering.

                    Example: EnforcedStyle: snake_case

                    # bad
                    
                    variable1 = 1
                    
                    # good
                    
                    variable_1 = 1

                    Example: EnforcedStyle: normalcase (default)

                    # bad
                    
                    variable_1 = 1
                    
                    # good
                    
                    variable1 = 1

                    Example: EnforcedStyle: non_integer

                    # bad
                    
                    variable1 = 1
                    
                    variable_1 = 1
                    
                    # good
                    
                    variableone = 1
                    
                    variable_one = 1

                    (...) interpreted as grouped expression.
                    Open

                                puts (symbol+" "+res_type+"["+name+"]")
                    Severity: Minor
                    Found in modules/mu/adoption.rb by rubocop

                    Checks for space between the name of a called method and a left parenthesis.

                    Example:

                    # bad
                    
                    puts (x + y)

                    Example:

                    # good
                    
                    puts(x + y)

                    Redundant use of Object#to_s in interpolation.
                    Open

                                MU.log "Kittened #{resources.size.to_s} eligible #{type}s in #{sprintf("%.2fs", walltimers[type])} (CPU time #{sprintf("%.2fs", total)}, avg #{sprintf("%.2fs", total/resources.size)}). Top 5:", MU::NOTICE, details: top_5
                    Severity: Minor
                    Found in modules/mu/adoption.rb by rubocop

                    This cop checks for string conversion in string interpolation, which is redundant.

                    Example:

                    # bad
                    
                    "result is #{something.to_s}"

                    Example:

                    # good
                    
                    "result is #{something}"

                    Redundant use of Object#to_s in interpolation.
                    Open

                                MU.log "Kittened #{resources.size.to_s} eligible #{type}s in #{sprintf("%.2fs", walltimers[type])}"
                    Severity: Minor
                    Found in modules/mu/adoption.rb by rubocop

                    This cop checks for string conversion in string interpolation, which is redundant.

                    Example:

                    # bad
                    
                    "result is #{something.to_s}"

                    Example:

                    # good
                    
                    "result is #{something}"

                    Useless assignment to variable - snippet_threshold.
                    Open

                          snippet_threshold = (MU.muCfg['adopt_change_notify'] && MU.muCfg['adopt_change_notify']['slack_snippet_threshold']) || 5
                    Severity: Minor
                    Found in modules/mu/adoption.rb by rubocop

                    This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

                    assigned but unused variable - foo

                    Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

                    Example:

                    # bad
                    
                    def some_method
                      some_var = 1
                      do_something
                    end

                    Example:

                    # good
                    
                    def some_method
                      some_var = 1
                      do_something(some_var)
                    end

                    Redundant use of Object#to_s in interpolation.
                    Open

                                  slack += " #{tier[:action].to_s}: "+tier[:value].map { |v| MU::MommaCat.getChunkName(v, type_of).reverse.join("/") || v.to_s }.join(", ")
                    Severity: Minor
                    Found in modules/mu/adoption.rb by rubocop

                    This cop checks for string conversion in string interpolation, which is redundant.

                    Example:

                    # bad
                    
                    "result is #{something.to_s}"

                    Example:

                    # good
                    
                    "result is #{something}"

                    end at 815, 10 is not aligned with if at 807, 23.
                    Open

                              end
                    Severity: Minor
                    Found in modules/mu/adoption.rb by rubocop

                    This cop checks whether the end keywords are aligned properly.

                    Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

                    If it's set to keyword (which is the default), the end shall be aligned with the start of the keyword (if, class, etc.).

                    If it's set to variable the end shall be aligned with the left-hand-side of the variable assignment, if there is one.

                    If it's set to start_of_line, the end shall be aligned with the start of the line where the matching keyword appears.

                    Example: EnforcedStyleAlignWith: keyword (default)

                    # bad
                    
                    variable = if true
                        end
                    
                    # good
                    
                    variable = if true
                               end

                    Example: EnforcedStyleAlignWith: variable

                    # bad
                    
                    variable = if true
                        end
                    
                    # good
                    
                    variable = if true
                    end

                    Example: EnforcedStyleAlignWith: startofline

                    # bad
                    
                    variable = if true
                        end
                    
                    # good
                    
                    puts(if true
                    end)

                    Useless assignment to variable - details.
                    Open

                                    details = JSON.pretty_generate(c["details"])
                    Severity: Minor
                    Found in modules/mu/adoption.rb by rubocop

                    This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

                    assigned but unused variable - foo

                    Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

                    Example:

                    # bad
                    
                    def some_method
                      some_var = 1
                      do_something
                    end

                    Example:

                    # good
                    
                    def some_method
                      some_var = 1
                      do_something(some_var)
                    end

                    Useless assignment to variable - mask_deploy_id.
                    Open

                          mask_deploy_id = false
                    Severity: Minor
                    Found in modules/mu/adoption.rb by rubocop

                    This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

                    assigned but unused variable - foo

                    Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

                    Example:

                    # bad
                    
                    def some_method
                      some_var = 1
                      do_something
                    end

                    Example:

                    # good
                    
                    def some_method
                      some_var = 1
                      do_something(some_var)
                    end

                    end at 538, 12 is not aligned with if at 532, 21.
                    Open

                                end
                    Severity: Minor
                    Found in modules/mu/adoption.rb by rubocop

                    This cop checks whether the end keywords are aligned properly.

                    Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

                    If it's set to keyword (which is the default), the end shall be aligned with the start of the keyword (if, class, etc.).

                    If it's set to variable the end shall be aligned with the left-hand-side of the variable assignment, if there is one.

                    If it's set to start_of_line, the end shall be aligned with the start of the line where the matching keyword appears.

                    Example: EnforcedStyleAlignWith: keyword (default)

                    # bad
                    
                    variable = if true
                        end
                    
                    # good
                    
                    variable = if true
                               end

                    Example: EnforcedStyleAlignWith: variable

                    # bad
                    
                    variable = if true
                        end
                    
                    # good
                    
                    variable = if true
                    end

                    Example: EnforcedStyleAlignWith: startofline

                    # bad
                    
                    variable = if true
                        end
                    
                    # good
                    
                    puts(if true
                    end)

                    private (on line 404) does not make singleton methods private. Use private_class_method or private inside a class << self block instead.
                    Open

                        def self.deDuplicateName(kitten_cfg, res_class)
                    Severity: Minor
                    Found in modules/mu/adoption.rb by rubocop

                    This cop checks for private or protected access modifiers which are applied to a singleton method. These access modifiers do not make singleton methods private/protected. private_class_method can be used for that.

                    Example:

                    # bad
                    
                    class C
                      private
                    
                      def self.method
                        puts 'hi'
                      end
                    end

                    Example:

                    # good
                    
                    class C
                      def self.method
                        puts 'hi'
                      end
                    
                      private_class_method :method
                    end

                    Example:

                    # good
                    
                    class C
                      class << self
                        private
                    
                        def method
                          puts 'hi'
                        end
                      end
                    end

                    Redundant use of Object#to_s in interpolation.
                    Open

                            MU.log "Minimizing footprint of #{count.to_s} found resources", MU::DEBUG
                    Severity: Minor
                    Found in modules/mu/adoption.rb by rubocop

                    This cop checks for string conversion in string interpolation, which is redundant.

                    Example:

                    # bad
                    
                    "result is #{something.to_s}"

                    Example:

                    # good
                    
                    "result is #{something}"

                    There are no issues that match your filters.

                    Category
                    Status