Sign upLogin

cloudamatic/mu

View on GitHub
Star
modules/mu/config/server.rb

Summary

Maintainability
C
1 day
Test Coverage

Method has too many lines. [354/200]
Open

      def self.common_properties
        {
          "name" => {"type" => "string"},
          "ansible_vars" => {
            "type" => "object",
Severity: Minor
Found in modules/mu/config/server.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method common_properties has 354 lines of code (exceeds 150 allowed). Consider refactoring.
Open

      def self.common_properties
        {
          "name" => {"type" => "string"},
          "ansible_vars" => {
            "type" => "object",
Severity: Major
Found in modules/mu/config/server.rb - About 1 day to fix

    Assignment Branch Condition size for validate is too high. [87.81/75]
    Open

          def self.validate(server, configurator)
        ok = true
        if configurator.haveLitterMate?(server["name"], "server_pools") 
          MU.log "Can't use name #{server['name']} more than once in servers/server_pools"
          ok = false
    Severity: Minor
    Found in modules/mu/config/server.rb by rubocop

    This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

    Assignment Branch Condition size for checkVaultRefs is too high. [75.1/75]
    Open

          def self.checkVaultRefs(server)
        ok = true
        server['vault_access'] = [] if server['vault_access'].nil?
        server['groomer'] ||= self.defaultGroomer
        groomclass = MU::Groomer.loadGroomer(server['groomer'])
    Severity: Minor
    Found in modules/mu/config/server.rb by rubocop

    This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                      "domain_admin_vault" => {
                      "type" => "object",
                      "additionalProperties" => false,
                      "description" => "Vault used to store the credentials for the domain admin user",
                      "properties" => {
    Severity: Minor
    Found in modules/mu/config/server.rb and 1 other location - About 45 mins to fix
    modules/mu/config/server.rb on lines 297..320

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 41.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                      "domain_join_vault" => {
                      "type" => "object",
                      "additionalProperties" => false,
                      "description" => "Vault used to store the credentials for the domain join user",
                      "properties" => {
    Severity: Minor
    Found in modules/mu/config/server.rb and 1 other location - About 45 mins to fix
    modules/mu/config/server.rb on lines 324..347

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 41.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                  {
                "key_is" => "platform",
                "value_is" => "centos",
                "set" => "centos"
              },
    Severity: Minor
    Found in modules/mu/config/server.rb and 1 other location - About 25 mins to fix
    modules/mu/providers/azure/server.rb on lines 485..503

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 29.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status