Sign upLogin

cloudamatic/mu

View on GitHub
Star
modules/mu/providers/aws/database.rb

Summary

Maintainability
D
2 days
Test Coverage

Class has too many lines. [1404/1000]
Open

      class Database < MU::Cloud::Database

        # Map legal storage values for each disk type and database engine so
        # our validator can check them for us.
        STORAGE_RANGES = {
Severity: Minor
Found in modules/mu/providers/aws/database.rb by rubocop

This cop checks if the length a class exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for toKitten is too high. [167.5/75]
Open

        def toKitten(**_args)
          bok = {
            "cloud" => "AWS",
            "region" => @region,
            "credentials" => @credentials,
Severity: Minor
Found in modules/mu/providers/aws/database.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

File database.rb has 1412 lines of code (exceeds 1000 allowed). Consider refactoring.
Open

autoload :Net, 'net/ssh/gateway'

module MU
  class Cloud
    class AWS
Severity: Major
Found in modules/mu/providers/aws/database.rb - About 1 day to fix

    Class Database has 45 methods (exceeds 20 allowed). Consider refactoring.
    Open

          class Database < MU::Cloud::Database

        # Map legal storage values for each disk type and database engine so
        # our validator can check them for us.
        STORAGE_RANGES = {
    Severity: Minor
    Found in modules/mu/providers/aws/database.rb - About 6 hrs to fix

      Assignment Branch Condition size for terminate_rds_instance is too high. [76.33/75]
      Open

              def self.terminate_rds_instance(db, noop: false, skipsnapshots: false, region: MU.curRegion, deploy_id: MU.deploy_id, mu_name: nil, cloud_id: nil, credentials: nil, cluster: false, known: [])
          db ||= MU::Cloud::AWS::Database.find(cloud_id: cloud_id, region: region, credentials: credentials, cluster: cluster).values.first if cloud_id
          db_obj ||= MU::MommaCat.findStray(
            "AWS",
            "database",
      Severity: Minor
      Found in modules/mu/providers/aws/database.rb by rubocop

      This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  threads.concat threaded_resource_purge("describe_db_#{type}s".to_sym, "db_#{type}s".to_sym, "db_#{type}_identifier".to_sym, (type == "instance" ? "db" : "cluster"), region, credentials, ignoremaster, known: flags['known'], deploy_id: deploy_id) { |id|
      Severity: Minor
      Found in modules/mu/providers/aws/database.rb and 1 other location - About 30 mins to fix
      modules/mu/providers/aws/database.rb on lines 821..821

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 32.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  threads.concat threaded_resource_purge("describe_#{type}_parameter_groups".to_sym, "#{type}_parameter_groups".to_sym, "#{type}_parameter_group_name".to_sym, (type == "db" ? "pg" : "cluster-pg"), region, credentials, ignoremaster, known: flags['known'], deploy_id: deploy_id) { |id|
      Severity: Minor
      Found in modules/mu/providers/aws/database.rb and 1 other location - About 30 mins to fix
      modules/mu/providers/aws/database.rb on lines 804..804

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 32.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                      paramhash[:scaling_configuration] = {
                  :auto_pause => @config['serverless_scaling']['auto_pause'],
                  :min_capacity => @config['serverless_scaling']['min_capacity'],
                  :max_capacity => @config['serverless_scaling']['max_capacity'],
                  :seconds_until_auto_pause => @config['serverless_scaling']['seconds_until_auto_pause']
      Severity: Minor
      Found in modules/mu/providers/aws/database.rb and 2 other locations - About 15 mins to fix
      modules/mu/providers/aws/cdn.rb on lines 57..61
      modules/mu/providers/aws/loadbalancer.rb on lines 449..454

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 25.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      end at 1429, 10 is not aligned with if at 1425, 20.
      Open

                end
      Severity: Minor
      Found in modules/mu/providers/aws/database.rb by rubocop

      This cop checks whether the end keywords are aligned properly.

      Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

      If it's set to keyword (which is the default), the end shall be aligned with the start of the keyword (if, class, etc.).

      If it's set to variable the end shall be aligned with the left-hand-side of the variable assignment, if there is one.

      If it's set to start_of_line, the end shall be aligned with the start of the line where the matching keyword appears.

      Example: EnforcedStyleAlignWith: keyword (default)

      # bad

variable = if true
    end

# good

variable = if true
           end

      Example: EnforcedStyleAlignWith: variable

      # bad

variable = if true
    end

# good

variable = if true
end

      Example: EnforcedStyleAlignWith: startofline

      # bad

variable = if true
    end

# good

puts(if true
end)

      Useless assignment to variable - resp.
      Open

                  resp = begin
      Severity: Minor
      Found in modules/mu/providers/aws/database.rb by rubocop

      This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

      assigned but unused variable - foo

      Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

      Example:

      # bad

def some_method
  some_var = 1
  do_something
end

      Example:

      # good

def some_method
  some_var = 1
  do_something(some_var)
end

      end at 1018, 10 is not aligned with case at 1007, 19.
      Open

                end
      Severity: Minor
      Found in modules/mu/providers/aws/database.rb by rubocop

      This cop checks whether the end keywords are aligned properly.

      Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

      If it's set to keyword (which is the default), the end shall be aligned with the start of the keyword (if, class, etc.).

      If it's set to variable the end shall be aligned with the left-hand-side of the variable assignment, if there is one.

      If it's set to start_of_line, the end shall be aligned with the start of the line where the matching keyword appears.

      Example: EnforcedStyleAlignWith: keyword (default)

      # bad

variable = if true
    end

# good

variable = if true
           end

      Example: EnforcedStyleAlignWith: variable

      # bad

variable = if true
    end

# good

variable = if true
end

      Example: EnforcedStyleAlignWith: startofline

      # bad

variable = if true
    end

# good

puts(if true
end)

      end at 1132, 10 is not aligned with if at 1092, 19.
      Open

                end
      Severity: Minor
      Found in modules/mu/providers/aws/database.rb by rubocop

      This cop checks whether the end keywords are aligned properly.

      Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

      If it's set to keyword (which is the default), the end shall be aligned with the start of the keyword (if, class, etc.).

      If it's set to variable the end shall be aligned with the left-hand-side of the variable assignment, if there is one.

      If it's set to start_of_line, the end shall be aligned with the start of the line where the matching keyword appears.

      Example: EnforcedStyleAlignWith: keyword (default)

      # bad

variable = if true
    end

# good

variable = if true
           end

      Example: EnforcedStyleAlignWith: variable

      # bad

variable = if true
    end

# good

variable = if true
end

      Example: EnforcedStyleAlignWith: startofline

      # bad

variable = if true
    end

# good

puts(if true
end)

      Variable bok used in void context.
      Open

                    bok
      Severity: Minor
      Found in modules/mu/providers/aws/database.rb by rubocop

      This cop checks for operators, variables and literals used in void context.

      Example:

      # bad

def some_method
  some_num * 10
  do_something
end

      Example:

      # bad

def some_method(some_var)
  some_var
  do_something
end

      Example:

      # good

def some_method
  do_something
  some_num * 10
end

      Example:

      # good

def some_method(some_var)
  do_something
  some_var
end

      end at 1031, 10 is not aligned with if at 1020, 15.
      Open

                end
      Severity: Minor
      Found in modules/mu/providers/aws/database.rb by rubocop

      This cop checks whether the end keywords are aligned properly.

      Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

      If it's set to keyword (which is the default), the end shall be aligned with the start of the keyword (if, class, etc.).

      If it's set to variable the end shall be aligned with the left-hand-side of the variable assignment, if there is one.

      If it's set to start_of_line, the end shall be aligned with the start of the line where the matching keyword appears.

      Example: EnforcedStyleAlignWith: keyword (default)

      # bad

variable = if true
    end

# good

variable = if true
           end

      Example: EnforcedStyleAlignWith: variable

      # bad

variable = if true
    end

# good

variable = if true
end

      Example: EnforcedStyleAlignWith: startofline

      # bad

variable = if true
    end

# good

puts(if true
end)

      end at 342, 10 is not aligned with if at 334, 19.
      Open

                end
      Severity: Minor
      Found in modules/mu/providers/aws/database.rb by rubocop

      This cop checks whether the end keywords are aligned properly.

      Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

      If it's set to keyword (which is the default), the end shall be aligned with the start of the keyword (if, class, etc.).

      If it's set to variable the end shall be aligned with the left-hand-side of the variable assignment, if there is one.

      If it's set to start_of_line, the end shall be aligned with the start of the line where the matching keyword appears.

      Example: EnforcedStyleAlignWith: keyword (default)

      # bad

variable = if true
    end

# good

variable = if true
           end

      Example: EnforcedStyleAlignWith: variable

      # bad

variable = if true
    end

# good

variable = if true
end

      Example: EnforcedStyleAlignWith: startofline

      # bad

variable = if true
    end

# good

puts(if true
end)

      There are no issues that match your filters.

      Category
      Status