Sign upLogin

cloudamatic/mu

View on GitHub
Star
modules/mu/providers/google/server.rb

Summary

Maintainability
D
2 days
Test Coverage

Class has too many lines. [1204/1000]
Open

      class Server < MU::Cloud::Server

        # Initialize this cloud resource object. Calling +super+ will invoke the initializer defined under {MU::Cloud}, which should set the attribtues listed in {MU::Cloud::PUBLIC_ATTRS} as well as applicable dependency shortcuts, like <tt>@vpc</tt>, for us.
        # @param args [Hash]: Hash of named arguments passed via Ruby's double-splat
        def initialize(**args)
Severity: Minor
Found in modules/mu/providers/google/server.rb by rubocop

This cop checks if the length a class exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for create is too high. [167.3/75]
Open

        def create
          @project_id = MU::Cloud::Google.projectLookup(@config['project'], @deploy).cloud_id

          sa = nil
          retries = 0
Severity: Minor
Found in modules/mu/providers/google/server.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Assignment Branch Condition size for validateConfig is too high. [161.9/75]
Open

        def self.validateConfig(server, configurator)
          ok = true

          server['project'] ||= MU::Cloud::Google.defaultProject(server['credentials'])
Severity: Minor
Found in modules/mu/providers/google/server.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

File server.rb has 1219 lines of code (exceeds 1000 allowed). Consider refactoring.
Open

require 'net/ssh'
require 'net/ssh/multi'
require 'net/ssh/proxy/command'
autoload :OpenStruct, "ostruct"
autoload :Timeout, "timeout"
Severity: Major
Found in modules/mu/providers/google/server.rb - About 7 hrs to fix

    Assignment Branch Condition size for toKitten is too high. [118.8/75]
    Open

            def toKitten(**_args)
          bok = {
            "cloud" => "Google",
            "credentials" => @config['credentials'],
            "cloud_id" => @cloud_id,
    Severity: Minor
    Found in modules/mu/providers/google/server.rb by rubocop

    This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

    Assignment Branch Condition size for validateInstanceType is too high. [95.01/75]
    Open

            def self.validateInstanceType(size, region, project: nil, credentials: nil)
          size = size.dup.to_s
          if @@instance_type_cache[project] and
             @@instance_type_cache[project][region] and
             @@instance_type_cache[project][region][size]
    Severity: Minor
    Found in modules/mu/providers/google/server.rb by rubocop

    This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

    Class Server has 28 methods (exceeds 20 allowed). Consider refactoring.
    Open

          class Server < MU::Cloud::Server

        # Initialize this cloud resource object. Calling +super+ will invoke the initializer defined under {MU::Cloud}, which should set the attribtues listed in {MU::Cloud::PUBLIC_ATTRS} as well as applicable dependency shortcuts, like <tt>@vpc</tt>, for us.
        # @param args [Hash]: Hash of named arguments passed via Ruby's double-splat
        def initialize(**args)
    Severity: Minor
    Found in modules/mu/providers/google/server.rb - About 3 hrs to fix

      Assignment Branch Condition size for getWindowsAdminPassword is too high. [86.41/75]
      Open

              def getWindowsAdminPassword(use_cache: true)
          @config['windows_auth_vault'] ||= {
            "vault" => @mu_name,
            "item" => "windows_credentials",
            "password_field" => "password"
      Severity: Minor
      Found in modules/mu/providers/google/server.rb by rubocop

      This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

      Cyclomatic complexity for create is too high. [33/30]
      Open

              def create
          @project_id = MU::Cloud::Google.projectLookup(@config['project'], @deploy).cloud_id

          sa = nil
          retries = 0
      Severity: Minor
      Found in modules/mu/providers/google/server.rb by rubocop

      This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

      An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

      Perceived complexity for create is too high. [36/35]
      Open

              def create
          @project_id = MU::Cloud::Google.projectLookup(@config['project'], @deploy).cloud_id

          sa = nil
          retries = 0
      Severity: Minor
      Found in modules/mu/providers/google/server.rb by rubocop

      This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

      Example:

      def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

      Avoid more than 4 levels of block nesting.
      Open

                      if latest
                  MU.log "Mapped #{image_id} to #{img.name} with semantic versioning guesswork", MU::WARN
                  @@image_id_map[image_id] = img
                  return @@image_id_map[image_id]
                end
      Severity: Minor
      Found in modules/mu/providers/google/server.rb by rubocop

      This cop checks for excessive nesting of conditional and looping constructs.

      You can configure if blocks are considered using the CountBlocks option. When set to false (the default) blocks are not counted towards the nesting level. Set to true to count blocks as well.

      The maximum level of nesting allowed is configurable.

      Avoid more than 4 levels of block nesting.
      Open

                        if latest.nil? or created > latest
                    latest = created
                    img = candidate
                  end
      Severity: Minor
      Found in modules/mu/providers/google/server.rb by rubocop

      This cop checks for excessive nesting of conditional and looping constructs.

      You can configure if blocks are considered using the CountBlocks option. When set to false (the default) blocks are not counted towards the nesting level. Set to true to count blocks as well.

      The maximum level of nesting allowed is configurable.

      Use =~ in places where the MatchData returned by #match will not be used.
      Open

                if image_id.match(/\//)
      Severity: Minor
      Found in modules/mu/providers/google/server.rb by rubocop

      This cop identifies the use of Regexp#match or String#match, which returns #<MatchData>/nil. The return value of =~ is an integral index/nil and is more performant.

      Example:

      # bad
do_something if str.match(/regex/)
while regex.match('str')
  do_something
end

# good
method(str =~ /regex/)
return value unless regex =~ 'str'

      Use =~ in places where the MatchData returned by #match will not be used.
      Open

                if size.match(/\/?custom-(\d+)-(\d+)(?:-ext)?$/)
      Severity: Minor
      Found in modules/mu/providers/google/server.rb by rubocop

      This cop identifies the use of Regexp#match or String#match, which returns #<MatchData>/nil. The return value of =~ is an integral index/nil and is more performant.

      Example:

      # bad
do_something if str.match(/regex/)
while regex.match('str')
  do_something
end

# good
method(str =~ /regex/)
return value unless regex =~ 'str'

      Use =~ in places where the MatchData returned by #match will not be used.
      Open

                iface.network.match(/(?:^|\/)projects\/(.*?)\/.*?\/networks\/([^\/]+)(?:$|\/)/)
      Severity: Minor
      Found in modules/mu/providers/google/server.rb by rubocop

      This cop identifies the use of Regexp#match or String#match, which returns #<MatchData>/nil. The return value of =~ is an integral index/nil and is more performant.

      Example:

      # bad
do_something if str.match(/regex/)
while regex.match('str')
  do_something
end

# good
method(str =~ /regex/)
return value unless regex =~ 'str'

      Use =~ in places where the MatchData returned by #match will not be used.
      Open

                  server['image_id'].match(/projects\/([^\/]+)\/.*?\/([^\/]+)$/)
      Severity: Minor
      Found in modules/mu/providers/google/server.rb by rubocop

      This cop identifies the use of Regexp#match or String#match, which returns #<MatchData>/nil. The return value of =~ is an integral index/nil and is more performant.

      Example:

      # bad
do_something if str.match(/regex/)
while regex.match('str')
  do_something
end

# good
method(str =~ /regex/)
return value unless regex =~ 'str'

      Use tr instead of gsub.
      Open

                  filter += %Q{ AND (labels.mu-master-ip = "#{MU.mu_public_ip.gsub(/\./, "_")}")}
      Severity: Minor
      Found in modules/mu/providers/google/server.rb by rubocop

      This cop identifies places where gsub can be replaced by tr or delete.

      Example:

      # bad
'abc'.gsub('b', 'd')
'abc'.gsub('a', '')
'abc'.gsub(/a/, 'd')
'abc'.gsub!('a', 'd')

# good
'abc'.gsub(/.*/, 'a')
'abc'.gsub(/a+/, 'd')
'abc'.tr('b', 'd')
'a b c'.delete(' ')

      Use =~ in places where the MatchData returned by #match will not be used.
      Open

                    if tag.match(/^gke-/)
      Severity: Minor
      Found in modules/mu/providers/google/server.rb by rubocop

      This cop identifies the use of Regexp#match or String#match, which returns #<MatchData>/nil. The return value of =~ is an integral index/nil and is more performant.

      Example:

      # bad
do_something if str.match(/regex/)
while regex.match('str')
  do_something
end

# good
method(str =~ /regex/)
return value unless regex =~ 'str'

      Use =~ in places where the MatchData returned by #match will not be used.
      Open

                  disk.source.match(/\/projects\/([^\/]+)\/zones\/([^\/]+)\/disks\/(.*)/)
      Severity: Minor
      Found in modules/mu/providers/google/server.rb by rubocop

      This cop identifies the use of Regexp#match or String#match, which returns #<MatchData>/nil. The return value of =~ is an integral index/nil and is more performant.

      Example:

      # bad
do_something if str.match(/regex/)
while regex.match('str')
  do_something
end

# good
method(str =~ /regex/)
return value unless regex =~ 'str'

      Use =~ in places where the MatchData returned by #match will not be used.
      Open

                  if e.message.match(/^alreadyExists: /)
      Severity: Minor
      Found in modules/mu/providers/google/server.rb by rubocop

      This cop identifies the use of Regexp#match or String#match, which returns #<MatchData>/nil. The return value of =~ is an integral index/nil and is more performant.

      Example:

      # bad
do_something if str.match(/regex/)
while regex.match('str')
  do_something
end

# good
method(str =~ /regex/)
return value unless regex =~ 'str'

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  MU::Cloud.availableClouds.each { |cloud|
              next if cloud == "Google"
              foreign_types = (MU::Cloud.cloudClass(cloud).listInstanceTypes).values.first
              if foreign_types.size == 1
                foreign_types = foreign_types.values.first
      Severity: Major
      Found in modules/mu/providers/google/server.rb and 1 other location - About 3 hrs to fix
      modules/mu/providers/aws/server.rb on lines 1778..1800

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 124.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                if server['image_id'].nil?
            img_id = MU::Cloud.getStockImage("Google", platform: server['platform'])
            if img_id
              server['image_id'] = configurator.getTail("server"+server['name']+"Image", value: img_id, prettyname: "server"+server['name']+"Image", cloudtype: "Google::Apis::ComputeV1::Image")
            else
      Severity: Major
      Found in modules/mu/providers/google/server.rb and 1 other location - About 1 hr to fix
      modules/mu/providers/google/server_pool.rb on lines 388..394

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 63.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                if !@mu_name.nil?
            @config['mu_name'] = @mu_name # XXX whyyyy
            # describe
            @mu_windows_name = @deploydata['mu_windows_name'] if @mu_windows_name.nil? and @deploydata
          else
      Severity: Minor
      Found in modules/mu/providers/google/server.rb and 1 other location - About 50 mins to fix
      modules/mu/providers/aws/server.rb on lines 111..120

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 42.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                if use_cache
            begin
              win_admin_password = @groomer.getSecret(
                vault: @config['windows_auth_vault']['vault'],
                item: @config['windows_auth_vault']['item'],
      Severity: Minor
      Found in modules/mu/providers/google/server.rb and 1 other location - About 40 mins to fix
      modules/mu/providers/aws/server.rb on lines 1179..1189

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 38.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                if MU::Cloud.resourceClass("Google", "VPC").haveRouteToInstance?(cloud_desc, credentials: @config['credentials']) or public_ips.size == 0
            @config['canonical_ip'] = private_ips.first
            return private_ips.first
          else
            @config['canonical_ip'] = public_ips.first
      Severity: Minor
      Found in modules/mu/providers/google/server.rb and 1 other location - About 35 mins to fix
      modules/mu/providers/azure/server.rb on lines 388..394

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 36.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

                    if nat_ssh_user.nil? and !nat_ssh_host.nil?
                MU.log "#{@config["name"]} (#{MU.deploy_id}) is configured to use #{@config['vpc']} NAT #{nat_ssh_host}, but username isn't specified. Guessing root.", MU::ERR, details: caller
                nat_ssh_user = "root"
              end
      Severity: Minor
      Found in modules/mu/providers/google/server.rb and 2 other locations - About 35 mins to fix
      modules/mu/providers/aws/server.rb on lines 440..443
      modules/mu/providers/azure/server.rb on lines 157..160

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 35.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  if img_cfg['image_then_destroy']
              MU.log "Image #{image_id} ready, removing source node #{node}"
              MU::Cloud::Google.compute(credentials: @config['credentials']).delete_instance(
                @project_id,
                @config['availability_zone'],
      Severity: Minor
      Found in modules/mu/providers/google/server.rb and 1 other location - About 25 mins to fix
      modules/mu/providers/azure/server.rb on lines 329..338

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 30.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                  if found.id and !found.kitten
              MU.log "GKE server #{server['name']} failed to locate service account #{server['service_account']} in project #{server['project']}", MU::ERR
              ok = false
            end
      Severity: Minor
      Found in modules/mu/providers/google/server.rb and 2 other locations - About 25 mins to fix
      modules/mu/providers/google/function.rb on lines 552..555
      modules/mu/providers/google/server_pool.rb on lines 369..372

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 29.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                cloud_desc.network_interfaces.each { |iface|
            private_ips << iface.network_ip
            if iface.access_configs
              iface.access_configs.each { |acfg|
                public_ips << acfg.nat_ip if acfg.nat_ip
      Severity: Minor
      Found in modules/mu/providers/google/server.rb and 1 other location - About 15 mins to fix
      modules/mu/providers/google/server.rb on lines 1009..1013

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 25.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                cloud_desc.network_interfaces.each { |iface|
            ips << iface.network_ip
            if iface.access_configs
              iface.access_configs.each { |acfg|
                ips << acfg.nat_ip if acfg.nat_ip
      Severity: Minor
      Found in modules/mu/providers/google/server.rb and 1 other location - About 15 mins to fix
      modules/mu/providers/google/server.rb on lines 983..987

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 25.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Do not suppress exceptions.
      Open

                rescue ::Google::Apis::ClientError
      Severity: Minor
      Found in modules/mu/providers/google/server.rb by rubocop

      This cop checks for rescue blocks with no body.

      Example:

      # bad

def some_method
  do_something
rescue
  # do nothing
end

      Example:

      # bad

begin
  do_something
rescue
  # do nothing
end

      Example:

      # good

def some_method
  do_something
rescue
  handle_exception
end

      Example:

      # good

begin
  do_something
rescue
  handle_exception
end

      Do not suppress exceptions.
      Open

                rescue ::Google::Apis::ClientError
      Severity: Minor
      Found in modules/mu/providers/google/server.rb by rubocop

      This cop checks for rescue blocks with no body.

      Example:

      # bad

def some_method
  do_something
rescue
  # do nothing
end

      Example:

      # bad

begin
  do_something
rescue
  # do nothing
end

      Example:

      # good

def some_method
  do_something
rescue
  handle_exception
end

      Example:

      # good

begin
  do_something
rescue
  handle_exception
end

      Do not suppress exceptions.
      Open

                  rescue MU::Groomer::MuNoSuchSecret, MU::Groomer::RunError
      Severity: Minor
      Found in modules/mu/providers/google/server.rb by rubocop

      This cop checks for rescue blocks with no body.

      Example:

      # bad

def some_method
  do_something
rescue
  # do nothing
end

      Example:

      # bad

begin
  do_something
rescue
  # do nothing
end

      Example:

      # good

def some_method
  do_something
rescue
  handle_exception
end

      Example:

      # good

begin
  do_something
rescue
  handle_exception
end

      Unused method argument - deploy_id.
      Open

              def self.cleanup(noop: false, deploy_id: MU.deploy_id, ignoremaster: false, region: MU.curRegion, credentials: nil, flags: {})
      Severity: Minor
      Found in modules/mu/providers/google/server.rb by rubocop

      This cop checks for unused method arguments.

      Example:

      # bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

      Example:

      # good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

      Useless assignment to variable - did_metadata.
      Open

                did_metadata = false
      Severity: Minor
      Found in modules/mu/providers/google/server.rb by rubocop

      This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

      assigned but unused variable - foo

      Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

      Example:

      # bad

def some_method
  some_var = 1
  do_something
end

      Example:

      # good

def some_method
  some_var = 1
  do_something(some_var)
end

      Do not suppress exceptions.
      Open

                rescue ::Google::Apis::ClientError => e
      Severity: Minor
      Found in modules/mu/providers/google/server.rb by rubocop

      This cop checks for rescue blocks with no body.

      Example:

      # bad

def some_method
  do_something
rescue
  # do nothing
end

      Example:

      # bad

begin
  do_something
rescue
  # do nothing
end

      Example:

      # good

def some_method
  do_something
rescue
  handle_exception
end

      Example:

      # good

begin
  do_something
rescue
  handle_exception
end

      end at 61, 10 is not aligned with if at 37, 22.
      Open

                end
      Severity: Minor
      Found in modules/mu/providers/google/server.rb by rubocop

      This cop checks whether the end keywords are aligned properly.

      Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

      If it's set to keyword (which is the default), the end shall be aligned with the start of the keyword (if, class, etc.).

      If it's set to variable the end shall be aligned with the left-hand-side of the variable assignment, if there is one.

      If it's set to start_of_line, the end shall be aligned with the start of the line where the matching keyword appears.

      Example: EnforcedStyleAlignWith: keyword (default)

      # bad

variable = if true
    end

# good

variable = if true
           end

      Example: EnforcedStyleAlignWith: variable

      # bad

variable = if true
    end

# good

variable = if true
end

      Example: EnforcedStyleAlignWith: startofline

      # bad

variable = if true
    end

# good

puts(if true
end)

      Redundant use of Object#to_s in interpolation.
      Open

                  raise MuError, "Failed to get service account cloud id from #{@config['service_account'].to_s}"
      Severity: Minor
      Found in modules/mu/providers/google/server.rb by rubocop

      This cop checks for string conversion in string interpolation, which is redundant.

      Example:

      # bad

"result is #{something.to_s}"

      Example:

      # good

"result is #{something}"

      Redundant use of Object#to_s in interpolation.
      Open

                    return "custom-#{cpus.to_s}-#{mem.to_s}"
      Severity: Minor
      Found in modules/mu/providers/google/server.rb by rubocop

      This cop checks for string conversion in string interpolation, which is redundant.

      Example:

      # bad

"result is #{something.to_s}"

      Example:

      # good

"result is #{something}"

      Unused method argument - storage.
      Open

              def self.createImage(name: nil, instance_id: nil, storage: {}, exclude_storage: false, project: nil, make_public: false, tags: [], region: nil, family: nil, zone: MU::Cloud::Google.listAZs.sample, credentials: nil)
      Severity: Minor
      Found in modules/mu/providers/google/server.rb by rubocop

      This cop checks for unused method arguments.

      Example:

      # bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

      Example:

      # good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

      Redundant use of Object#to_s in interpolation.
      Open

                    return "custom-#{cpus.to_s}-#{mem.to_s}"
      Severity: Minor
      Found in modules/mu/providers/google/server.rb by rubocop

      This cop checks for string conversion in string interpolation, which is redundant.

      Example:

      # bad

"result is #{something.to_s}"

      Example:

      # good

"result is #{something}"

      There are no issues that match your filters.

      Category
      Status