Sign upLogin

cloudcomputinghust/CAL

View on GitHub
Star
calplus/tests/unit/v1/object_storage/drivers/test_amazon_driver.py

Summary

Maintainability
F
6 days
Test Coverage

File test_amazon_driver.py has 461 lines of code (exceeds 250 allowed). Consider refactoring.
Open

""" AmazonDriver for ObjectStorage
    based on BaseDriver for ObjectStorage Resource
"""

import mock
Severity: Minor
Found in calplus/tests/unit/v1/object_storage/drivers/test_amazon_driver.py - About 7 hrs to fix

    AmazonDriverTest has 22 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class AmazonDriverTest(base.TestCase):
    """Testing class for AmazonDriver"""

    def setUp(self):
        super(AmazonDriverTest, self).setUp()
    Severity: Minor
    Found in calplus/tests/unit/v1/object_storage/drivers/test_amazon_driver.py - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          def test_copy_object_in_same_container_successfully(self):
        self.mock_object(
            self.fake_driver.client, 'copy_object',
            mock.Mock(return_value=fake_copy_object_resp)
        )
      Severity: Major
      Found in calplus/tests/unit/v1/object_storage/drivers/test_amazon_driver.py and 1 other location - About 4 hrs to fix
      calplus/tests/unit/v1/object_storage/drivers/test_amazon_driver.py on lines 481..498

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 83.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          def test_copy_object_in_another_container_successfully(self):
        self.mock_object(
            self.fake_driver.client, 'copy_object',
            mock.Mock(return_value=fake_copy_object_resp)
        )
      Severity: Major
      Found in calplus/tests/unit/v1/object_storage/drivers/test_amazon_driver.py and 1 other location - About 4 hrs to fix
      calplus/tests/unit/v1/object_storage/drivers/test_amazon_driver.py on lines 460..477

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 83.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          def test_delete_object_failed(self):
        self.mock_object(
            self.fake_driver.client, 'delete_object',
            mock.Mock(side_effect=ClientError(
                fake_error_code_resp,
      Severity: Major
      Found in calplus/tests/unit/v1/object_storage/drivers/test_amazon_driver.py and 2 other locations - About 3 hrs to fix
      calplus/tests/unit/v1/object_storage/drivers/test_amazon_driver.py on lines 351..363
      calplus/tests/unit/v1/object_storage/drivers/test_amazon_driver.py on lines 380..392

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 70.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          def test_stat_object_failed(self):
        self.mock_object(
            self.fake_driver.client, 'head_object',
            mock.Mock(side_effect=ClientError(
                fake_error_code_resp,
      Severity: Major
      Found in calplus/tests/unit/v1/object_storage/drivers/test_amazon_driver.py and 2 other locations - About 3 hrs to fix
      calplus/tests/unit/v1/object_storage/drivers/test_amazon_driver.py on lines 351..363
      calplus/tests/unit/v1/object_storage/drivers/test_amazon_driver.py on lines 409..421

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 70.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          def test_download_object_failed(self):
        self.mock_object(
            self.fake_driver.client, 'get_object',
            mock.Mock(side_effect=ClientError(
                fake_error_code_resp,
      Severity: Major
      Found in calplus/tests/unit/v1/object_storage/drivers/test_amazon_driver.py and 2 other locations - About 3 hrs to fix
      calplus/tests/unit/v1/object_storage/drivers/test_amazon_driver.py on lines 380..392
      calplus/tests/unit/v1/object_storage/drivers/test_amazon_driver.py on lines 409..421

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 70.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          def test_stat_container_failed(self):
        self.mock_object(
            self.fake_driver.client, 'head_bucket',
            mock.Mock(side_effect=ClientError(
                fake_error_code_resp,
      Severity: Major
      Found in calplus/tests/unit/v1/object_storage/drivers/test_amazon_driver.py and 1 other location - About 3 hrs to fix
      calplus/tests/unit/v1/network/drivers/test_amazon_driver.py on lines 448..461

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          def test_list_containers_failed(self):
        self.mock_object(
            self.fake_driver.client, 'list_buckets',
            mock.Mock(side_effect=ClientError(
                fake_error_code_resp,
      Severity: Major
      Found in calplus/tests/unit/v1/object_storage/drivers/test_amazon_driver.py and 3 other locations - About 2 hrs to fix
      calplus/tests/unit/v1/compute/drivers/test_amazon_driver.py on lines 264..276
      calplus/tests/unit/v1/network/drivers/test_amazon_driver.py on lines 276..288
      calplus/tests/unit/v1/network/drivers/test_amazon_driver.py on lines 422..435

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 61.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          def test_download_object_successfully(self):
        self.mock_object(
            self.fake_driver.client, 'get_object',
            mock.Mock(return_value=fake_download_object_resp)
        )
      Severity: Major
      Found in calplus/tests/unit/v1/object_storage/drivers/test_amazon_driver.py and 2 other locations - About 2 hrs to fix
      calplus/tests/unit/v1/object_storage/drivers/test_amazon_driver.py on lines 368..375
      calplus/tests/unit/v1/object_storage/drivers/test_amazon_driver.py on lines 397..404

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 61.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          def test_delete_object_successfully(self):
        self.mock_object(
            self.fake_driver.client, 'delete_object',
            mock.Mock(return_value=fake_delete_object_resp)
        )
      Severity: Major
      Found in calplus/tests/unit/v1/object_storage/drivers/test_amazon_driver.py and 2 other locations - About 2 hrs to fix
      calplus/tests/unit/v1/object_storage/drivers/test_amazon_driver.py on lines 339..346
      calplus/tests/unit/v1/object_storage/drivers/test_amazon_driver.py on lines 368..375

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 61.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          def test_stat_object_successfully(self):
        self.mock_object(
            self.fake_driver.client, 'head_object',
            mock.Mock(return_value=fake_stat_object_resp)
        )
      Severity: Major
      Found in calplus/tests/unit/v1/object_storage/drivers/test_amazon_driver.py and 2 other locations - About 2 hrs to fix
      calplus/tests/unit/v1/object_storage/drivers/test_amazon_driver.py on lines 339..346
      calplus/tests/unit/v1/object_storage/drivers/test_amazon_driver.py on lines 397..404

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 61.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          def test_create_container_successfully(self):
        self.mock_object(
            self.fake_driver.client, 'create_bucket',
            mock.Mock(return_value=fake_create_container_resp)
        )
      Severity: Major
      Found in calplus/tests/unit/v1/object_storage/drivers/test_amazon_driver.py and 2 other locations - About 2 hrs to fix
      calplus/tests/unit/v1/object_storage/drivers/test_amazon_driver.py on lines 229..236
      calplus/tests/unit/v1/object_storage/drivers/test_amazon_driver.py on lines 261..268

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 57.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          def test_stat_container_successfully(self):
        self.mock_object(
            self.fake_driver.client, 'head_bucket',
            mock.Mock(return_value=fake_stat_container_resp)
        )
      Severity: Major
      Found in calplus/tests/unit/v1/object_storage/drivers/test_amazon_driver.py and 2 other locations - About 2 hrs to fix
      calplus/tests/unit/v1/object_storage/drivers/test_amazon_driver.py on lines 215..222
      calplus/tests/unit/v1/object_storage/drivers/test_amazon_driver.py on lines 229..236

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 57.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          def test_delete_container_successfully(self):
        self.mock_object(
            self.fake_driver.client, 'delete_bucket',
            mock.Mock(return_value=fake_delete_container_resp)
        )
      Severity: Major
      Found in calplus/tests/unit/v1/object_storage/drivers/test_amazon_driver.py and 2 other locations - About 2 hrs to fix
      calplus/tests/unit/v1/object_storage/drivers/test_amazon_driver.py on lines 215..222
      calplus/tests/unit/v1/object_storage/drivers/test_amazon_driver.py on lines 261..268

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 57.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

          def test_list_containers_successfully(self):
        self.mock_object(
            self.fake_driver.client, 'list_buckets',
            mock.Mock(return_value=fake_list_containers_resp)
        )
      Severity: Major
      Found in calplus/tests/unit/v1/object_storage/drivers/test_amazon_driver.py and 5 other locations - About 2 hrs to fix
      calplus/tests/unit/v1/compute/drivers/test_amazon_driver.py on lines 254..261
      calplus/tests/unit/v1/network/drivers/test_amazon_driver.py on lines 266..273
      calplus/tests/unit/v1/network/drivers/test_amazon_driver.py on lines 412..419
      calplus/tests/unit/v1/network/drivers/test_openstack_driver.py on lines 446..456
      calplus/tests/unit/v1/network/test_client.py on lines 232..239

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      fake_error_code_resp = {
    'ResponseMetadata': {
        'HTTPStatusCode': 400,
        'RequestId': 'req-a4570d1a-8319-4d6f-8077-7044d72ef449',
        'HTTPHeaders': {
      Severity: Minor
      Found in calplus/tests/unit/v1/object_storage/drivers/test_amazon_driver.py and 2 other locations - About 35 mins to fix
      calplus/tests/unit/v1/compute/drivers/test_amazon_driver.py on lines 24..36
      calplus/tests/unit/v1/network/drivers/test_amazon_driver.py on lines 108..120

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 33.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status