Sign upLogin

cloudfoundry-community/bosh-cloudstack-cpi

View on GitHub
Star
blobstore_client/lib/blobstore_client/swift_blobstore_client.rb

Summary

Maintainability
D
1 day
Test Coverage

Method validate_options has a Cognitive Complexity of 55 (exceeds 5 allowed). Consider refactoring.
Open

      def validate_options(options)
        raise "Invalid options format, Hash expected, #{options.class} given" unless options.is_a?(Hash)
        raise 'Swift container name is missing' unless options.has_key?(:container_name)
        raise 'Swift provider is missing' unless options.has_key?(:swift_provider)
        case options[:swift_provider]
Severity: Minor
Found in blobstore_client/lib/blobstore_client/swift_blobstore_client.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_file has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

      def get_file(object_id, file)
        object_info = decode_object_id(object_id)
        if object_info['purl']
          response = @http_client.get(object_info['purl']) do |block|
            file.write(block)
Severity: Minor
Found in blobstore_client/lib/blobstore_client/swift_blobstore_client.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method validate_options has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def validate_options(options)
        raise "Invalid options format, Hash expected, #{options.class} given" unless options.is_a?(Hash)
        raise 'Swift container name is missing' unless options.has_key?(:container_name)
        raise 'Swift provider is missing' unless options.has_key?(:swift_provider)
        case options[:swift_provider]
Severity: Minor
Found in blobstore_client/lib/blobstore_client/swift_blobstore_client.rb - About 1 hr to fix

    Method container has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def container
        return @container if @container

        validate_options(@options)
    Severity: Minor
    Found in blobstore_client/lib/blobstore_client/swift_blobstore_client.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

              when 'hp'
            raise 'HP options are missing' unless options.has_key?(:hp)
            raise "Invalid HP options, Hash expected, #{options[:hp].class} given" unless options[:hp].is_a?(Hash)
            raise 'HP access key is missing' unless options[:hp].has_key?(:hp_access_key)
            raise 'HP secret key is missing' unless options[:hp].has_key?(:hp_secret_key)
    Severity: Major
    Found in blobstore_client/lib/blobstore_client/swift_blobstore_client.rb and 1 other location - About 1 hr to fix
    blobstore_client/lib/blobstore_client/swift_blobstore_client.rb on lines 132..138

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 55.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

              when 'openstack'
            raise 'OpenStack options are missing' unless options.has_key?(:openstack)
            raise "Invalid OpenStack options, Hash expected, #{options[:openstack].class} given" unless options[:openstack].is_a?(Hash)
            raise 'OpenStack authorization URL is missing' unless options[:openstack].has_key?(:openstack_auth_url)
            raise 'OpenStack user name is missing' unless options[:openstack].has_key?(:openstack_username)
    Severity: Major
    Found in blobstore_client/lib/blobstore_client/swift_blobstore_client.rb and 1 other location - About 1 hr to fix
    blobstore_client/lib/blobstore_client/swift_blobstore_client.rb on lines 125..131

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 55.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status