Sign upLogin

cloudfoundry-community/bosh-cloudstack-cpi

View on GitHub
Star
bosh-dev/lib/bosh/dev/sandbox/main.rb

Summary

Maintainability
C
1 day
Test Coverage

Class Main has 27 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Main
    REPO_ROOT = File.expand_path('../../../../../', File.dirname(__FILE__))

    ASSETS_DIR = File.expand_path('bosh-dev/assets/sandbox', REPO_ROOT)
Severity: Minor
Found in bosh-dev/lib/bosh/dev/sandbox/main.rb - About 3 hrs to fix

    File main.rb has 272 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'logger'
require 'benchmark'
require 'securerandom'
require 'bosh/dev/sandbox/service'
require 'bosh/dev/sandbox/socket_connector'
    Severity: Minor
    Found in bosh-dev/lib/bosh/dev/sandbox/main.rb - About 2 hrs to fix

      Method initialize has 53 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def initialize(db_opts, debug, agent_type, test_env_number, logger)
      @debug = debug
      @agent_type = agent_type
      @test_env_number = test_env_number
      @logger = logger
      Severity: Major
      Found in bosh-dev/lib/bosh/dev/sandbox/main.rb - About 2 hrs to fix

        Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def initialize(db_opts, debug, agent_type, test_env_number, logger)
        Severity: Minor
        Found in bosh-dev/lib/bosh/dev/sandbox/main.rb - About 35 mins to fix

          Method from_env has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def self.from_env
      db_opts = {
        type: ENV['DB'] || 'postgresql',
        user: ENV['TRAVIS'] ? 'travis' : 'root',
        password: ENV['TRAVIS'] ? '' : 'password',
          Severity: Minor
          Found in bosh-dev/lib/bosh/dev/sandbox/main.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status