Sign upLogin

cloudfoundry-community/bosh-cloudstack-cpi

View on GitHub
Star
bosh-director/lib/bosh/director/jobs/update_release.rb

Summary

Maintainability
D
2 days
Test Coverage

File update_release.rb has 365 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'common/version/release_version'

module Bosh::Director
  module Jobs
    class UpdateRelease < BaseJob
Severity: Minor
Found in bosh-director/lib/bosh/director/jobs/update_release.rb - About 4 hrs to fix

    Method create_job has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

          def create_job(job_meta)
        name, version = job_meta["name"], job_meta["version"]

        template_attrs = {
          :release => @release_model,
    Severity: Minor
    Found in bosh-director/lib/bosh/director/jobs/update_release.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method create_job has 69 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def create_job(job_meta)
        name, version = job_meta["name"], job_meta["version"]

        template_attrs = {
          :release => @release_model,
    Severity: Major
    Found in bosh-director/lib/bosh/director/jobs/update_release.rb - About 2 hrs to fix

      Class UpdateRelease has 21 methods (exceeds 20 allowed). Consider refactoring.
      Open

          class UpdateRelease < BaseJob
      include LockHelper
      include DownloadHelper

      @queue = :normal
      Severity: Minor
      Found in bosh-director/lib/bosh/director/jobs/update_release.rb - About 2 hrs to fix

        Method process_release has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def process_release
        @release_model = Models::Release.find_or_create(:name => @name)

        if @rebase
          @version = next_release_version
        Severity: Minor
        Found in bosh-director/lib/bosh/director/jobs/update_release.rb - About 1 hr to fix

          Method create_package has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                def create_package(package_meta)
        name, version = package_meta["name"], package_meta["version"]

        package_attrs = {
          :release => @release_model,
          Severity: Minor
          Found in bosh-director/lib/bosh/director/jobs/update_release.rb - About 1 hr to fix

            Method perform has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                  def perform
        logger.info("Processing update release")
        if @rebase
          logger.info("Release rebase will be performed")
        end
            Severity: Minor
            Found in bosh-director/lib/bosh/director/jobs/update_release.rb - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method process_packages has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                  def process_packages
        logger.info("Checking for new packages in release")

        new_packages = []
        existing_packages = []
            Severity: Minor
            Found in bosh-director/lib/bosh/director/jobs/update_release.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method process_release has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                  def process_release
        @release_model = Models::Release.find_or_create(:name => @name)

        if @rebase
          @version = next_release_version
            Severity: Minor
            Found in bosh-director/lib/bosh/director/jobs/update_release.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  def create_jobs(jobs)
        if jobs.empty?
          @jobs_unchanged = true
          return
        end
            Severity: Minor
            Found in bosh-director/lib/bosh/director/jobs/update_release.rb and 1 other location - About 55 mins to fix
            bosh-director/lib/bosh/director/jobs/update_release.rb on lines 242..254

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  def create_packages(packages)
        if packages.empty?
          @packages_unchanged = true
          return
        end
            Severity: Minor
            Found in bosh-director/lib/bosh/director/jobs/update_release.rb and 1 other location - About 55 mins to fix
            bosh-director/lib/bosh/director/jobs/update_release.rb on lines 353..365

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  def use_existing_packages(packages)
        return if packages.empty?

        single_step_stage("Processing #{packages.size} existing package#{"s" if packages.size > 1}") do
          packages.each do |package, _|
            Severity: Minor
            Found in bosh-director/lib/bosh/director/jobs/update_release.rb and 1 other location - About 50 mins to fix
            bosh-director/lib/bosh/director/jobs/update_release.rb on lines 461..468

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 42.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  def use_existing_jobs(jobs)
        return if jobs.empty?

        single_step_stage("Processing #{jobs.size} existing job#{"s" if jobs.size > 1}") do
          jobs.each do |template, _|
            Severity: Minor
            Found in bosh-director/lib/bosh/director/jobs/update_release.rb and 1 other location - About 50 mins to fix
            bosh-director/lib/bosh/director/jobs/update_release.rb on lines 261..268

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 42.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status