Sign upLogin

cloudfoundry-community/bosh-cloudstack-cpi

View on GitHub
Star
bosh-director/lib/bosh/director/validation_helper.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method safe_property has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

    def safe_property(hash, property, options = {})
      result = nil

      if hash && !hash.kind_of?(Hash)
        raise Bosh::Director::ValidationInvalidType,
Severity: Minor
Found in bosh-director/lib/bosh/director/validation_helper.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method safe_property has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def safe_property(hash, property, options = {})
      result = nil

      if hash && !hash.kind_of?(Hash)
        raise Bosh::Director::ValidationInvalidType,
Severity: Minor
Found in bosh-director/lib/bosh/director/validation_helper.rb - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

                if options[:class] == String && result.kind_of?(Numeric)
              result = result.to_s
            else
              invalid_type(property, options[:class], result)
            end
    Severity: Major
    Found in bosh-director/lib/bosh/director/validation_helper.rb - About 45 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if options[:max] && result > options[:max]
          raise ValidationViolatedMax,
                "`#{property}' value (#{result.inspect}) should be less than #{options[:max].inspect}"
        end
      Severity: Minor
      Found in bosh-director/lib/bosh/director/validation_helper.rb and 1 other location - About 15 mins to fix
      bosh-director/lib/bosh/director/validation_helper.rb on lines 28..31

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 25.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if options[:min] && result < options[:min]
          raise ValidationViolatedMin,
                "`#{property}' value (#{result.inspect}) should be greater than #{options[:min].inspect}"
        end
      Severity: Minor
      Found in bosh-director/lib/bosh/director/validation_helper.rb and 1 other location - About 15 mins to fix
      bosh-director/lib/bosh/director/validation_helper.rb on lines 33..36

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 25.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status