Sign upLogin

cloudfoundry-community/bosh-cloudstack-cpi

View on GitHub
Star
bosh_cli/lib/cli/client/director.rb

Summary

Maintainability
F
4 days
Test Coverage

Class Director has 70 methods (exceeds 20 allowed). Consider refactoring.
Open

      class Director

        DIRECTOR_HTTP_ERROR_CODES = [400, 403, 404, 500]

        API_TIMEOUT     = 86400 * 3
Severity: Major
Found in bosh_cli/lib/cli/client/director.rb - About 1 day to fix

    File director.rb has 561 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'cli/core_ext'
require 'cli/errors'

require 'json'
require 'httpclient'
    Severity: Major
    Found in bosh_cli/lib/cli/client/director.rb - About 1 day to fix

      Method request has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

              def request(method, uri, content_type = nil, payload = nil, headers = {}, options = {})
          headers = headers.dup
          headers['Content-Type'] = content_type if content_type

          tmp_file = nil
      Severity: Minor
      Found in bosh_cli/lib/cli/client/director.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method request has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              def request(method, uri, content_type = nil, payload = nil, headers = {}, options = {})
          headers = headers.dup
          headers['Content-Type'] = content_type if content_type

          tmp_file = nil
      Severity: Minor
      Found in bosh_cli/lib/cli/client/director.rb - About 1 hr to fix

        Method request_and_track has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

                def request_and_track(method, uri, options = {})
          options = options.dup

          content_type = options.delete(:content_type)
          payload      = options.delete(:payload)
        Severity: Minor
        Found in bosh_cli/lib/cli/client/director.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method get_task_output has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

                def get_task_output(task_id, offset, log_type = nil)
          uri = "/tasks/#{task_id}/output"
          uri += "?type=#{log_type}" if log_type

          headers                      = { 'Range' => "bytes=#{offset}-" }
        Severity: Minor
        Found in bosh_cli/lib/cli/client/director.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method setup_ssh has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                def setup_ssh(deployment_name, job, index, user,
          public_key, password, options = {})
        Severity: Major
        Found in bosh_cli/lib/cli/client/director.rb - About 50 mins to fix

          Method try_to_perform_http_request has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  def try_to_perform_http_request(method, uri, payload, headers, num_retries, retry_wait_interval, &response_reader)
          Severity: Major
          Found in bosh_cli/lib/cli/client/director.rb - About 50 mins to fix

            Method fetch_logs has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    def fetch_logs(deployment_name, job_name, index, log_type,
          filters = nil, options = {})
            Severity: Minor
            Found in bosh_cli/lib/cli/client/director.rb - About 45 mins to fix

              Method change_job_state has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      def change_job_state(deployment_name, manifest_yaml,
          job_name, index, new_state, options = {})
              Severity: Minor
              Found in bosh_cli/lib/cli/client/director.rb - About 45 mins to fix

                Method request has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        def request(method, uri, content_type = nil, payload = nil, headers = {}, options = {})
                Severity: Minor
                Found in bosh_cli/lib/cli/client/director.rb - About 45 mins to fix

                  Method try_to_perform_http_request has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                          def try_to_perform_http_request(method, uri, payload, headers, num_retries, retry_wait_interval, &response_reader)
          num_retries.downto(1) do |n|
            begin
              return perform_http_request(method, uri, payload, headers, &response_reader)
                  Severity: Minor
                  Found in bosh_cli/lib/cli/client/director.rb - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method rename_job has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          def rename_job(deployment_name, manifest_yaml, old_name, new_name,
          force = false, options = {})
                  Severity: Minor
                  Found in bosh_cli/lib/cli/client/director.rb - About 45 mins to fix

                    Method cleanup_ssh has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                            def cleanup_ssh(deployment_name, job, user_regex, indexes, options = {})
                    Severity: Minor
                    Found in bosh_cli/lib/cli/client/director.rb - About 35 mins to fix

                      Method perform_http_request has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                              def perform_http_request(method, uri, payload = nil, headers = {}, &block)
                      Severity: Minor
                      Found in bosh_cli/lib/cli/client/director.rb - About 35 mins to fix

                        Method get_task has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                        Open

                                def get_task(task_id)
          response_code, body = get("/tasks/#{task_id}")
          raise AuthError if response_code == 401
          raise MissingTask, "Task #{task_id} not found" if response_code == 404
                        Severity: Minor
                        Found in bosh_cli/lib/cli/client/director.rb - About 35 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Similar blocks of code found in 3 locations. Consider refactoring.
                        Open

                                def rebase_remote_release(release_location, options = {})
          options                = options.dup
          payload                = { 'location' => release_location }
          options[:payload]      = JSON.generate(payload)
          options[:content_type] = 'application/json'
                        Severity: Minor
                        Found in bosh_cli/lib/cli/client/director.rb and 2 other locations - About 15 mins to fix
                        bosh_cli/lib/cli/client/director.rb on lines 95..101
                        bosh_cli/lib/cli/client/director.rb on lines 176..182

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 25.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 3 locations. Consider refactoring.
                        Open

                                def upload_remote_release(release_location, options = {})
          options                = options.dup
          payload                = { 'location' => release_location }
          options[:payload]      = JSON.generate(payload)
          options[:content_type] = 'application/json'
                        Severity: Minor
                        Found in bosh_cli/lib/cli/client/director.rb and 2 other locations - About 15 mins to fix
                        bosh_cli/lib/cli/client/director.rb on lines 95..101
                        bosh_cli/lib/cli/client/director.rb on lines 185..191

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 25.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 3 locations. Consider refactoring.
                        Open

                                def upload_remote_stemcell(stemcell_location, options = {})
          options                = options.dup
          payload                = { 'location' => stemcell_location }
          options[:payload]      = JSON.generate(payload)
          options[:content_type] = 'application/json'
                        Severity: Minor
                        Found in bosh_cli/lib/cli/client/director.rb and 2 other locations - About 15 mins to fix
                        bosh_cli/lib/cli/client/director.rb on lines 176..182
                        bosh_cli/lib/cli/client/director.rb on lines 185..191

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 25.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status