Sign upLogin

cloudfoundry-community/bosh-cloudstack-cpi

View on GitHub
Star
go_agent/src/bosh/platform/net/centos_net_manager.go

Summary

Maintainability
B
5 hrs
Test Coverage

Function NewCentosNetManager has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    fs boshsys.FileSystem,
    cmdRunner boshsys.CmdRunner,
    defaultNetworkResolver DefaultNetworkResolver,
    ipResolver boship.IPResolver,
    addressBroadcaster bosharp.AddressBroadcaster,
Severity: Minor
Found in go_agent/src/bosh/platform/net/centos_net_manager.go - About 45 mins to fix

    Method centosNetManager.writeIfcfgs has 5 return statements (exceeds 4 allowed).
    Open

    func (net centosNetManager) writeIfcfgs(networks boshsettings.Networks) ([]customNetwork, error) {
    var modifiedNetworks []customNetwork

    macAddresses, err := net.detectMacAddresses()
    if err != nil {
    Severity: Major
    Found in go_agent/src/bosh/platform/net/centos_net_manager.go - About 35 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func (net centosNetManager) detectMacAddresses() (map[string]string, error) {
    addresses := map[string]string{}

    filePaths, err := net.fs.Glob("/sys/class/net/*")
    if err != nil {
      Severity: Major
      Found in go_agent/src/bosh/platform/net/centos_net_manager.go and 1 other location - About 2 hrs to fix
      go_agent/src/bosh/platform/net/ubuntu_net_manager.go on lines 222..244

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 192.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func (net centosNetManager) writeResolvConf(networks boshsettings.Networks) error {
    buffer := bytes.NewBuffer([]byte{})
    t := template.Must(template.New("resolv-conf").Parse(centosResolvConfTemplate))

    dnsServers := net.getDNSServers(networks)
      Severity: Major
      Found in go_agent/src/bosh/platform/net/centos_net_manager.go and 1 other location - About 1 hr to fix
      go_agent/src/bosh/platform/net/ubuntu_net_manager.go on lines 199..216

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 187.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func NewCentosNetManager(
    fs boshsys.FileSystem,
    cmdRunner boshsys.CmdRunner,
    defaultNetworkResolver DefaultNetworkResolver,
    ipResolver boship.IPResolver,
      Severity: Minor
      Found in go_agent/src/bosh/platform/net/centos_net_manager.go and 1 other location - About 35 mins to fix
      go_agent/src/bosh/platform/net/ubuntu_net_manager.go on lines 34..50

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 103.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status