Sign upLogin

cloudfoundry-community/bosh-cloudstack-cpi

View on GitHub
Star
go_agent/src/code.google.com/p/go.tools/cmd/godoc/codewalk.go

Summary

Maintainability
F
4 days
Test Coverage

Function addrNumber has a Cognitive Complexity of 54 (exceeds 20 allowed). Consider refactoring.
Open

func addrNumber(data []byte, lo, hi int, dir byte, n int, charOffset bool) (int, int, error) {
    switch dir {
    case 0:
        lo = 0
        hi = 0
Severity: Minor
Found in go_agent/src/code.google.com/p/go.tools/cmd/godoc/codewalk.go - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function addrToByteRange has a Cognitive Complexity of 41 (exceeds 20 allowed). Consider refactoring.
Open

func addrToByteRange(addr string, start int, data []byte) (lo, hi int, err error) {
    var (
        dir        byte
        prevc      byte
        charOffset bool
Severity: Minor
Found in go_agent/src/code.google.com/p/go.tools/cmd/godoc/codewalk.go - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function addrToByteRange has 81 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func addrToByteRange(addr string, start int, data []byte) (lo, hi int, err error) {
    var (
        dir        byte
        prevc      byte
        charOffset bool
Severity: Major
Found in go_agent/src/code.google.com/p/go.tools/cmd/godoc/codewalk.go - About 2 hrs to fix

    Function addrNumber has 70 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func addrNumber(data []byte, lo, hi int, dir byte, n int, charOffset bool) (int, int, error) {
    switch dir {
    case 0:
        lo = 0
        hi = 0
    Severity: Minor
    Found in go_agent/src/code.google.com/p/go.tools/cmd/godoc/codewalk.go - About 1 hr to fix

      Function loadCodewalk has 51 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func loadCodewalk(filename string) (*Codewalk, error) {
    f, err := fs.Open(filename)
    if err != nil {
        return nil, err
    }
      Severity: Minor
      Found in go_agent/src/code.google.com/p/go.tools/cmd/godoc/codewalk.go - About 1 hr to fix

        Function addrNumber has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        func addrNumber(data []byte, lo, hi int, dir byte, n int, charOffset bool) (int, int, error) {
        Severity: Minor
        Found in go_agent/src/code.google.com/p/go.tools/cmd/godoc/codewalk.go - About 35 mins to fix

          Function loadCodewalk has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
          Open

          func loadCodewalk(filename string) (*Codewalk, error) {
    f, err := fs.Open(filename)
    if err != nil {
        return nil, err
    }
          Severity: Minor
          Found in go_agent/src/code.google.com/p/go.tools/cmd/godoc/codewalk.go - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function addrNumber has 5 return statements (exceeds 4 allowed).
          Open

          func addrNumber(data []byte, lo, hi int, dir byte, n int, charOffset bool) (int, int, error) {
    switch dir {
    case 0:
        lo = 0
        hi = 0
          Severity: Major
          Found in go_agent/src/code.google.com/p/go.tools/cmd/godoc/codewalk.go - About 35 mins to fix

            Function codewalk has 5 return statements (exceeds 4 allowed).
            Open

            func codewalk(w http.ResponseWriter, r *http.Request) {
    relpath := r.URL.Path[len("/doc/codewalk/"):]
    abspath := r.URL.Path

    r.ParseForm()
            Severity: Major
            Found in go_agent/src/code.google.com/p/go.tools/cmd/godoc/codewalk.go - About 35 mins to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              func addrNumber(data []byte, lo, hi int, dir byte, n int, charOffset bool) (int, int, error) {
    switch dir {
    case 0:
        lo = 0
        hi = 0
              Severity: Major
              Found in go_agent/src/code.google.com/p/go.tools/cmd/godoc/codewalk.go and 1 other location - About 7 hrs to fix
              go_agent/src/code.google.com/p/go.tools/present/args.go on lines 124..201

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 498.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  for addr != "" && err == nil {
        c := addr[0]
        switch c {
        default:
            err = errors.New("invalid address syntax near " + string(c))
              Severity: Major
              Found in go_agent/src/code.google.com/p/go.tools/cmd/godoc/codewalk.go and 1 other location - About 7 hrs to fix
              go_agent/src/code.google.com/p/go.tools/present/args.go on lines 36..107

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 497.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              func redir(w http.ResponseWriter, r *http.Request) (redirected bool) {
    canonical := pathpkg.Clean(r.URL.Path)
    if !strings.HasSuffix(canonical, "/") {
        canonical += "/"
    }
              Severity: Major
              Found in go_agent/src/code.google.com/p/go.tools/cmd/godoc/codewalk.go and 1 other location - About 1 hr to fix
              go_agent/src/code.google.com/p/go.tools/godoc/server.go on lines 395..407

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 150.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              func applyTemplate(t *template.Template, name string, data interface{}) []byte {
    var buf bytes.Buffer
    if err := t.Execute(&buf, data); err != nil {
        log.Printf("%s.Execute: %s", name, err)
    }
              Severity: Minor
              Found in go_agent/src/code.google.com/p/go.tools/cmd/godoc/codewalk.go and 1 other location - About 35 mins to fix
              go_agent/src/code.google.com/p/go.tools/godoc/server.go on lines 387..393

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 104.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status