Sign upLogin

cloudfoundry-community/bosh-cloudstack-cpi

View on GitHub
Star
go_agent/src/code.google.com/p/go.tools/cmd/vet/asmdecl.go

Summary

Maintainability
F
5 days
Test Coverage

Function asmCheck has a Cognitive Complexity of 102 (exceeds 20 allowed). Consider refactoring.
Open

func asmCheck(pkg *Package) {
    if !vet("asmdecl") {
        return
    }
Severity: Minor
Found in go_agent/src/code.google.com/p/go.tools/cmd/vet/asmdecl.go - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method File.asmParseDecl has 206 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (f *File) asmParseDecl(decl *ast.FuncDecl) map[string]*asmFunc {
    var (
        arch   *asmArch
        fn     *asmFunc
        offset int
Severity: Major
Found in go_agent/src/code.google.com/p/go.tools/cmd/vet/asmdecl.go - About 7 hrs to fix

    Method File.asmParseDecl has a Cognitive Complexity of 59 (exceeds 20 allowed). Consider refactoring.
    Open

    func (f *File) asmParseDecl(decl *ast.FuncDecl) map[string]*asmFunc {
    var (
        arch   *asmArch
        fn     *asmFunc
        offset int
    Severity: Minor
    Found in go_agent/src/code.google.com/p/go.tools/cmd/vet/asmdecl.go - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function asmCheckVar has a Cognitive Complexity of 57 (exceeds 20 allowed). Consider refactoring.
    Open

    func asmCheckVar(warnf func(string, ...interface{}), fn *asmFunc, line, expr string, off int, v *asmVar) {
    m := asmOpcode.FindStringSubmatch(line)
    if m == nil {
        warnf("cannot find assembly opcode")
    }
    Severity: Minor
    Found in go_agent/src/code.google.com/p/go.tools/cmd/vet/asmdecl.go - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function asmCheckVar has 98 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func asmCheckVar(warnf func(string, ...interface{}), fn *asmFunc, line, expr string, off int, v *asmVar) {
    m := asmOpcode.FindStringSubmatch(line)
    if m == nil {
        warnf("cannot find assembly opcode")
    }
    Severity: Major
    Found in go_agent/src/code.google.com/p/go.tools/cmd/vet/asmdecl.go - About 2 hrs to fix

      Function asmCheck has 97 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func asmCheck(pkg *Package) {
    if !vet("asmdecl") {
        return
    }
      Severity: Major
      Found in go_agent/src/code.google.com/p/go.tools/cmd/vet/asmdecl.go - About 2 hrs to fix

        Function asmCheckVar has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        func asmCheckVar(warnf func(string, ...interface{}), fn *asmFunc, line, expr string, off int, v *asmVar) {
        Severity: Minor
        Found in go_agent/src/code.google.com/p/go.tools/cmd/vet/asmdecl.go - About 35 mins to fix

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                          case asmInterface:
                    addVar(name, asmVar{
                        name: name + "_itable",
                        kind: asmKind(arch.ptrSize),
                        typ:  "interface itable",
          Severity: Major
          Found in go_agent/src/code.google.com/p/go.tools/cmd/vet/asmdecl.go and 2 other locations - About 45 mins to fix
          go_agent/src/code.google.com/p/go.tools/cmd/vet/asmdecl.go on lines 320..334
          go_agent/src/code.google.com/p/go.tools/cmd/vet/asmdecl.go on lines 375..389

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 116.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                          case asmString:
                    addVar(name, asmVar{
                        name: name + "_base",
                        kind: asmKind(arch.ptrSize),
                        typ:  "string base",
          Severity: Major
          Found in go_agent/src/code.google.com/p/go.tools/cmd/vet/asmdecl.go and 2 other locations - About 45 mins to fix
          go_agent/src/code.google.com/p/go.tools/cmd/vet/asmdecl.go on lines 320..334
          go_agent/src/code.google.com/p/go.tools/cmd/vet/asmdecl.go on lines 336..350

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 116.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                          case asmEmptyInterface:
                    addVar(name, asmVar{
                        name: name + "_type",
                        kind: asmKind(arch.ptrSize),
                        typ:  "interface type",
          Severity: Major
          Found in go_agent/src/code.google.com/p/go.tools/cmd/vet/asmdecl.go and 2 other locations - About 45 mins to fix
          go_agent/src/code.google.com/p/go.tools/cmd/vet/asmdecl.go on lines 336..350
          go_agent/src/code.google.com/p/go.tools/cmd/vet/asmdecl.go on lines 375..389

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 116.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status