Sign upLogin

cloudfoundry-community/bosh-cloudstack-cpi

View on GitHub
Star
go_agent/src/code.google.com/p/go.tools/go/types/predicates.go

Summary

Maintainability
D
2 days
Test Coverage

Function isIdenticalInternal has a Cognitive Complexity of 96 (exceeds 20 allowed). Consider refactoring.
Open

func isIdenticalInternal(x, y Type, p *ifacePair) bool {
    if x == y {
        return true
    }
Severity: Minor
Found in go_agent/src/code.google.com/p/go.tools/go/types/predicates.go - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function isIdenticalInternal has 96 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func isIdenticalInternal(x, y Type, p *ifacePair) bool {
    if x == y {
        return true
    }
Severity: Major
Found in go_agent/src/code.google.com/p/go.tools/go/types/predicates.go - About 2 hrs to fix

    Function isIdenticalInternal has 17 return statements (exceeds 4 allowed).
    Open

    func isIdenticalInternal(x, y Type, p *ifacePair) bool {
    if x == y {
        return true
    }
    Severity: Major
    Found in go_agent/src/code.google.com/p/go.tools/go/types/predicates.go - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                          if p.identical(q) {
                        return true // same pair was compared before
                    }
      Severity: Major
      Found in go_agent/src/code.google.com/p/go.tools/go/types/predicates.go - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                if !isIdenticalInternal(v.typ, w.typ, p) {
                            return false
                        }
        Severity: Major
        Found in go_agent/src/code.google.com/p/go.tools/go/types/predicates.go - About 45 mins to fix

          There are no issues that match your filters.

          Category
          Status