Sign upLogin

cloudfoundry-community/bosh-cloudstack-cpi

View on GitHub
Star
go_agent/src/code.google.com/p/go.tools/godoc/server.go

Summary

Maintainability
D
1 day
Test Coverage

Method handlerServer.GetPageInfo has a Cognitive Complexity of 58 (exceeds 20 allowed). Consider refactoring.
Open

func (h *handlerServer) GetPageInfo(abspath, relpath string, mode PageInfoMode) *PageInfo {
    info := &PageInfo{Dirname: abspath}

    // Restrict to the package files that would be used when building
    // the package on this system.  This makes sure that if there are
Severity: Minor
Found in go_agent/src/code.google.com/p/go.tools/godoc/server.go - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method handlerServer.GetPageInfo has 89 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (h *handlerServer) GetPageInfo(abspath, relpath string, mode PageInfoMode) *PageInfo {
    info := &PageInfo{Dirname: abspath}

    // Restrict to the package files that would be used when building
    // the package on this system.  This makes sure that if there are
Severity: Major
Found in go_agent/src/code.google.com/p/go.tools/godoc/server.go - About 2 hrs to fix

    Method handlerServer.ServeHTTP has 53 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (h *handlerServer) ServeHTTP(w http.ResponseWriter, r *http.Request) {
    if redirect(w, r) {
        return
    }
    Severity: Minor
    Found in go_agent/src/code.google.com/p/go.tools/godoc/server.go - About 1 hr to fix

      Method Presentation.serveFile has 10 return statements (exceeds 4 allowed).
      Open

      func (p *Presentation) serveFile(w http.ResponseWriter, r *http.Request) {
    relpath := r.URL.Path

    // Check to see if we need to redirect or serve another file.
    if m := p.Corpus.MetadataFor(relpath); m != nil {
      Severity: Major
      Found in go_agent/src/code.google.com/p/go.tools/godoc/server.go - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                                if rx.MatchString(m) {
                            if info.Notes == nil {
                                info.Notes = make(map[string][]*doc.Note)
                            }
                            info.Notes[m] = n
        Severity: Major
        Found in go_agent/src/code.google.com/p/go.tools/godoc/server.go - About 45 mins to fix

          Method handlerServer.GetPageInfo has 6 return statements (exceeds 4 allowed).
          Open

          func (h *handlerServer) GetPageInfo(abspath, relpath string, mode PageInfoMode) *PageInfo {
    info := &PageInfo{Dirname: abspath}

    // Restrict to the package files that would be used when building
    // the package on this system.  This makes sure that if there are
          Severity: Major
          Found in go_agent/src/code.google.com/p/go.tools/godoc/server.go - About 40 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            func redirect(w http.ResponseWriter, r *http.Request) (redirected bool) {
    canonical := pathpkg.Clean(r.URL.Path)
    if !strings.HasSuffix(canonical, "/") {
        canonical += "/"
    }
            Severity: Major
            Found in go_agent/src/code.google.com/p/go.tools/godoc/server.go and 1 other location - About 1 hr to fix
            go_agent/src/code.google.com/p/go.tools/cmd/godoc/codewalk.go on lines 85..97

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 150.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

            func applyTemplate(t *template.Template, name string, data interface{}) []byte {
    var buf bytes.Buffer
    if err := t.Execute(&buf, data); err != nil {
        log.Printf("%s.Execute: %s", name, err)
    }
            Severity: Minor
            Found in go_agent/src/code.google.com/p/go.tools/godoc/server.go and 1 other location - About 35 mins to fix
            go_agent/src/code.google.com/p/go.tools/cmd/godoc/codewalk.go on lines 99..105

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 104.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status