Sign upLogin

cloudfoundry-community/bosh-cloudstack-cpi

View on GitHub
Star
go_agent/src/code.google.com/p/go.tools/present/parse.go

Summary

Maintainability
D
2 days
Test Coverage

Function parseSections has a Cognitive Complexity of 75 (exceeds 20 allowed). Consider refactoring.
Open

func parseSections(ctx *Context, name string, lines *Lines, number []int, doc *Doc) ([]Section, error) {
    var sections []Section
    for i := 1; ; i++ {
        // Next non-empty line is title.
        text, ok := lines.nextNonEmpty()
Severity: Minor
Found in go_agent/src/code.google.com/p/go.tools/present/parse.go - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function parseSections has 99 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func parseSections(ctx *Context, name string, lines *Lines, number []int, doc *Doc) ([]Section, error) {
    var sections []Section
    for i := 1; ; i++ {
        // Next non-empty line is title.
        text, ok := lines.nextNonEmpty()
Severity: Major
Found in go_agent/src/code.google.com/p/go.tools/present/parse.go - About 2 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                        if text != "" {
                        text = text[i:]
                    }
    Severity: Major
    Found in go_agent/src/code.google.com/p/go.tools/present/parse.go - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                          if strings.HasPrefix(text, `\.`) { // Backslash escapes initial period.
                        text = text[1:]
                    }
      Severity: Major
      Found in go_agent/src/code.google.com/p/go.tools/present/parse.go - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                            if text[0] == '.' { // Command breaks text block.
                        break
                    }
        Severity: Major
        Found in go_agent/src/code.google.com/p/go.tools/present/parse.go - About 45 mins to fix

          Method Context.Parse has 6 return statements (exceeds 4 allowed).
          Open

          func (ctx *Context) Parse(r io.Reader, name string, mode ParseMode) (*Doc, error) {
    doc := new(Doc)
    lines, err := readLines(r)
    if err != nil {
        return nil, err
          Severity: Major
          Found in go_agent/src/code.google.com/p/go.tools/present/parse.go - About 40 mins to fix

            Function parseSections has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            func parseSections(ctx *Context, name string, lines *Lines, number []int, doc *Doc) ([]Section, error) {
            Severity: Minor
            Found in go_agent/src/code.google.com/p/go.tools/present/parse.go - About 35 mins to fix

              Function parseSections has 5 return statements (exceeds 4 allowed).
              Open

              func parseSections(ctx *Context, name string, lines *Lines, number []int, doc *Doc) ([]Section, error) {
    var sections []Section
    for i := 1; ; i++ {
        // Next non-empty line is title.
        text, ok := lines.nextNonEmpty()
              Severity: Major
              Found in go_agent/src/code.google.com/p/go.tools/present/parse.go - About 35 mins to fix

                There are no issues that match your filters.

                Category
                Status