Sign upLogin

cloudfoundry-community/bosh-cloudstack-cpi

View on GitHub
Star
go_agent/src/code.google.com/p/go.tools/ssa/sanity.go

Summary

Maintainability
D
3 days
Test Coverage

Method sanity.checkBlock has a Cognitive Complexity of 73 (exceeds 20 allowed). Consider refactoring.
Open

func (s *sanity) checkBlock(b *BasicBlock, index int) {
    s.block = b

    if b.Index != index {
        s.errorf("block has incorrect Index %d", b.Index)
Severity: Minor
Found in go_agent/src/code.google.com/p/go.tools/ssa/sanity.go - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method sanity.checkInstr has a Cognitive Complexity of 47 (exceeds 20 allowed). Consider refactoring.
Open

func (s *sanity) checkInstr(idx int, instr Instruction) {
    switch instr := instr.(type) {
    case *If, *Jump, *Return, *Panic:
        s.errorf("control flow instruction not at end of block")
    case *Phi:
Severity: Minor
Found in go_agent/src/code.google.com/p/go.tools/ssa/sanity.go - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method sanity.checkBlock has 100 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (s *sanity) checkBlock(b *BasicBlock, index int) {
    s.block = b

    if b.Index != index {
        s.errorf("block has incorrect Index %d", b.Index)
Severity: Major
Found in go_agent/src/code.google.com/p/go.tools/ssa/sanity.go - About 3 hrs to fix

    Method sanity.checkInstr has 91 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (s *sanity) checkInstr(idx int, instr Instruction) {
    switch instr := instr.(type) {
    case *If, *Jump, *Return, *Panic:
        s.errorf("control flow instruction not at end of block")
    case *Phi:
    Severity: Major
    Found in go_agent/src/code.google.com/p/go.tools/ssa/sanity.go - About 2 hrs to fix

      Method sanity.checkFunction has a Cognitive Complexity of 28 (exceeds 20 allowed). Consider refactoring.
      Open

      func (s *sanity) checkFunction(fn *Function) bool {
    // TODO(adonovan): check Function invariants:
    // - check params match signature
    // - check transient fields are nil
    // - warn if any fn.Locals do not appear among block instructions.
      Severity: Minor
      Found in go_agent/src/code.google.com/p/go.tools/ssa/sanity.go - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method sanity.checkFunction has 55 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (s *sanity) checkFunction(fn *Function) bool {
    // TODO(adonovan): check Function invariants:
    // - check params match signature
    // - check transient fields are nil
    // - warn if any fn.Locals do not appear among block instructions.
      Severity: Minor
      Found in go_agent/src/code.google.com/p/go.tools/ssa/sanity.go - About 1 hr to fix

        Method sanity.checkFinalInstr has 5 return statements (exceeds 4 allowed).
        Open

        func (s *sanity) checkFinalInstr(idx int, instr Instruction) {
    switch instr.(type) {
    case *If:
        if nsuccs := len(s.block.Succs); nsuccs != 2 {
            s.errorf("If-terminated block has %d successors; expected 2", nsuccs)
        Severity: Major
        Found in go_agent/src/code.google.com/p/go.tools/ssa/sanity.go - About 35 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              for _, a := range b.Preds {
        found := false
        for _, bb := range a.Succs {
            if bb == b {
                found = true
          Severity: Minor
          Found in go_agent/src/code.google.com/p/go.tools/ssa/sanity.go and 1 other location - About 40 mins to fix
          go_agent/src/code.google.com/p/go.tools/ssa/sanity.go on lines 277..291

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 109.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              for _, c := range b.Succs {
        found := false
        for _, bb := range c.Preds {
            if bb == b {
                found = true
          Severity: Minor
          Found in go_agent/src/code.google.com/p/go.tools/ssa/sanity.go and 1 other location - About 40 mins to fix
          go_agent/src/code.google.com/p/go.tools/ssa/sanity.go on lines 262..276

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 109.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status