cloudfoundry-incubator/eirini

Method APIConverter.ConvertLRP has 52 lines of code (exceeds 50 allowed). Consider refactoring.

Open

func (c *APIConverter) ConvertLRP(request cf.DesireLRPRequest) (api.LRP, error) {
    env := map[string]string{
        "LANG": "en_US.UTF-8",
    }

Function NewLRPClient has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

    logger lager.Logger,
    secrets SecretsClient,
    statefulSets StatefulSetClient,
    pods PodClient,
    pdbClient PodDisruptionBudgetClient,

Function NewReconciler has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

    logger lager.Logger,
    podClient client.Client,
    jobsClient JobsClient,
    podUpdater PodsClient,
    reporter Reporter,

Method Reconciler.Reconcile has 10 return statements (exceeds 4 allowed).

Open

func (r Reconciler) Reconcile(ctx context.Context, request reconcile.Request) (reconcile.Result, error) {
    logger := r.logger.Session("task-completion-reconciler", lager.Data{"namespace": request.Namespace, "pod-name": request.Name})

    pod := &corev1.Pod{}
    if err := r.runtimeClient.Get(ctx, request.NamespacedName, pod); err != nil {

Method Desirer.Desire has 9 return statements (exceeds 4 allowed).

Open

func (d *Desirer) Desire(ctx context.Context, namespace string, lrp *api.LRP, opts ...shared.Option) error {
    logger := d.logger.Session("desire", lager.Data{"guid": lrp.GUID, "version": lrp.Version, "namespace": namespace})

    statefulSetName, err := utils.GetStatefulsetName(lrp)
    if err != nil {

Function NewLRPToStatefulSetConverter has 7 arguments (exceeds 4 allowed). Consider refactoring.

Open

    applicationServiceAccount string,
    registrySecretName string,
    allowAutomountServiceAccountToken bool,
    allowRunImageAsRoot bool,
    latestMigration int,

Function GetPodState has 8 return statements (exceeds 4 allowed).

Open

func GetPodState(pod corev1.Pod) string {
    if len(pod.Status.ContainerStatuses) == 0 || pod.Status.Phase == corev1.PodUnknown {
        return api.UnknownState
    }

Similar blocks of code found in 8 locations. Consider refactoring.

Open

func (c *PodDisruptionBudget) Create(ctx context.Context, namespace string, podDisruptionBudget *policyv1beta1.PodDisruptionBudget) (*policyv1beta1.PodDisruptionBudget, error) {
    ctx, cancel := context.WithTimeout(ctx, k8sTimeout)
    defer cancel()

    return c.clientSet.PolicyV1beta1().PodDisruptionBudgets(namespace).Create(ctx, podDisruptionBudget, metav1.CreateOptions{})

• Read up
  Read up

Similar blocks of code found in 8 locations. Consider refactoring.

Open

func (c *StatefulSet) Update(ctx context.Context, namespace string, statefulSet *appsv1.StatefulSet) (*appsv1.StatefulSet, error) {
    ctx, cancel := context.WithTimeout(ctx, k8sTimeout)
    defer cancel()

    return c.clientSet.AppsV1().StatefulSets(namespace).Update(ctx, statefulSet, metav1.UpdateOptions{})

• Read up
  Read up

Similar blocks of code found in 8 locations. Consider refactoring.

Open

func (c *Event) Create(ctx context.Context, namespace string, event *corev1.Event) (*corev1.Event, error) {
    ctx, cancel := context.WithTimeout(ctx, k8sTimeout)
    defer cancel()

    return c.clientSet.CoreV1().Events(namespace).Create(ctx, event, metav1.CreateOptions{})

• Read up
  Read up

Similar blocks of code found in 8 locations. Consider refactoring.

Open

func (c *Job) Create(ctx context.Context, namespace string, job *batchv1.Job) (*batchv1.Job, error) {
    ctx, cancel := context.WithTimeout(ctx, k8sTimeout)
    defer cancel()

    return c.clientSet.BatchV1().Jobs(namespace).Create(ctx, job, metav1.CreateOptions{})

• Read up
  Read up

Similar blocks of code found in 8 locations. Consider refactoring.

Open

func (c *Secret) Create(ctx context.Context, namespace string, secret *corev1.Secret) (*corev1.Secret, error) {
    ctx, cancel := context.WithTimeout(ctx, k8sTimeout)
    defer cancel()

    return c.clientSet.CoreV1().Secrets(namespace).Create(ctx, secret, metav1.CreateOptions{})

• Read up
  Read up

Similar blocks of code found in 8 locations. Consider refactoring.

Open

func (c *Secret) Update(ctx context.Context, namespace string, secret *corev1.Secret) (*corev1.Secret, error) {
    ctx, cancel := context.WithTimeout(ctx, k8sTimeout)
    defer cancel()

    return c.clientSet.CoreV1().Secrets(namespace).Update(ctx, secret, metav1.UpdateOptions{})

• Read up
  Read up

Similar blocks of code found in 8 locations. Consider refactoring.

Open

func (c *StatefulSet) Create(ctx context.Context, namespace string, statefulSet *appsv1.StatefulSet) (*appsv1.StatefulSet, error) {
    ctx, cancel := context.WithTimeout(ctx, k8sTimeout)
    defer cancel()

    return c.clientSet.AppsV1().StatefulSets(namespace).Create(ctx, statefulSet, metav1.CreateOptions{})

• Read up
  Read up

Similar blocks of code found in 8 locations. Consider refactoring.

Open

func (c *Event) Update(ctx context.Context, namespace string, event *corev1.Event) (*corev1.Event, error) {
    ctx, cancel := context.WithTimeout(ctx, k8sTimeout)
    defer cancel()

    return c.clientSet.CoreV1().Events(namespace).Update(ctx, event, metav1.UpdateOptions{})

• Read up
  Read up

Function generateReport has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

    pod *v1.Pod,
    reason string,
    exitStatus int,
    exitDescription string,
    crashTimestamp int64,

Method CrashReconciler.Reconcile has 6 return statements (exceeds 4 allowed).

Open

func (c *CrashReconciler) Reconcile(ctx context.Context, request reconcile.Request) (reconcile.Result, error) {
    logger := c.logger.Session("reconcile-pod-crash",
        lager.Data{
            "name":      request.NamespacedName.Name,
            "namespace": request.NamespacedName.Namespace,

Method DefaultCrashEventGenerator.Generate has 6 return statements (exceeds 4 allowed).

Open

func (g DefaultCrashEventGenerator) Generate(ctx context.Context, pod *v1.Pod, logger lager.Logger) (events.CrashEvent, bool) {
    logger = logger.Session("generate-crash-event",
        lager.Data{
            "pod-name": pod.Name,
            "guid":     pod.Annotations[stset.AnnotationProcessGUID],

Method Reconciler.reportIfRequired has 6 return statements (exceeds 4 allowed).

Open

func (r *Reconciler) reportIfRequired(ctx context.Context, pod *corev1.Pod) error {
    if pod.Annotations[jobs.AnnotationCCAckedTaskCompletion] == jobs.TaskCompletedTrue {
        return nil
    }

Similar blocks of code found in 3 locations. Consider refactoring.

Open

func (c *Secret) Get(ctx context.Context, namespace, name string) (*corev1.Secret, error) {
    ctx, cancel := context.WithTimeout(ctx, k8sTimeout)
    defer cancel()

    return c.clientSet.CoreV1().Secrets(namespace).Get(ctx, name, metav1.GetOptions{})

• Read up
  Read up