Sign upLogin

cloudfoundry-incubator/eirini

View on GitHub
Star
k8s/stset/get.go

Summary

Maintainability
A
1 hr
Test Coverage
A
91%

Function NewGetter has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    logger lager.Logger,
    statefulSetGetter StatefulSetByLRPIdentifierGetter,
    podGetter PodGetter,
    eventGetter EventGetter,
    statefulsetToLrpConverter StatefulSetToLRPConverter,
Severity: Minor
Found in k8s/stset/get.go - About 35 mins to fix

    Method Getter.GetInstances has 5 return statements (exceeds 4 allowed).
    Open

    func (g *Getter) GetInstances(ctx context.Context, identifier api.LRPIdentifier) ([]*api.Instance, error) {
    logger := g.logger.Session("get-instance", lager.Data{"guid": identifier.GUID, "version": identifier.Version})
    if _, err := g.getLRP(ctx, logger, identifier); errors.Is(err, eirini.ErrNotFound) {
        return nil, err
    }
    Severity: Major
    Found in k8s/stset/get.go - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status