cloudfoundry-incubator/eirini

Method Executor.migrateObjects has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

func (e *Executor) migrateObjects(ctx context.Context, logger lager.Logger, objects []runtime.Object, objectType ObjectType, setAnnotationFn func(context.Context, runtime.Object, int) error) error {

Method Executor.Migrate has 5 return statements (exceeds 4 allowed).

Open

func (e *Executor) Migrate(ctx context.Context, logger lager.Logger) error {
    logger.Info("migration-start")
    defer logger.Info("migration-end")

    if err := e.verifySequenceIDs(); err != nil {

Method Executor.migrateObjects has 5 return statements (exceeds 4 allowed).

Open

func (e *Executor) migrateObjects(ctx context.Context, logger lager.Logger, objects []runtime.Object, objectType ObjectType, setAnnotationFn func(context.Context, runtime.Object, int) error) error {
    logger.Info("start")
    defer logger.Info("end")

    for i := range objects {

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func (e *Executor) setJobAnnotation(ctx context.Context, obj runtime.Object, seq int) error {
    job, ok := obj.(*batchv1.Job)
    if !ok {
        return fmt.Errorf("expected *batchv1.Job got %T", obj)
    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func (e *Executor) setStatefulSetAnnotation(ctx context.Context, obj runtime.Object, seq int) error {
    stSet, ok := obj.(*appsv1.StatefulSet)
    if !ok {
        return fmt.Errorf("expected *appsv1.StatefulSet, got %T", obj)
    }

• Read up
  Read up