cloudfoundry-incubator/stratos

View on GitHub

Showing 1,111 of 1,370 total issues

Function constructor has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  constructor(
    public kubeEndpointService: KubernetesEndpointService,
    public activatedRoute: ActivatedRoute,
    public store: Store<AppState>,
    private snackbarService: SnackBarService

    Method KubeTerminal.Start has a Cognitive Complexity of 15 (exceeds 8 allowed). Consider refactoring.
    Open

    func (k *KubeTerminal) Start(c echo.Context) error {
        log.Debug("Kube Terminal start request")
    
        endpointGUID := c.Param("guid")
        userGUID := c.Get("user_id").(string)
    Severity: Minor
    Found in src/jetstream/plugins/kubernetes/terminal/start.go - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method TokenStore.FindCNSIToken has a Cognitive Complexity of 15 (exceeds 8 allowed). Consider refactoring.
    Open

    func (d *TokenStore) FindCNSIToken(cnsiGUID string, userGUID string, encryptionKey []byte) (interfaces.TokenRecord, error) {
    
        local, cfg, err := ListKubernetes()
        if err == nil {
            for _, cluster := range local {
    Severity: Minor
    Found in src/jetstream/plugins/desktop/kubernetes/tokens.go - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function MigrateSetupData has 15 return statements (exceeds 4 allowed).
    Open

    func MigrateSetupData(portal interfaces.PortalProxy, configStore Repository) error {
    
        // Determine if we need to migrate data first
        _, ok, err := configStore.GetValue(systemGroupName, configSetupNeededMarker)
        if err != nil {
    Severity: Major
    Found in src/jetstream/repository/console_config/env_lookup.go - About 1 hr to fix

      Function parseAuth has a Cognitive Complexity of 15 (exceeds 8 allowed). Consider refactoring.
      Open

        public parseAuth(cluster: KubeConfigFileCluster, user: KubeConfigFileUser): RowState {
      
          // Default subtype is generic Kubernetes ('') or previously determined/selected sub type
          cluster._subType = cluster._subType || '';
      
      

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function ngOnInit has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        ngOnInit() {
          this.addOrg = new FormGroup({
            orgName: new FormControl('', [Validators.required as any, this.nameTakenValidator()]),
            quotaDefinition: new FormControl(),
          });

        Function ngOnInit has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          ngOnInit() {
            this.boundApps$ = combineLatest([
              this.config$.asObservable().pipe(first()),
              this.row$
            ]).pipe(

          Function userFavoriteGroupsReducer has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          export function userFavoriteGroupsReducer(
            state: IUserFavoritesGroupsState = getDefaultFavoriteGroupsState(),
            action: Action
          ): IUserFavoritesGroupsState {
            switch (action.type) {

            Function getActionBuilder has 35 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              static getActionBuilder(
                configOrBuilder: OrchestratedActionBuilder |
                  EntityRequestActionConfig<OrchestratedActionBuilder> |
                  PaginationRequestActionConfig<OrchestratedActionBuilder>,
                actionKey: string,

              Function apply has 35 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                private apply(response) {
                  if (response) {
                    // In order to supplement the sanitizers with extra properties need to create new obj (see spread below and `reduce`)
                    response = {
                      ...response,

                Function getPaginationStore has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  static getPaginationStore<Y, ABC extends OrchestratedActionBuilders = OrchestratedActionBuilders>(
                    builders: KnownActionBuilders<ABC>,
                    entityKey: string,
                    getSchema: (schema: string) => EntitySchema
                  ): CustomEntityCatalogEntityStore<Y, ABC> {

                  Method Analysis.checkStatus has 59 lines of code (exceeds 50 allowed). Consider refactoring.
                  Open

                  func (c *Analysis) checkStatus() error {
                      log.Debug("Checking status....")
                      p := c.portalProxy
                      // Create a record in the reports datastore
                      dbStore, err := store.NewAnalysisDBStore(p.GetDatabaseConnection())
                  Severity: Minor
                  Found in src/jetstream/plugins/analysis/status.go - About 1 hr to fix

                    Method PgsqlTokenRepository.UpdateTokenAuth has 59 lines of code (exceeds 50 allowed). Consider refactoring.
                    Open

                    func (p *PgsqlTokenRepository) UpdateTokenAuth(userGUID string, tr interfaces.TokenRecord, encryptionKey []byte) error {
                        log.Debug("UpdateTokenAuth")
                    
                        if userGUID == "" {
                            msg := "Unable to save Token without a valid User GUID."
                    Severity: Minor
                    Found in src/jetstream/repository/tokens/pgsql_tokens.go - About 1 hr to fix

                      Function constructor has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        constructor(
                          store: Store<CFAppState>,
                          datePipe: DatePipe,
                          scmService: GitSCMService
                        ) {

                        Function waitForRow has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                              function waitForRow() {
                                // Timeout after 32 attempts (each 5 seconds, which is just under 3 minutes)
                                let retries = 32;
                                const sub = timer(5000, 5000).pipe(
                                  switchMap(() => promise.all<boolean | number | TableData[]>([
                        Severity: Minor
                        Found in src/test-e2e/application/application-autoscaler-e2e.spec.ts - About 1 hr to fix

                          Function setupList has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                            private setupList(store: Store<CFAppState>, appService: ApplicationService) {
                              const listActionAddRoute: IGlobalListAction<APIResource> = {
                                action: () => {
                                  appService.application$.pipe(
                                    take(1),

                            Function getPaginationUpdater has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                            const getPaginationUpdater = (types: [string, string, string]) => {
                              const [requestType, successType, failureType] = types;
                              return (state: PaginationEntityState = getDefaultPaginationEntityState(), action): PaginationEntityState => {
                                switch (action.type) {
                                  case requestType:

                              Function setActive has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                setActive(index: number) {
                                  if (this.basePreviousRedirect && index < 0) {
                                    this.dispatchRedirect(this.basePreviousRedirect);
                                  }
                                  if (!this.canGoto(index)) {

                                Function canActivate has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                  canActivate(route: ActivatedRouteSnapshot, routeState: RouterStateSnapshot): Observable<boolean> {
                                    // Reroute user to endpoint/no endpoint screens if there are no connected or registered endpoints
                                    return observableCombineLatest(
                                      this.store.select('auth'),
                                      this.store.select(endpointStatusSelector)
                                Severity: Minor
                                Found in src/frontend/packages/core/src/core/endpoints.service.ts - About 1 hr to fix

                                  Function ngOnInit has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                                  Open

                                    ngOnInit() {
                                      if (!this.connectionStatus) {
                                        return;
                                      }
                                  
                                  
                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language