Sign upLogin

cloudfoundry-incubator/stratos

View on GitHub
Star

Showing 1,111 of 1,370 total issues

Method ConsoleConfig.IsSetupComplete has 5 return statements (exceeds 4 allowed).
Open

func (consoleConfig *ConsoleConfig) IsSetupComplete() bool {

    // No auth, then setup is complete
    if AuthEndpointTypes[consoleConfig.AuthEndpointType] == AuthNone {
        return true
Severity: Major
Found in src/jetstream/repository/interfaces/structs.go - About 35 mins to fix

    Method KubeConfigFile.GetUserForCluster has 5 return statements (exceeds 4 allowed).
    Open

    func (k *KubeConfigFile) GetUserForCluster(clusterEndpoint string) (*KubeConfigUser, error) {

    var cluster *KubeConfigCluster
    var err error
    Severity: Major
    Found in src/jetstream/plugins/kubernetes/config/kube_config.go - About 35 mins to fix

      Method portalProxy.RefreshOAuthToken has 5 return statements (exceeds 4 allowed).
      Open

      func (p *portalProxy) RefreshOAuthToken(skipSSLValidation bool, cnsiGUID, userGUID, client, clientSecret, tokenEndpoint string) (t interfaces.TokenRecord, err error) {
    log.Debug("refreshToken")
    userToken, ok := p.GetCNSITokenRecordWithDisconnected(cnsiGUID, userGUID)
    if !ok {
        return t, fmt.Errorf("Info could not be found for user with GUID %s", userGUID)
      Severity: Major
      Found in src/jetstream/oauth_requests.go - About 35 mins to fix

        Method PgsqlTokenRepository.FindAuthToken has 5 return statements (exceeds 4 allowed).
        Open

        func (p *PgsqlTokenRepository) FindAuthToken(userGUID string, encryptionKey []byte) (interfaces.TokenRecord, error) {
    log.Debug("FindAuthToken")
    if userGUID == "" {
        msg := "Unable to find UAA Token without a valid User GUID."
        log.Debug(msg)
        Severity: Major
        Found in src/jetstream/repository/tokens/pgsql_tokens.go - About 35 mins to fix

          Function row has a Cognitive Complexity of 10 (exceeds 8 allowed). Consider refactoring.
          Open

            @Input('row')
  set row(row: APIResource<IServiceInstance>) {
    super.row = row;
    if (row) {
      this.serviceInstanceEntity = row;
          Severity: Minor
          Found in src/frontend/packages/cloud-foundry/src/shared/components/list/list-types/services-wall/service-instance-card/service-instance-card.component.ts - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function jetstreamErrorHandler has a Cognitive Complexity of 10 (exceeds 8 allowed). Consider refactoring.
          Open

          export function jetstreamErrorHandler(
  error: any,
  action: EntityRequestAction,
  catalogEntity: StratosBaseCatalogEntity,
  requestType: ApiRequestTypes,
          Severity: Minor
          Found in src/frontend/packages/store/src/entity-request-pipeline/entity-request-base-handlers/jetstream-error.handler.ts - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function constructor has a Cognitive Complexity of 10 (exceeds 8 allowed). Consider refactoring.
          Open

            constructor(
    private store: Store<any>,
    private route: ActivatedRoute,
    router: Router,
    kubeId: BaseKubeGuid,
          Severity: Minor
          Found in src/frontend/packages/kubernetes/src/kubernetes/kubernetes-resource/kubernetes-resource-list/kubernetes-resource-list.component.ts - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function ngOnInit has a Cognitive Complexity of 10 (exceeds 8 allowed). Consider refactoring.
          Open

            ngOnInit() {

    const helmLastModifiedRegEx = /seconds:([0-9]*)/;

    this.sessionData$ = this.store.select(s => s.auth).pipe(
          Severity: Minor
          Found in src/frontend/packages/core/src/features/about/diagnostics-page/diagnostics-page.component.ts - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function arraysEqual has a Cognitive Complexity of 10 (exceeds 8 allowed). Consider refactoring.
          Open

          export const arraysEqual = (a: any[], b: any[]): boolean => {
  // Both falsy
  if (!a && !b) {
    return true;
  }
          Severity: Minor
          Found in src/frontend/packages/core/src/core/utils.service.ts - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function applyRoutesFromExtensions has a Cognitive Complexity of 10 (exceeds 8 allowed). Consider refactoring.
          Open

            private applyRoutesFromExtensions(router: Router) {
    const routeConfig = [...router.config];

    // Find the route that has the 'about' page as a child - this is the dashboard base
    const dashboardRoute = routeConfig.find(r => {
          Severity: Minor
          Found in src/frontend/packages/core/src/core/extension/extension-service.ts - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function ngOnInit has a Cognitive Complexity of 10 (exceeds 8 allowed). Consider refactoring.
          Open

            ngOnInit() {
    const events$ = this.eventService.events$.pipe(
      map(events => {
        if (this.endpointOnly) {
          return events.filter(event => event.key.split('-')[0] === 'endpointError');
          Severity: Minor
          Found in src/frontend/packages/core/src/features/event-page/events-page/events-page.component.ts - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          func (c *KubernetesSpecification) GetReleaseHistory(ec echo.Context) error {
    endpointGUID := ec.Param("endpoint")
    releaseName := ec.Param("name")
    namespace := ec.Param("namespace")
          Severity: Minor
          Found in src/jetstream/plugins/kubernetes/install_release.go and 1 other location - About 35 mins to fix
          src/jetstream/plugins/kubernetes/install_release.go on lines 136..157

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 204.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          func (c *KubernetesSpecification) DeleteRelease(ec echo.Context) error {
    endpointGUID := ec.Param("endpoint")
    releaseName := ec.Param("name")
    namespace := ec.Param("namespace")
          Severity: Minor
          Found in src/jetstream/plugins/kubernetes/install_release.go and 1 other location - About 35 mins to fix
          src/jetstream/plugins/kubernetes/install_release.go on lines 160..181

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 204.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Avoid too many return statements within this function.
          Open

              return {
      label: 'Unknown',
      indicator: StratosStatus.ERROR,
      actions: null
    };
          Severity: Major
          Found in src/frontend/packages/cloud-foundry/src/shared/services/application-state.service.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return {
        ...state,
        isSetByUsername: isSetByUsernameAction.isSetByUsername
      };
            Severity: Major
            Found in src/frontend/packages/cloud-foundry/src/store/reducers/cf-users-roles.reducer.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return {
        ...state,
        isRemove: isRemoveAction.isRemove
      };
              Severity: Major
              Found in src/frontend/packages/cloud-foundry/src/store/reducers/cf-users-roles.reducer.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return {
        ...state,
        changedRoles: setChangesAction.changes
      };
                Severity: Major
                Found in src/frontend/packages/cloud-foundry/src/store/reducers/cf-users-roles.reducer.ts - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                      return true;
                  Severity: Major
                  Found in src/frontend/packages/devkit/src/lib/packages.ts - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                return appStateMatch[extState];
                    Severity: Major
                    Found in src/frontend/packages/cloud-foundry/src/shared/services/application-state.service.ts - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                          return '';
                      Severity: Major
                      Found in src/frontend/packages/cloud-foundry/src/features/applications/deploy-application/deploy-application-deployer.ts - About 30 mins to fix
                        Severity
                        Category
                        Status
                        Source
                        Language