cloudfoundry-incubator/stratos

View on GitHub

Showing 1,111 of 1,370 total issues

Function ngOnInit has a Cognitive Complexity of 20 (exceeds 8 allowed). Consider refactoring.
Open

  public ngOnInit() {
    const contentElement = this.content.nativeElement;
    const containerElement = this.container.nativeElement;

    this.stopped$ = new BehaviorSubject<boolean>(false);

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function KubeDashboardProxy has 81 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func KubeDashboardProxy(c echo.Context, p interfaces.PortalProxy, config *rest.Config) error {
    log.Debugf("KubeDashboardProxy request for: %s", c.Request().RequestURI)

    cnsiGUID := c.Param("guid")
    prefix := "/pp/v1/apps/kubedash/ui/" + cnsiGUID + "/"
Severity: Major
Found in src/jetstream/plugins/kubernetes/dashboard/proxy.go - About 2 hrs to fix

    Function getFolderSource has 80 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func getFolderSource(clientWebSocket *websocket.Conn, tempDir string, msg SocketMessage) (StratosProject, string, error) {
        // The msg data is JSON for the Folder info
        info := FolderSourceInfo{
            WaitAfterUpload: false,
        }
    Severity: Major
    Found in src/jetstream/plugins/cfapppush/deploy.go - About 2 hrs to fix

      Method MetricsSpecification.Connect has 80 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (m *MetricsSpecification) Connect(ec echo.Context, cnsiRecord interfaces.CNSIRecord, userId string) (*interfaces.TokenRecord, bool, error) {
          log.Debug("Metrics Connect...")
      
          params := new(interfaces.LoginToCNSIParams)
          err := interfaces.BindOnce(params, ec)
      Severity: Major
      Found in src/jetstream/plugins/metrics/main.go - About 2 hrs to fix

        Function constructor has 55 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          constructor(
            private perms: CurrentUserPermissionsService,
            private scmService: GitSCMService
          ) {
            const scms: { [deployId: string]: GitSCM; } = {

          Function constructor has 55 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            constructor(private store: Store<AppState>, private activatedRoute: ActivatedRoute) {
              // Determine the starting state of the filter by repo section
              stratosEntityCatalog.endpoint.store.getAll.getPaginationService().entities$.pipe(
                filter(entities => !!entities),
                first()

            cfV2Actor has 21 methods (exceeds 20 allowed). Consider refactoring.
            Open

            type cfV2Actor struct {
                wrapped         pushaction.V2Actor
                sent            bool
                msgSender       DeployAppMessageSender
                clientWebsocket *websocket.Conn
            Severity: Minor
            Found in src/jetstream/plugins/cfapppush/push_actor.go - About 2 hrs to fix

              Method Analysis.doRunReport has 79 lines of code (exceeds 50 allowed). Consider refactoring.
              Open

              func (c *Analysis) doRunReport(ec echo.Context, analyzer, endpointID, userID string, dbStore store.AnalysisStore, report *store.AnalysisRecord) error {
              
                  // Get Kube Config
                  k8s := c.portalProxy.GetPlugin("kubernetes")
                  if k8s == nil {
              Severity: Major
              Found in src/jetstream/plugins/analysis/run.go - About 2 hrs to fix

                Function validate has 54 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  private validate(endpoints: EndpointModel[], cluster: KubeConfigFileCluster, clusters: KubeConfigFileCluster[]) {
                    cluster._invalid = false;
                    let reset = true;
                
                    const found = endpoints.find(item => item.name === cluster.name);

                  Function constructor has 54 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    constructor(
                      catalogEntity: StratosBaseCatalogEntity,
                      { endpointGuid, paginationKey = catalogEntity.entityKey + '-list', extraArgs }: GetMultipleActionConfig,
                      store: Store<any>,
                    ) {

                    Function ngOnInit has 54 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      ngOnInit() {
                        const defaultGetCellConfig = () => ({
                          entityKey: this.entityKey,
                          schema: this.schema,
                          monitorState: this.monitorState,

                      File autoscaler-util.ts has 256 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      import moment from 'moment-timezone';
                      
                      import {
                        AppAutoscalerMetricDataPoint,
                        AppAutoscalerMetricLegend,

                        Method portalProxy.ProxyRequest has 78 lines of code (exceeds 50 allowed). Consider refactoring.
                        Open

                        func (p *portalProxy) ProxyRequest(c echo.Context, uri *url.URL) (map[string]*interfaces.CNSIRequest, error) {
                            log.Debug("ProxyRequest")
                            cnsiList := strings.Split(c.Request().Header.Get("x-cap-cnsi-list"), ",")
                            shouldPassthrough := "true" == c.Request().Header.Get("x-cap-passthrough")
                            longRunning := "true" == c.Request().Header.Get(longRunningTimeoutHeader)
                        Severity: Major
                        Found in src/jetstream/passthrough.go - About 2 hrs to fix

                          Method PgsqlTokenRepository.SaveCNSIToken has 78 lines of code (exceeds 50 allowed). Consider refactoring.
                          Open

                          func (p *PgsqlTokenRepository) SaveCNSIToken(cnsiGUID string, userGUID string, tr interfaces.TokenRecord, encryptionKey []byte) error {
                              log.Debug("SaveCNSIToken")
                              if cnsiGUID == "" {
                                  msg := "Unable to save CNSI Token without a valid CNSI GUID."
                                  log.Debug(msg)
                          Severity: Major
                          Found in src/jetstream/repository/tokens/pgsql_tokens.go - About 2 hrs to fix

                            Function getObservables has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                            function getObservables<T = any>(
                              store: Store<GeneralEntityAppState>,
                              entityKey: string,
                              paginationKey: string,
                              paginationAction: PaginatedAction | PaginatedAction[],

                              File local-list-controller.spec.ts has 255 lines of code (exceeds 250 allowed). Consider refactoring.
                              Open

                              import { getCurrentPageStartIndex, splitCurrentPage } from './local-list-controller.helpers';
                              
                              describe('LocalListController', () => {
                                const page = [
                                  [1,

                                Method MetricsSpecification.UpdateMetadata has a Cognitive Complexity of 19 (exceeds 8 allowed). Consider refactoring.
                                Open

                                func (m *MetricsSpecification) UpdateMetadata(info *interfaces.Info, userGUID string, echoContext echo.Context) {
                                
                                    metricsProviders := make([]MetricsMetadata, 0)
                                    // Go through the metrics endpoints and get the corresponding services from the token metadata
                                    if metrics, ok := info.Endpoints[EndpointType]; ok {
                                Severity: Minor
                                Found in src/jetstream/plugins/metrics/main.go - About 2 hrs to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Method portalProxy.registerRoutes has a Cognitive Complexity of 19 (exceeds 8 allowed). Consider refactoring.
                                Open

                                func (p *portalProxy) registerRoutes(e *echo.Echo, needSetupMiddleware bool) {
                                    log.Debug("registerRoutes")
                                
                                    e.GET("/swagger/*", echoSwagger.WrapHandler)
                                
                                
                                Severity: Minor
                                Found in src/jetstream/main.go - About 2 hrs to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Method Monocular.artifactHubGetIcon has a Cognitive Complexity of 19 (exceeds 8 allowed). Consider refactoring.
                                Open

                                func (m *Monocular) artifactHubGetIcon(c echo.Context) error {
                                    endpoint := c.Param("guid")
                                    repo := c.Param("repo")
                                    chartName := c.Param("name")
                                    version := c.Param("version")
                                Severity: Minor
                                Found in src/jetstream/plugins/monocular/artifacthub.go - About 2 hrs to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Method Analysis.checkStatus has a Cognitive Complexity of 19 (exceeds 8 allowed). Consider refactoring.
                                Open

                                func (c *Analysis) checkStatus() error {
                                    log.Debug("Checking status....")
                                    p := c.portalProxy
                                    // Create a record in the reports datastore
                                    dbStore, err := store.NewAnalysisDBStore(p.GetDatabaseConnection())
                                Severity: Minor
                                Found in src/jetstream/plugins/analysis/status.go - About 2 hrs to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Severity
                                Category
                                Status
                                Source
                                Language