Sign upLogin

cloudfoundry-incubator/stratos

View on GitHub
Star
src/jetstream/custombinder/custombinder.go

Summary

Maintainability
C
1 day
Test Coverage

Method CustomBinder.bindData has a Cognitive Complexity of 41 (exceeds 8 allowed). Consider refactoring.
Open

func (b *CustomBinder) bindData(ptr interface{}, data map[string][]string, tag string) error {
    typ := reflect.TypeOf(ptr).Elem()
    val := reflect.ValueOf(ptr).Elem()

    if typ.Kind() != reflect.Struct {
Severity: Minor
Found in src/jetstream/custombinder/custombinder.go - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method CustomBinder.bindData has 57 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (b *CustomBinder) bindData(ptr interface{}, data map[string][]string, tag string) error {
    typ := reflect.TypeOf(ptr).Elem()
    val := reflect.ValueOf(ptr).Elem()

    if typ.Kind() != reflect.Struct {
Severity: Minor
Found in src/jetstream/custombinder/custombinder.go - About 1 hr to fix

    Method CustomBinder.bindData has 6 return statements (exceeds 4 allowed).
    Open

    func (b *CustomBinder) bindData(ptr interface{}, data map[string][]string, tag string) error {
    typ := reflect.TypeOf(ptr).Elem()
    val := reflect.ValueOf(ptr).Elem()

    if typ.Kind() != reflect.Struct {
    Severity: Major
    Found in src/jetstream/custombinder/custombinder.go - About 40 mins to fix

      Method CustomBinder.Bind has 5 return statements (exceeds 4 allowed).
      Open

      func (b *CustomBinder) Bind(i interface{}, c echo.Context) error {
    db := new(echo.DefaultBinder)
    err := db.Bind(i, c)

    if err != nil {
      Severity: Major
      Found in src/jetstream/custombinder/custombinder.go - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status