cloudfoundry-incubator/stratos

View on GitHub
src/jetstream/datastore/datastore.go

Summary

Maintainability
A
3 hrs
Test Coverage

Function NewDatabaseConnectionParametersFromConfig has a Cognitive Complexity of 14 (exceeds 8 allowed). Consider refactoring.
Open

func NewDatabaseConnectionParametersFromConfig(dc DatabaseConfig) (DatabaseConfig, error) {

    if len(dc.DatabaseProvider) == 0 {
        dc.DatabaseProvider = DefaultDatabaseProvider
    }
Severity: Minor
Found in src/jetstream/datastore/datastore.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function WaitForMigrations has a Cognitive Complexity of 14 (exceeds 8 allowed). Consider refactoring.
Open

func WaitForMigrations(db *sql.DB) error {
    migrations := GetOrderedMigrations()
    targetVersion := migrations[len(migrations)-1]

    // Timeout after which we will give up
Severity: Minor
Found in src/jetstream/datastore/datastore.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function NewDatabaseConnectionParametersFromConfig has 7 return statements (exceeds 4 allowed).
Open

func NewDatabaseConnectionParametersFromConfig(dc DatabaseConfig) (DatabaseConfig, error) {

    if len(dc.DatabaseProvider) == 0 {
        dc.DatabaseProvider = DefaultDatabaseProvider
    }
Severity: Major
Found in src/jetstream/datastore/datastore.go - About 45 mins to fix

    There are no issues that match your filters.

    Category
    Status