cloudfoundry-incubator/stratos

View on GitHub
src/jetstream/plugins/cfappssh/app_ssh.go

Summary

Maintainability
C
7 hrs
Test Coverage

Method CFAppSSH.appSSH has 94 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (cfAppSsh *CFAppSSH) appSSH(c echo.Context) error {
    // Need to get info for the endpoint
    // Get the CNSI and app IDs from route parameters
    cnsiGUID := c.Param("cnsiGuid")
    userGUID := c.Get("user_id").(string)
Severity: Major
Found in src/jetstream/plugins/cfappssh/app_ssh.go - About 2 hrs to fix

    Method CFAppSSH.appSSH has a Cognitive Complexity of 22 (exceeds 8 allowed). Consider refactoring.
    Open

    func (cfAppSsh *CFAppSSH) appSSH(c echo.Context) error {
        // Need to get info for the endpoint
        // Get the CNSI and app IDs from route parameters
        cnsiGUID := c.Param("cnsiGuid")
        userGUID := c.Get("user_id").(string)
    Severity: Minor
    Found in src/jetstream/plugins/cfappssh/app_ssh.go - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method CFAppSSH.appSSH has 13 return statements (exceeds 4 allowed).
    Open

    func (cfAppSsh *CFAppSSH) appSSH(c echo.Context) error {
        // Need to get info for the endpoint
        // Get the CNSI and app IDs from route parameters
        cnsiGUID := c.Param("cnsiGuid")
        userGUID := c.Get("user_id").(string)
    Severity: Major
    Found in src/jetstream/plugins/cfappssh/app_ssh.go - About 1 hr to fix

      Function getSSHCode has 8 return statements (exceeds 4 allowed).
      Open

      func getSSHCode(authorizeEndpoint, clientID, token string, skipSSLValidation bool) (string, error) {
          authorizeURL, err := url.Parse(authorizeEndpoint)
          if err != nil {
              return "", err
          }
      Severity: Major
      Found in src/jetstream/plugins/cfappssh/app_ssh.go - About 50 mins to fix

        There are no issues that match your filters.

        Category
        Status